rustc: Don't die on 0-length pattern idents #13782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These often crop up when using default methods that don't actually bind their argument names. Closes rust-lang#13775
|
Is this something we want to support? It might make more sense to force the use of |
|
Not necessarily, but while we do we shouldn't ICE. There are a number of places where we allow this form of short-hand, but sadly this does lead to ambiguities (#12778) |
| // except according to those terms. | ||
|
|
||
| trait Foo { | ||
| fn bar(&self, int) {} |
There was a problem hiding this comment.
Probably not really necessary but it would be good to have an implementation of this trait to make sure it works as expected.
|
I don't mind having this kind of short-hands. However, it may be weird to be able to use them in trait definitions but not implementations. 👍 for landing this until we figure out what to do about it. |
bors
added a commit
that referenced
this pull request
May 5, 2014
These often crop up when using default methods that don't actually bind their argument names. Closes #13775
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These often crop up when using default methods that don't actually bind their
argument names.
Closes #13775