Rollup of 12 pull requests #138416

Manishearth · 2025-03-12T17:19:37Z

Successful merges:

Stabilize std::io::ErrorKind::InvalidFilename #134076 (Stabilize std::io::ErrorKind::InvalidFilename)
Move methods from Map to TyCtxt, part 4. #137504 (Move methods from Map to TyCtxt, part 4.)
Support rmeta inputs for --crate-type=bin --emit=obj #138175 (Support rmeta inputs for --crate-type=bin --emit=obj)
Disentangle ForwardGenericParamBan and ConstParamTy ribs #138259 (Disentangle ForwardGenericParamBan and ConstParamTy ribs)
fix ICE in pretty-printing global_asm! #138280 (fix ICE in pretty-printing global_asm!)
Rustdoc: remove a bunch of @ts-expect-error from main.js #138318 (Rustdoc: remove a bunch of @ts-expect-error from main.js)
Use RUSTC_LINT_FLAGS more #138331 (Use RUSTC_LINT_FLAGS more)
merge TypeChecker and TypeVerifier #138357 (merge TypeChecker and TypeVerifier)
remove unnecessary variant #138394 (remove unnecessary variant)
Delegation: one more ICE fix for MethodCall generation #138403 (Delegation: one more ICE fix for MethodCall generation)
Delegation: reject C-variadics #138407 (Delegation: reject C-variadics)
Use sa_sigaction instead of sa_union.__su_sigaction for AIX #138409 (Use sa_sigaction instead of sa_union.__su_sigaction for AIX)

r? @ghost
@rustbot modify labels: rollup

This already works for --emit=metadata, but is possible anytime we're not linking. Tests: `rmeta_bin` checks we're not changing --emit=link (already passes) `rmeta_bin-pass` tests the new behavior for --emit=obj (would fail today) and also --emit=metadata which isn't changing

this is technically possible if someone sticks rustdoc in an iframe, i think?

For the `Mode::Rustc` lints as well. Because, unlike `RUSTC_FLAGS`, `RUSTC_LINT_FLAGS` is not ignored for proc macro crates. Fixes rust-lang#138106.

And fix the new errors in the handful of crates that didn't have a `#![warn(unreachable_pub)]`.

It's no longer necessary now that `-Wunreachable_pub` is being passed.

`Map::node_to_string` just calls the free function `hir_id_to_string`. This commit removes the former and changes the latter into a `TyCtxt` method.

To make room for the moving of `Map::attrs` to `TyCtxt::hir_attrs` in the next commit. (It makes sense to rename the query, because it has many fewer uses than the method.)

Continuing the work from rust-lang#137350. Removes the unused methods: `expect_variant`, `expect_field`, `expect_foreign_item`. Every method gains a `hir_` prefix.

…boet Stabilize `std::io::ErrorKind::InvalidFilename` FCP complete: rust-lang#130192 (comment) Tracking issues: rust-lang#86442 & rust-lang#130192 This PR: - Stabilizes `InvalidFilename` without changing its name to `InvalidFileName`. - Fixes the doc comment (rust-lang#130192 (comment)) - Does not separate "the name is too long" case into a separate `ErrorKind`. That case is currently documented to be covered by `InvalidFilename` in the doc. I'm not sure if it would be possible to change this later or if that would be an unacceptable breaking change. - Does not map more raw OS errors to this `ErrorKind` (as suggested in rust-lang#86442 (comment)). This can presumably be addressed later.

Move methods from Map to TyCtxt, part 4. A follow-up to rust-lang#137350. r? ```@Zalathar```

Manishearth · 2025-03-12T17:20:48Z

@bors rollup=never

bors · 2025-03-12T20:32:58Z

⌛ Testing commit c756251 with merge 2357dd4...

…earth Rollup of 12 pull requests Successful merges: - rust-lang#134076 (Stabilize `std::io::ErrorKind::InvalidFilename`) - rust-lang#137504 (Move methods from Map to TyCtxt, part 4.) - rust-lang#138175 (Support rmeta inputs for --crate-type=bin --emit=obj) - rust-lang#138259 (Disentangle `ForwardGenericParamBan` and `ConstParamTy` ribs) - rust-lang#138280 (fix ICE in pretty-printing `global_asm!`) - rust-lang#138318 (Rustdoc: remove a bunch of `@ts-expect-error` from main.js) - rust-lang#138331 (Use `RUSTC_LINT_FLAGS` more) - rust-lang#138357 (merge `TypeChecker` and `TypeVerifier`) - rust-lang#138394 (remove unnecessary variant) - rust-lang#138403 (Delegation: one more ICE fix for `MethodCall` generation) - rust-lang#138407 (Delegation: reject C-variadics) - rust-lang#138409 (Use sa_sigaction instead of sa_union.__su_sigaction for AIX) r? `@ghost` `@rustbot` modify labels: rollup

rust-log-analyzer · 2025-03-12T22:22:55Z

The job i686-msvc-1 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

failures:

---- [assembly] tests\assembly\targets\targets-elf.rs#thumbv8m_base_none_eabi stdout ----

error in revision `thumbv8m_base_none_eabi`: auxiliary build of "D:\\a\\rust\\rust\\tests\\auxiliary\\minicore.rs" failed to compile: 
status: exit code: 1
command: PATH="D:\a\rust\rust\build\i686-pc-windows-msvc\stage2\bin;C:\Program Files (x86)\Windows Kits\10\bin\x64;C:\Program Files (x86)\Windows Kits\10\bin\10.0.26100.0\x64;C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.43.34808\bin\HostX64\x64;C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.43.34808\bin\HostX64\x86;D:\a\rust\rust\build\i686-pc-windows-msvc\stage0-bootstrap-tools\i686-pc-windows-msvc\release\deps;D:\a\rust\rust\build\i686-pc-windows-msvc\stage0\bin;C:\Program Files\Git\mingw64\bin;C:\Program Files\Git\usr\bin;C:\Users\runneradmin\bin;D:\a\rust\rust\ninja;D:\a\rust\rust\sccache;C:\Program Files\MongoDB\Server\5.0\bin;C:\aliyun-cli;C:\vcpkg;C:\Program Files (x86)\NSIS;C:\tools\zstd;C:\Program Files\Mercurial;C:\hostedtoolcache\windows\stack\3.3.1\x64;C:\cabal\bin;C:\ghcup\bin;C:\mingw64\bin;C:\Program Files\dotnet;C:\Program Files\MySQL\MySQL Server 8.0\bin;C:\Program Files\R\R-4.4.2\bin\x64;C:\SeleniumWebDrivers\GeckoDriver;C:\SeleniumWebDrivers\EdgeDriver;C:\SeleniumWebDrivers\ChromeDriver;C:\Program Files (x86)\sbt\bin;C:\Program Files (x86)\GitHub CLI;C:\Program Files\Git\usr\bin;C:\Program Files (x86)\pipx_bin;C:\npm\prefix;C:\hostedtoolcache\windows\go\1.21.13\x64\bin;C:\hostedtoolcache\windows\Python\3.9.13\x64\Scripts;C:\hostedtoolcache\windows\Python\3.9.13\x64;C:\hostedtoolcache\windows\Ruby\3.0.7\x64\bin;C:\Program Files\OpenSSL\bin;C:\tools\kotlinc\bin;C:\hostedtoolcache\windows\Java_Temurin-Hotspot_jdk\8.0.442-6\x64\bin;C:\Program Files\ImageMagick-7.1.1-Q16-HDRI;C:\Program Files\Microsoft SDKs\Azure\CLI2\wbin;C:\ProgramData\kind;C:\ProgramData\Chocolatey\bin;C:\Windows\system32;C:\Windows;C:\Windows\System32\Wbem;C:\Windows\System32\WindowsPowerShell\v1.0;C:\Windows\System32\OpenSSH;C:\Program Files\dotnet;C:\Program Files\PowerShell\7;C:\Program Files\Microsoft\Web Platform Installer;C:\Program Files\TortoiseSVN\bin;C:\Program Files\Microsoft SQL Server\Client SDK\ODBC\170\Tools\Binn;C:\Program Files\Microsoft SQL Server\150\Tools\Binn;C:\Program Files (x86)\Windows Kits\10\Windows Performance Toolkit;C:\Program Files (x86)\WiX Toolset v3.14\bin;C:\Program Files\Microsoft SQL Server\130\DTS\Binn;C:\Program Files\Microsoft SQL Server\140\DTS\Binn;C:\Program Files\Microsoft SQL Server\150\DTS\Binn;C:\Program Files\Microsoft SQL Server\160\DTS\Binn;C:\Strawberry\c\bin;C:\Strawberry\perl\site\bin;C:\Strawberry\perl\bin;C:\ProgramData\chocolatey\lib\pulumi\tools\Pulumi\bin;C:\Program Files\CMake\bin;C:\ProgramData\chocolatey\lib\maven\apache-maven-3.9.9\bin;C:\Program Files\Microsoft Service Fabric\bin\Fabric\Fabric.Code;C:\Program Files\Microsoft SDKs\Service Fabric\Tools\ServiceFabricLocalClusterManager;C:\Program Files\nodejs;C:\Program Files\Git\cmd;C:\Program Files\Git\mingw64\bin;C:\Program Files\Git\usr\bin;C:\Program Files\GitHub CLI;C:\tools\php;C:\Program Files (x86)\sbt\bin;C:\Program Files\Amazon\AWSCLIV2;C:\Program Files\Amazon\SessionManagerPlugin\bin;C:\Program Files\Amazon\AWSSAMCLI\bin;C:\Program Files\Microsoft SQL Server\130\Tools\Binn;C:\Program Files\LLVM\bin;C:\Users\runneradmin\.dotnet\tools;C:\Users\runneradmin\.cargo\bin;C:\Users\runneradmin\AppData\Local\Microsoft\WindowsApps;C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.43.34808\bin\HostX64\x86" "D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\stage2\\bin\\rustc.exe" "D:\\a\\rust\\rust\\tests\\auxiliary\\minicore.rs" "-Zthreads=1" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=C:\\Users\\runneradmin\\.cargo" "-Z" "ignore-directory-in-diagnostics-source-blocks=D:\\a\\rust\\rust\\vendor" "--sysroot" "D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\stage2" "--cfg" "thumbv8m_base_none_eabi" "--check-cfg" "cfg(test,FALSE,aarch64_be_unknown_linux_gnu,aarch64_be_unknown_linux_gnu_ilp32,aarch64_be_unknown_netbsd,aarch64_kmc_solid_asp3,aarch64_linux_android,aarch64_nintendo_switch_freestanding,aarch64_unknown_freebsd,aarch64_unknown_fuchsia,aarch64_unknown_hermit,aarch64_unknown_illumos,aarch64_unknown_linux_gnu,aarch64_unknown_linux_gnu_ilp32,aarch64_unknown_linux_musl,aarch64_unknown_linux_ohos,aarch64_unknown_netbsd,aarch64_unknown_none,aarch64_unknown_none_softfloat,aarch64_unknown_nto_qnx700,aarch64_unknown_nto_qnx710,aarch64_unknown_nto_qnx710_iosock,aarch64_unknown_nto_qnx800,aarch64_unknown_openbsd,aarch64_unknown_redox,aarch64_unknown_teeos,aarch64_unknown_nuttx,aarch64_unknown_trusty,aarch64_wrs_vxworks,arm_linux_androideabi,arm_unknown_linux_gnueabi,arm_unknown_linux_gnueabihf,arm_unknown_linux_musleabi,arm_unknown_linux_musleabihf,armeb_unknown_linux_gnueabi,armebv7r_none_eabi,armebv7r_none_eabihf,armv4t_none_eabi,armv4t_unknown_linux_gnueabi,armv5te_none_eabi,armv5te_unknown_linux_gnueabi,armv5te_unknown_linux_musleabi,armv5te_unknown_linux_uclibceabi,armv6_unknown_freebsd,armv6_unknown_netbsd_eabihf,armv6k_nintendo_3ds,armv7_linux_androideabi,armv7_rtems_eabihf,armv7_sony_vita_newlibeabihf,armv7_unknown_freebsd,armv7_unknown_linux_gnueabi,armv7_unknown_linux_gnueabihf,armv7_unknown_linux_musleabi,armv7_unknown_linux_musleabihf,armv7_unknown_linux_ohos,armv7_unknown_linux_uclibceabi,armv7_unknown_linux_uclibceabihf,armv7_unknown_netbsd_eabihf,armv7_unknown_trusty,armv7_wrs_vxworks_eabihf,armv7a_kmc_solid_asp3_eabi,armv7a_kmc_solid_asp3_eabihf,armv7a_none_eabi,armv7a_none_eabihf,armv7a_nuttx_eabi,armv7a_nuttx_eabihf,armv7r_none_eabi,armv7r_none_eabihf,armv8r_none_eabihf,hexagon_unknown_linux_musl,hexagon_unknown_none_elf,i686_pc_nto_qnx700,i586_unknown_linux_gnu,i586_unknown_linux_musl,i586_unknown_netbsd,i586_unknown_redox,i686_linux_android,i686_unknown_freebsd,i686_unknown_haiku,i686_unknown_hurd_gnu,i686_unknown_linux_gnu,i686_unknown_linux_musl,i686_unknown_netbsd,i686_unknown_openbsd,i686_wrs_vxworks,loongarch64_unknown_linux_gnu,loongarch64_unknown_linux_musl,loongarch64_unknown_linux_ohos,loongarch64_unknown_none,loongarch64_unknown_none_softfloat,m68k_unknown_linux_gnu,m68k_unknown_none_elf,mips64_openwrt_linux_musl,mips64_unknown_linux_gnuabi64,mips64_unknown_linux_muslabi64,mips64el_unknown_linux_gnuabi64,mips64el_unknown_linux_muslabi64,mips_unknown_linux_gnu,mips_unknown_linux_musl,mips_unknown_linux_uclibc,mips_mti_none_elf,mipsel_mti_none_elf,mipsel_sony_psp,mipsel_sony_psx,mipsel_unknown_linux_gnu,mipsel_unknown_linux_musl,mipsel_unknown_linux_uclibc,mipsel_unknown_netbsd,mipsel_unknown_none,mipsisa32r6_unknown_linux_gnu,mipsisa32r6el_unknown_linux_gnu,mipsisa64r6_unknown_linux_gnuabi64,mipsisa64r6el_unknown_linux_gnuabi64,msp430_none_elf,powerpc64_unknown_freebsd,powerpc64_unknown_linux_gnu,powerpc64_unknown_linux_musl,powerpc64_unknown_openbsd,powerpc64_wrs_vxworks,powerpc64le_unknown_freebsd,powerpc64le_unknown_linux_gnu,powerpc64le_unknown_linux_musl,powerpc_unknown_freebsd,powerpc_unknown_linux_gnu,powerpc_unknown_linux_gnuspe,powerpc_unknown_linux_musl,powerpc_unknown_linux_muslspe,powerpc_unknown_netbsd,powerpc_unknown_openbsd,powerpc_wrs_vxworks,powerpc_wrs_vxworks_spe,riscv32_wrs_vxworks,riscv32e_unknown_none_elf,riscv32em_unknown_none_elf,riscv32emc_unknown_none_elf,riscv32gc_unknown_linux_gnu,riscv32gc_unknown_linux_musl,riscv32i_unknown_none_elf,riscv32im_risc0_zkvm_elf,riscv32im_unknown_none_elf,riscv32ima_unknown_none_elf,riscv32imac_esp_espidf,riscv32imac_unknown_none_elf,riscv32imac_unknown_xous_elf,riscv32imafc_unknown_none_elf,riscv32imafc_esp_espidf,riscv32imc_esp_espidf,riscv32imc_unknown_none_elf,riscv64_linux_android,riscv64_wrs_vxworks,riscv64gc_unknown_freebsd,riscv64gc_unknown_fuchsia,riscv64gc_unknown_hermit,riscv64gc_unknown_linux_gnu,riscv64gc_unknown_linux_musl,riscv64gc_unknown_netbsd,riscv64gc_unknown_none_elf,riscv64gc_unknown_openbsd,riscv64imac_unknown_none_elf,s390x_unknown_linux_gnu,s390x_unknown_linux_musl,sparc64_unknown_linux_gnu,sparc64_unknown_netbsd,sparc64_unknown_openbsd,sparc_unknown_linux_gnu,sparc_unknown_none_elf,sparcv9_sun_solaris,thumbv4t_none_eabi,thumbv5te_none_eabi,thumbv6m_none_eabi,thumbv7em_none_eabi,thumbv7em_none_eabihf,thumbv7m_none_eabi,thumbv7neon_linux_androideabi,thumbv7neon_unknown_linux_gnueabihf,thumbv7neon_unknown_linux_musleabihf,thumbv8m_base_none_eabi,thumbv8m_main_none_eabi,thumbv8m_main_none_eabihf,wasm32_unknown_emscripten,wasm32_unknown_unknown,wasm32v1_none,wasm32_wasip1,wasm32_wasip1_threads,wasm32_wasip2,wasm32_wali_linux_musl,wasm64_unknown_unknown,x86_64_fortanix_unknown_sgx,x86_64_linux_android,x86_64_pc_nto_qnx710,x86_64_pc_nto_qnx710_iosock,x86_64_pc_nto_qnx800,x86_64_pc_solaris,x86_64_unikraft_linux_musl,x86_64_unknown_dragonfly,x86_64_unknown_freebsd,x86_64_unknown_fuchsia,x86_64_unknown_haiku,x86_64_unknown_hurd_gnu,x86_64_unknown_hermit,x86_64_unknown_illumos,x86_64_unknown_l4re_uclibc,x86_64_unknown_linux_gnu,x86_64_unknown_linux_gnux32,x86_64_unknown_linux_musl,x86_64_unknown_linux_ohos,x86_64_unknown_linux_none,x86_64_unknown_netbsd,x86_64_unknown_none,x86_64_unknown_openbsd,x86_64_unknown_redox,x86_64_unknown_trusty,x86_64_wrs_vxworks,thumbv6m_nuttx_eabi,thumbv7a_nuttx_eabi,thumbv7a_nuttx_eabihf,thumbv7m_nuttx_eabi,thumbv7em_nuttx_eabi,thumbv7em_nuttx_eabihf,thumbv8m_base_nuttx_eabi,thumbv8m_main_nuttx_eabi,thumbv8m_main_nuttx_eabihf,riscv32imc_unknown_nuttx_elf,riscv32imac_unknown_nuttx_elf,riscv32imafc_unknown_nuttx_elf,riscv64imac_unknown_nuttx_elf,riscv64gc_unknown_nuttx_elf)" "-O" "-Cdebug-assertions=no" "-C" "prefer-dynamic" "-o" "D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\test\\assembly\\targets\\targets-elf.thumbv8m_base_none_eabi\\libminicore.rlib" "-A" "unused" "-A" "internal_features" "-Crpath" "-Cdebuginfo=0" "-Lnative=D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\native\\rust-test-helpers" "--target" "thumbv8m.base-none-eabi" "-Cpanic=abort" "--crate-type" "rlib" "-Cpanic=abort"
stdout: none
--- stderr -------------------------------
error: couldn't create a temp dir: Access is denied. (os error 5) at path "C:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\rustcTgHb4M"

error: aborting due to 1 previous error
------------------------------------------


---
test result: FAILED. 465 passed; 1 failed; 67 ignored; 0 measured; 0 filtered out; finished in 25.60s

Some tests failed in compiletest suite=assembly mode=assembly host=i686-pc-windows-msvc target=i686-pc-windows-msvc
Build completed unsuccessfully in 1:42:38
make: *** [Makefile:113: ci-msvc-py] Error 1
  local time: Wed Mar 12 22:22:40 CUT 2025
  network time: Wed, 12 Mar 2025 22:22:40 GMT
##[error]Process completed with exit code 2.
Post job cleanup.
[command]"C:\Program Files\Git\bin\git.exe" version

bors · 2025-03-12T22:23:33Z

💔 Test failed - checks-actions

Manishearth · 2025-03-12T22:26:26Z

  error: couldn't create a temp dir: Access is denied. (os error 5) at path "C:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\rustcTgHb4M"

Manishearth · 2025-03-12T22:29:22Z

Unclear which PR broke that, perhaps #138280 ?

compiler-errors · 2025-03-12T23:11:30Z

This looks spurious tbh, maybe retry it?

jieyouxu · 2025-03-12T23:12:33Z

This is a classic MSVC spurious failure.
@bors retry

bors · 2025-03-13T01:37:32Z

⌛ Testing commit c756251 with merge 8536f20...

bors · 2025-03-13T04:40:26Z

☀️ Test successful - checks-actions
Approved by: Manishearth
Pushing 8536f20 to master...

github-actions · 2025-03-13T04:42:24Z

Post-merge analysis result

Test differences

x86_64-gnu
- errors::verify_resolve_items_in_traits_are_not_importable_35: [missing] -> pass
- compiler/rustc_mir_build/src/builder/scope.rs - builder::scope::Builder<'a,'tcx>::record_operands_moved (line 1197): [missing] -> ignore
- errors::verify_resolve_imported_crate_23: [missing] -> pass
- compiler/rustc_resolve/src/late.rs - late::LifetimeRibKind::AnonymousCreateParameter (line 310): [missing] -> pass
- errors::verify_resolve_tool_module_imported_20: [missing] -> pass
- errors::verify_resolve_cannot_be_reexported_crate_public_33: [missing] -> pass
- errors::verify_resolve_is_not_directly_importable_36: [missing] -> pass
- errors::verify_resolve_cannot_determine_import_resolution_28: [missing] -> pass
- errors::verify_resolve_imports_cannot_refer_to_26: [missing] -> pass
- errors::verify_resolve_explicit_anonymous_lifetime_report_error_48: [missing] -> pass
- (and 134 additional testss)
aarch64-apple
- errors::verify_resolve_imports_cannot_refer_to_26: [missing] -> pass
- compiler/rustc_resolve/src/lib.rs - PathResult::Failed::module (line 444): [missing] -> pass
- errors::verify_resolve_indeterminate_19: [missing] -> pass
- compiler/rustc_resolve/src/late.rs - late::LateResolutionVisitor<'a,'ast,'ra,'tcx>::compute_and_check_or_pat_binding_map (line 3706): [missing] -> pass
- errors::verify_resolve_arguments_macro_use_not_allowed_43: [missing] -> pass
- errors::verify_resolve_cannot_find_builtin_macro_with_name_58: [missing] -> pass
- compiler/rustc_resolve/src/late.rs - late::LifetimeRibKind::AnonymousCreateParameter (line 310): [missing] -> pass
- compiler/rustc_mir_build/src/builder/scope.rs - builder::scope::Builder<'a,'tcx>::local_scope (line 1027): [missing] -> ignore
- errors::verify_resolve_trait_impl_duplicate_15: [missing] -> pass
- compiler/rustc_middle/src/mir/pretty.rs - mir::pretty::hex_number_length (line 2011): [missing] -> ignore
- (and 134 additional testss)
x86_64-gnu-llvm-19-3
- errors::verify_resolve_attributes_starting_with_rustc_are_reserved_55: [missing] -> pass
- errors::verify_resolve_cannot_determine_import_resolution_28: [missing] -> pass
- compiler/rustc_resolve/src/diagnostics.rs - diagnostics::extend_span_to_previous_binding (line 2645): [missing] -> ignore
- errors::verify_resolve_tool_was_already_registered_59: [missing] -> pass
- errors::verify_resolve_proc_macro_same_crate_22: [missing] -> pass
- compiler/rustc_resolve/src/diagnostics.rs - diagnostics::find_span_of_binding_until_next_binding (line 2592): [missing] -> ignore
- compiler/rustc_mir_build/src/builder/scope.rs - builder::scope::Builder<'a,'tcx>::record_operands_moved (line 1197): [missing] -> ignore
- errors::verify_resolve_trait_impl_duplicate_15: [missing] -> pass
- errors::verify_resolve_param_in_ty_of_const_param_9: [missing] -> pass
- compiler/rustc_resolve/src/lib.rs - PathResult::Failed::module (line 444): [missing] -> pass
- (and 134 additional testss)
x86_64-gnu-llvm-18-3
- errors::verify_resolve_bad_macro_import_38: [missing] -> pass
- errors::verify_resolve_cannot_glob_import_possible_crates_34: [missing] -> pass
- errors::verify_resolve_cannot_determine_import_resolution_28: [missing] -> pass
- errors::verify_resolve_generic_arguments_in_macro_path_54: [missing] -> pass
- errors::verify_resolve_lending_iterator_report_error_46: [missing] -> pass
- errors::verify_resolve_macro_extern_deprecated_42: [missing] -> pass
- compiler/rustc_middle/src/mir/pretty.rs - mir::pretty::hex_number_length (line 2011): [missing] -> ignore
- compiler/rustc_mir_build/src/builder/scope.rs - builder::scope::Builder<'a,'tcx>::record_operands_moved (line 1208): [missing] -> ignore
- errors::verify_resolve_indeterminate_19: [missing] -> pass
- errors::verify_resolve_module_only_21: [missing] -> pass
- (and 134 additional testss)
x86_64-gnu-nopt
- compiler/rustc_resolve/src/late.rs - late::LifetimeRibKind::AnonymousCreateParameter (line 310): [missing] -> pass
- errors::verify_resolve_underscore_lifetime_is_reserved_49: [missing] -> pass
- errors::verify_resolve_binding_in_never_pattern_14: [missing] -> pass
- errors::verify_resolve_attempt_to_define_builtin_macro_twice_51: [missing] -> pass
- errors::verify_resolve_param_in_ty_of_const_param_9: [missing] -> pass
- [ui] tests/ui/const-generics/const-param-type-depends-on-parent-param.rs: [missing] -> pass
- compiler/rustc_mir_build/src/builder/scope.rs - builder::scope::Builder<'a,'tcx>::local_scope (line 1027): [missing] -> ignore
- errors::verify_resolve_cannot_be_reexported_private_32: [missing] -> pass
- errors::verify_resolve_accessible_unsure_25: [missing] -> pass
- errors::verify_resolve_indeterminate_19: [missing] -> pass
- (and 134 additional testss)
aarch64-gnu
- compiler/rustc_resolve/src/late.rs - late::LateResolutionVisitor<'a,'ast,'ra,'tcx>::compute_and_check_binding_map (line 3640): [missing] -> pass
- compiler/rustc_borrowck/src/type_check/mod.rs - type_check::Locations::All (line 315): [missing] -> pass
- errors::verify_resolve_invalid_asm_sym_12: [missing] -> pass
- errors::verify_resolve_imported_crate_23: [missing] -> pass
- errors::verify_resolve_expected_module_found_18: [missing] -> pass
- errors::verify_resolve_cannot_be_reexported_private_32: [missing] -> pass
- errors::verify_resolve_underscore_lifetime_is_reserved_49: [missing] -> pass
- errors::verify_resolve_cannot_use_through_an_import_56: [missing] -> pass
- compiler/rustc_lint/src/nonstandard_style.rs - nonstandard_style::NON_UPPER_CASE_GLOBALS (line 464): [missing] -> pass
- errors::verify_resolve_binding_in_never_pattern_14: [missing] -> pass
- (and 134 additional testss)
x86_64-gnu-stable
- errors::verify_resolve_name_reserved_in_attribute_namespace_57: [missing] -> pass
- compiler/rustc_mir_build/src/builder/scope.rs - builder::scope::Builder<'a,'tcx>::local_scope (line 1020): [missing] -> ignore
- errors::verify_resolve_cannot_find_builtin_macro_with_name_58: [missing] -> pass
- errors::verify_resolve_extern_crate_loading_macro_not_at_crate_root_37: [missing] -> pass
- errors::verify_resolve_indeterminate_19: [missing] -> pass
- errors::verify_resolve_is_private_53: [missing] -> pass
- errors::verify_resolve_lending_iterator_report_error_46: [missing] -> pass
- errors::verify_resolve_trait_impl_duplicate_15: [missing] -> pass
- compiler/rustc_resolve/src/diagnostics.rs - diagnostics::find_span_immediately_after_crate_name (line 2688): [missing] -> ignore
- errors::verify_resolve_cannot_determine_macro_resolution_29: [missing] -> pass
- (and 134 additional testss)
x86_64-apple-1
- compiler/rustc_resolve/src/diagnostics.rs - diagnostics::find_span_of_binding_until_next_binding (line 2599): [missing] -> ignore
- errors::verify_resolve_underscore_lifetime_is_reserved_49: [missing] -> pass
- errors::verify_resolve_trait_impl_mismatch_61: [missing] -> pass
- errors::verify_resolve_cannot_be_reexported_crate_public_33: [missing] -> pass
- compiler/rustc_resolve/src/lib.rs - Used (line 199): [missing] -> pass
- errors::verify_resolve_cannot_use_through_an_import_56: [missing] -> pass
- compiler/rustc_resolve/src/lib.rs - PathResult::Failed::module (line 444): [missing] -> pass
- compiler/rustc_lint/src/nonstandard_style.rs - nonstandard_style::NON_UPPER_CASE_GLOBALS (line 464): [missing] -> pass
- errors::verify_resolve_macro_extern_deprecated_42: [missing] -> pass
- errors::verify_resolve_expected_module_found_18: [missing] -> pass
- (and 129 additional testss)
i686-mingw-2
- compiler/rustc_mir_build/src/builder/scope.rs - builder::scope::Builder<'a,'tcx>::record_operands_moved (line 1197): [missing] -> ignore
- errors::verify_resolve_explicit_anonymous_lifetime_report_error_48: [missing] -> pass
- errors::verify_resolve_module_only_21: [missing] -> pass
- errors::verify_resolve_tool_was_already_registered_59: [missing] -> pass
- compiler/rustc_resolve/src/late.rs - late::LifetimeRibKind::AnonymousCreateParameter (line 310): [missing] -> pass
- errors::verify_resolve_lending_iterator_report_error_46: [missing] -> pass
- errors::verify_resolve_tool_module_imported_20: [missing] -> pass
- errors::verify_resolve_cannot_find_ident_in_this_scope_27: [missing] -> pass
- errors::verify_resolve_macro_use_name_already_in_use_40: [missing] -> pass
- compiler/rustc_mir_build/src/builder/scope.rs - builder::scope::Builder<'a,'tcx>::record_operands_moved (line 1208): [missing] -> ignore
- (and 128 additional testss)
i686-gnu-nopt-2
- errors::verify_resolve_tool_was_already_registered_59: [missing] -> pass
- errors::verify_resolve_variable_is_not_bound_in_all_patterns_52: [missing] -> pass
- errors::verify_resolve_indeterminate_19: [missing] -> pass
- errors::verify_resolve_arguments_macro_use_not_allowed_43: [missing] -> pass
- compiler/rustc_resolve/src/late.rs - late::LifetimeRibKind::AnonymousCreateParameter (line 310): [missing] -> pass
- errors::verify_resolve_trait_impl_duplicate_15: [missing] -> pass
- errors::verify_resolve_anonymous_lifetime_non_gat_report_error_47: [missing] -> pass
- errors::verify_resolve_imported_crate_23: [missing] -> pass
- compiler/rustc_resolve/src/lib.rs - Used (line 199): [missing] -> pass
- errors::verify_resolve_attempt_to_define_builtin_macro_twice_51: [missing] -> pass
- (and 128 additional testss)

(and 19 additional diffs)

rust-timer · 2025-03-13T06:38:26Z

Finished benchmarking commit (8536f20): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.6%	[-0.6%, -0.6%]	1
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results (secondary 8.5%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	8.5%	[6.2%, 10.8%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 777.49s -> 777.662s (0.02%)
Artifact size: 365.33 MiB -> 365.21 MiB (-0.03%)

…earth Rollup of 12 pull requests Successful merges: - rust-lang#134076 (Stabilize `std::io::ErrorKind::InvalidFilename`) - rust-lang#137504 (Move methods from Map to TyCtxt, part 4.) - rust-lang#138175 (Support rmeta inputs for --crate-type=bin --emit=obj) - rust-lang#138259 (Disentangle `ForwardGenericParamBan` and `ConstParamTy` ribs) - rust-lang#138280 (fix ICE in pretty-printing `global_asm!`) - rust-lang#138318 (Rustdoc: remove a bunch of `@ts-expect-error` from main.js) - rust-lang#138331 (Use `RUSTC_LINT_FLAGS` more) - rust-lang#138357 (merge `TypeChecker` and `TypeVerifier`) - rust-lang#138394 (remove unnecessary variant) - rust-lang#138403 (Delegation: one more ICE fix for `MethodCall` generation) - rust-lang#138407 (Delegation: reject C-variadics) - rust-lang#138409 (Use sa_sigaction instead of sa_union.__su_sigaction for AIX) r? `@ghost` `@rustbot` modify labels: rollup

sam-mccall and others added 30 commits March 7, 2025 18:33

fix ICE in pretty-printing global_asm!

9213cb8

main.js: insertAfter needs non-root referenceNode

d75c973

main.js: don't set mouseMovedAfterSearch, as it is never read

93161f5

main.js: give type signatures to a few helper functions

cf7f3cf

main.js: handleEscape and handleShortcut accept KeyboardEvent

da5da99

main.js: always refer to searchState through window.searchState

6622111

main.js(isDisplayed): coerce truthy values to boolean

f5efd2a

main.js: handle document.activeElement being null

ab180c2

this is technically possible if someone sticks rustdoc in an iframe, i think?

rustdoc.d.ts: window.SIDEBAR_ITEMS may exist.

2e1c8f0

rustdoc.d.ts: add window.{register_implementors,pending_implementors}

749b6bf

main.js: typecheck things related to window.register_type_impls

7421546

main.js: remove searchState from globals.

20bac26

Use RUSTC_LINT_FLAGS more.

c9c8387

For the `Mode::Rustc` lints as well. Because, unlike `RUSTC_FLAGS`, `RUSTC_LINT_FLAGS` is not ignored for proc macro crates. Fixes rust-lang#138106.

Add unreachable_pub to RUSTC_LINT_FLAGS for compiler/ crates.

55505ab

And fix the new errors in the handful of crates that didn't have a `#![warn(unreachable_pub)]`.

Remove #![warn(unreachable_pub)] from all compiler/ crates.

ff0a5fe

It's no longer necessary now that `-Wunreachable_pub` is being passed.

Stabilize std::io::ErrorKind::InvalidFilename

7475a34

change TypeChecker to a MIR visitor

2f6aca8

unify last_span computation

50f5f60

merge TypeChecker and TypeVerifier

a5eb387

Adjust Map's to_string functionality.

d2642ab

`Map::node_to_string` just calls the free function `hir_id_to_string`. This commit removes the former and changes the latter into a `TyCtxt` method.

Rename hir_attrs query as hir_attr_map.

281af35

To make room for the moving of `Map::attrs` to `TyCtxt::hir_attrs` in the next commit. (It makes sense to rename the query, because it has many fewer uses than the method.)

Move methods from Map to TyCtxt, part 4.

256c27e

Continuing the work from rust-lang#137350. Removes the unused methods: `expect_variant`, `expect_field`, `expect_foreign_item`. Every method gains a `hir_` prefix.

remove unnecessary variant

adbcb91

Delegation: one more ICE fix for MethodCall generation

7bfe213

Delegation: reject C-variadics

ccdba16

Use sa_sigaction instead of sa_union.__su_sigaction for AIX.

17d1e05

Disentangle ForwardGenericParamBan and ConstParamTy ribs

42773bf

Rollup merge of rust-lang#137504 - nnethercote:remove-Map-4, r=Zalathar

f88f27a

Move methods from Map to TyCtxt, part 4. A follow-up to rust-lang#137350. r? ```@Zalathar```

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 12, 2025

Manishearth mentioned this pull request Mar 12, 2025

fix ICE in pretty-printing global_asm! #138280

Merged

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 12, 2025

jieyouxu added the CI-spurious-fail-msvc CI spurious failure: target env msvc label Mar 12, 2025

bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 13, 2025

bors merged commit 8536f20 into rust-lang:master Mar 13, 2025
7 checks passed

rustbot added this to the 1.87.0 milestone Mar 13, 2025

klensy mentioned this pull request Mar 13, 2025

Add post-merge analysis CI workflow #138013

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rollup of 12 pull requests #138416

Rollup of 12 pull requests #138416

Manishearth commented Mar 12, 2025

Manishearth commented Mar 12, 2025

bors commented Mar 12, 2025

rust-log-analyzer commented Mar 12, 2025

bors commented Mar 12, 2025

Manishearth commented Mar 12, 2025

Manishearth commented Mar 12, 2025

compiler-errors commented Mar 12, 2025

jieyouxu commented Mar 12, 2025

bors commented Mar 13, 2025

bors commented Mar 13, 2025

github-actions bot commented Mar 13, 2025

rust-timer commented Mar 13, 2025

Rollup of 12 pull requests #138416

Rollup of 12 pull requests #138416

Conversation

Manishearth commented Mar 12, 2025

Manishearth commented Mar 12, 2025

bors commented Mar 12, 2025

rust-log-analyzer commented Mar 12, 2025

bors commented Mar 12, 2025

Manishearth commented Mar 12, 2025

Manishearth commented Mar 12, 2025

compiler-errors commented Mar 12, 2025

jieyouxu commented Mar 12, 2025

bors commented Mar 13, 2025

bors commented Mar 13, 2025

github-actions bot commented Mar 13, 2025

Test differences

rust-timer commented Mar 13, 2025

Overall result: ✅ improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size