Bump boostrap cc to 1.2.17 and cmake to 0.1.54
#138784
Draft
+28
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-testsuite
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Please add |
madsmtm
force-pushed
the
bootstrap-bump-cc-cmake
branch
from
85502fc to
673b519
Compare
|
Ah, that's why, I really couldn't understand why it didn't work (and failing in Have added to |
|
@bors try |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 21, 2025
…try> Bump boostrap `cc` to 1.2.17 and `cmake` to 0.1.54 The `cc` version in `bootstrap` was reverted down to 1.1.22 in rust-lang#137460 (previously at 1.2.0). The offending issue has since then been resolved in rust-lang/cc-rs#1413, and a new version of `cc` has been released in rust-lang/cc-rs#1435, so let's try to update the version again. See [the changelog](https://github.com/rust-lang/cc-rs/blob/d9dd20e376368c7535f6ef89b809098f5f203c1a/CHANGELOG.md) for exact details on what has changed here. r? jieyouxu who tried this last in rust-lang#137022. `@rustbot` label T-bootstrap try-job: dist-apple-various
This comment has been minimized.
This comment has been minimized.
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-author
|
@bors delegate+ (for try-jobs only, I haven't looked at the cc diff) |
madsmtm
force-pushed
the
bootstrap-bump-cc-cmake
branch
from
ce6caef to
c93efd1
Compare
To avoid a panic in cmake-rs that was introduced in: rust-lang/cmake-rs#158
|
Okay so the failure comes from all the way back in rust-lang/cmake-rs#158. I've added a workaround in bootstrap, though ideally this should be fixed in @bors try |
madsmtm
force-pushed
the
bootstrap-bump-cc-cmake
branch
from
c93efd1 to
061eda1
Compare
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 22, 2025
Bump boostrap `cc` to 1.2.17 and `cmake` to 0.1.54 The `cc` version in `bootstrap` was reverted down to 1.1.22 in rust-lang#137460 (previously at 1.2.0). The offending issue has since then been resolved in rust-lang/cc-rs#1413, and a new version of `cc` has been released in rust-lang/cc-rs#1435, so let's try to update the version again. See [the changelog](https://github.com/rust-lang/cc-rs/blob/d9dd20e376368c7535f6ef89b809098f5f203c1a/CHANGELOG.md) for exact details on what has changed here. r? jieyouxu who tried this last in rust-lang#137022. `@rustbot` label T-bootstrap try-job: dist-apple-various
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ccversion inbootstrapwas reverted down to 1.1.22 in #137460 (previously at 1.2.0). The offending issue has since then been resolved in rust-lang/cc-rs#1413, and a new version ofcchas been released in rust-lang/cc-rs#1435, so let's try to update the version again.See the changelog for exact details on what has changed here.
r? jieyouxu who tried this last in #137022.
@rustbot label T-bootstrap
try-job: dist-apple-various