[perf experiment] Split the resolver tables into per-owner tables #138995

oli-obk · 2025-03-26T18:23:03Z

just doing some experiments to see if splitting hir_crate is feasible by checking if splitting the resolver's output into per-owner queries is feasible (#95004)

Basically necessary for #138705 as that can't be landed perf-wise while the hir_crate query is still a thing

oli-obk · 2025-03-26T18:23:14Z

@bors try @rust-timer queue

bors · 2025-03-26T18:24:25Z

⌛ Trying commit 33f5615 with merge 792af13...

[perf experiment] Split the resolver tables into per-owner tables r? `@ghost` just doing some experiments to see if splitting `hir_crate` is feasible by checking if splitting the resolver's output into per-owner queries is feasible (rust-lang#95004) Basically necessary for rust-lang#138705 as that can't be landed perf-wise while the `hir_crate` query is still a thing

bors · 2025-03-26T20:30:56Z

☀️ Try build successful - checks-actions
Build commit: 792af13 (792af13061770b940e351039beebe10bd97d4627)

rust-timer · 2025-03-26T21:48:18Z

Finished benchmarking commit (792af13): comparison URL.

Overall result: ❌ regressions - please read the text below

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	0.3%	[0.1%, 0.6%]	129
Regressions ❌ (secondary)	0.5%	[0.1%, 1.5%]	69
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.3%	[0.1%, 0.6%]	129

Max RSS (memory usage)

Results (primary 1.3%, secondary 0.5%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.3%	[0.9%, 1.7%]	5
Regressions ❌ (secondary)	1.8%	[1.0%, 2.8%]	4
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.0%	[-2.4%, -1.6%]	2
All ❌✅ (primary)	1.3%	[0.9%, 1.7%]	5

Cycles

Results (secondary 1.5%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.2%	[1.5%, 2.6%]	9
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.0%	[-2.7%, -1.2%]	2
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 777.548s -> 776.554s (-0.13%)
Artifact size: 365.81 MiB -> 365.80 MiB (-0.01%)

oli-obk · 2025-03-28T12:20:32Z

@bors try @rust-timer queue

bors · 2025-03-28T12:21:45Z

⌛ Trying commit a16a6f1 with merge 66f172c...

[perf experiment] Split the resolver tables into per-owner tables r? `@ghost` just doing some experiments to see if splitting `hir_crate` is feasible by checking if splitting the resolver's output into per-owner queries is feasible (rust-lang#95004) Basically necessary for rust-lang#138705 as that can't be landed perf-wise while the `hir_crate` query is still a thing

bors · 2025-03-28T14:29:54Z

☀️ Try build successful - checks-actions
Build commit: 66f172c (66f172c845b537c43e7e41f92eaf99957253f6bd)

rust-timer · 2025-03-28T16:04:26Z

Finished benchmarking commit (66f172c): comparison URL.

Overall result: ❌ regressions - please read the text below

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	0.3%	[0.1%, 0.8%]	29
Regressions ❌ (secondary)	0.8%	[0.3%, 2.1%]	30
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.2%	[-0.2%, -0.2%]	2
All ❌✅ (primary)	0.3%	[0.1%, 0.8%]	29

Max RSS (memory usage)

Results (primary 1.6%, secondary 2.7%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.6%	[1.0%, 2.1%]	5
Regressions ❌ (secondary)	3.9%	[2.0%, 7.4%]	6
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-1.2%	[-1.3%, -1.1%]	2
All ❌✅ (primary)	1.6%	[1.0%, 2.1%]	5

Cycles

Results (secondary 2.9%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.9%	[2.0%, 3.6%]	8
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 778.99s -> 777.791s (-0.15%)
Artifact size: 365.92 MiB -> 365.97 MiB (0.01%)

oli-obk · 2025-03-28T16:08:05Z

ok... better, but not great yet either

…id_to_def_id`

oli-obk · 2025-03-31T16:06:25Z

@bors try @rust-timer queue

[perf experiment] Split the resolver tables into per-owner tables r? `@ghost` just doing some experiments to see if splitting `hir_crate` is feasible by checking if splitting the resolver's output into per-owner queries is feasible (rust-lang#95004) Basically necessary for rust-lang#138705 as that can't be landed perf-wise while the `hir_crate` query is still a thing

bors · 2025-03-31T16:07:37Z

⌛ Trying commit a78e1a6 with merge 012f3ee...

rust-log-analyzer · 2025-03-31T16:15:52Z

The job mingw-check-tidy failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

info: removing rustup binaries
info: rustup is uninstalled
##[group]Image checksum input
mingw-check-tidy
# We use the ghcr base image because ghcr doesn't have a rate limit
# and the mingw-check-tidy job doesn't cache docker images in CI.
FROM ghcr.io/rust-lang/ubuntu:22.04

ARG DEBIAN_FRONTEND=noninteractive
RUN apt-get update && apt-get install -y --no-install-recommends \
  g++ \
  make \
---

COPY host-x86_64/mingw-check/validate-toolstate.sh /scripts/
COPY host-x86_64/mingw-check/validate-error-codes.sh /scripts/

# NOTE: intentionally uses python2 for x.py so we can test it still works.
# validate-toolstate only runs in our CI, so it's ok for it to only support python3.
ENV SCRIPT TIDY_PRINT_DIFF=1 python2.7 ../x.py test \
           --stage 0 src/tools/tidy tidyselftest --extra-checks=py,cpp
#
# This file is autogenerated by pip-compile with Python 3.10
# by the following command:
#
#    pip-compile --allow-unsafe --generate-hashes reuse-requirements.in
---
#12 2.811 Building wheels for collected packages: reuse
#12 2.812   Building wheel for reuse (pyproject.toml): started
#12 3.022   Building wheel for reuse (pyproject.toml): finished with status 'done'
#12 3.023   Created wheel for reuse: filename=reuse-4.0.3-cp310-cp310-manylinux_2_35_x86_64.whl size=132719 sha256=5bb60f62728aaedff7162745ce743c7f2f55069b3e7f82e6a37d70df455797cc
#12 3.023   Stored in directory: /tmp/pip-ephem-wheel-cache-1m8kuz1m/wheels/3d/8d/0a/e0fc6aba4494b28a967ab5eaf951c121d9c677958714e34532
#12 3.026 Successfully built reuse
#12 3.026 Installing collected packages: boolean-py, binaryornot, tomlkit, reuse, python-debian, markupsafe, license-expression, jinja2, chardet, attrs
#12 3.424 Successfully installed attrs-23.2.0 binaryornot-0.4.4 boolean-py-4.0 chardet-5.2.0 jinja2-3.1.4 license-expression-30.3.0 markupsafe-2.1.5 python-debian-0.1.49 reuse-4.0.3 tomlkit-0.13.0
#12 3.424 WARNING: Running pip as the 'root' user can result in broken permissions and conflicting behaviour with the system package manager. It is recommended to use a virtual environment instead: https://pip.pypa.io/warnings/venv
#12 3.960 Collecting virtualenv
#12 4.015   Downloading virtualenv-20.29.3-py3-none-any.whl (4.3 MB)
#12 4.208      ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 4.3/4.3 MB 22.6 MB/s eta 0:00:00
#12 4.250 Collecting distlib<1,>=0.3.7
#12 4.258   Downloading distlib-0.3.9-py2.py3-none-any.whl (468 kB)
#12 4.271      ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 469.0/469.0 KB 43.7 MB/s eta 0:00:00
#12 4.308 Collecting platformdirs<5,>=3.9.1
#12 4.315   Downloading platformdirs-4.3.7-py3-none-any.whl (18 kB)
#12 4.354 Collecting filelock<4,>=3.12.2
#12 4.361   Downloading filelock-3.18.0-py3-none-any.whl (16 kB)
#12 4.442 Installing collected packages: distlib, platformdirs, filelock, virtualenv
#12 4.621 Successfully installed distlib-0.3.9 filelock-3.18.0 platformdirs-4.3.7 virtualenv-20.29.3
#12 4.621 WARNING: Running pip as the 'root' user can result in broken permissions and conflicting behaviour with the system package manager. It is recommended to use a virtual environment instead: https://pip.pypa.io/warnings/venv
#12 DONE 4.7s

#13 [7/8] COPY host-x86_64/mingw-check/validate-toolstate.sh /scripts/
#13 DONE 0.0s
---
DirectMap4k:      124864 kB
DirectMap2M:     8263680 kB
DirectMap1G:    10485760 kB
##[endgroup]
Executing TIDY_PRINT_DIFF=1 python2.7 ../x.py test            --stage 0 src/tools/tidy tidyselftest --extra-checks=py,cpp
+ TIDY_PRINT_DIFF=1 python2.7 ../x.py test --stage 0 src/tools/tidy tidyselftest --extra-checks=py,cpp
##[group]Building bootstrap
    Finished `dev` profile [unoptimized] target(s) in 0.05s
##[endgroup]
WARN: currently no CI rustc builds have rustc debug assertions enabled. Please either set `rust.debug-assertions` to `false` if you want to use download CI rustc or set `rust.download-rustc` to `false`.
[TIMING] core::build_steps::tool::LibcxxVersionTool { target: x86_64-unknown-linux-gnu } -- 0.214
---
##[endgroup]
[TIMING] core::build_steps::tool::ToolBuild { compiler: Compiler { stage: 0, host: x86_64-unknown-linux-gnu, forced_compiler: false }, target: x86_64-unknown-linux-gnu, tool: "tidy", path: "src/tools/tidy", mode: ToolBootstrap, source_type: InTree, extra_features: [], allow_features: "", cargo_args: [], artifact_kind: Binary } -- 36.783
[TIMING] core::build_steps::tool::Tidy { compiler: Compiler { stage: 0, host: x86_64-unknown-linux-gnu, forced_compiler: false }, target: x86_64-unknown-linux-gnu } -- 0.000
fmt check
Diff in /checkout/compiler/rustc_ast_lowering/src/expr.rs:23:
     InclusiveRangeWithNoEnd, MatchArmWithNoBody, NeverPatternWithBody, NeverPatternWithGuard,
     UnderscoreExprLhsAssign,
 };
-use super::{
-    GenericArgsMode, ImplTraitContext, LoweringContext, ParamMode,
-};
+use super::{GenericArgsMode, ImplTraitContext, LoweringContext, ParamMode};
 use crate::errors::{InvalidLegacyConstGenericArg, UseConstGenericArg, YieldInClosure};
 use crate::{AllowReturnTypeNotation, FnDeclKind, ImplTraitPosition, fluent_generated};
 
fmt: checked 5930 files
Build completed unsuccessfully in 0:01:19
  local time: Mon Mar 31 16:15:42 UTC 2025
  network time: Mon, 31 Mar 2025 16:15:42 GMT

bors · 2025-03-31T18:15:53Z

☀️ Try build successful - checks-actions
Build commit: 012f3ee (012f3eec5acc351e2cb934444de98793bf94c9e7)

oli-obk · 2025-04-01T09:07:03Z

@rust-timer build 012f3ee

rust-timer · 2025-04-01T11:26:39Z

Finished benchmarking commit (012f3ee): comparison URL.

Overall result: ❌ regressions - please read the text below

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	18.4%	[0.2%, 209.2%]	242
Regressions ❌ (secondary)	8.8%	[0.2%, 76.0%]	123
Improvements ✅ (primary)	-0.1%	[-0.1%, -0.1%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	18.3%	[-0.1%, 209.2%]	243

Max RSS (memory usage)

Results (primary 0.2%, secondary -1.3%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.5%	[0.7%, 2.8%]	14
Regressions ❌ (secondary)	4.3%	[3.0%, 6.5%]	9
Improvements ✅ (primary)	-2.2%	[-4.0%, -0.6%]	7
Improvements ✅ (secondary)	-2.6%	[-5.0%, -0.7%]	39
All ❌✅ (primary)	0.2%	[-4.0%, 2.8%]	21

Cycles

Results (primary 27.9%, secondary 21.7%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	27.9%	[0.7%, 325.7%]	198
Regressions ❌ (secondary)	21.7%	[0.9%, 69.1%]	51
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	27.9%	[0.7%, 325.7%]	198

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 773.745s -> 791.892s (2.35%)
Artifact size: 365.95 MiB -> 365.59 MiB (-0.10%)

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 26, 2025

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 26, 2025

This comment has been minimized.

Sign in to view

rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Mar 26, 2025

oli-obk force-pushed the split-resolver branch from 33f5615 to a16a6f1 Compare March 28, 2025 12:17

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 28, 2025

bors mentioned this pull request Mar 28, 2025

Fix TAIT & ATPIT feature gating in the presence of anon consts #139063

Merged

This comment has been minimized.

Sign in to view

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 28, 2025

oli-obk added 6 commits March 31, 2025 11:33

Remove an argument that was always the same

8164529

Remove a needless mutability

4fa154b

Split trait item resolving into its own method

54884f8

Split the resolver tables into per-owner tables, starting with `node_…

a5cb4f9

…id_to_def_id`

Avoid indexing the owners table all the time

0b2f257

Create only one ItemLowerer

41e852e

oli-obk added 8 commits March 31, 2025 11:33

Replace extension trait with wrapper struct

1769fb1

Move legacy_const_generic_args into per-owner tables

319f91a

Move label res map into per-owner tables

d18e606

Move lifetime_elision_allowed to per owner tables

674535d

Move trait_map into per-owner tables

3583880

Split foreign item resolving into its own method

855461b

Move lifetimes_res_map to per-owner tables

5686bbf

Move extra_lifetime_params_map to per-owner tables

a78e1a6

oli-obk force-pushed the split-resolver branch from a16a6f1 to a78e1a6 Compare March 31, 2025 16:06

This comment has been minimized.

Sign in to view

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[perf experiment] Split the resolver tables into per-owner tables #138995

[perf experiment] Split the resolver tables into per-owner tables #138995

oli-obk commented Mar 26, 2025

oli-obk commented Mar 26, 2025

This comment has been minimized.

bors commented Mar 26, 2025

bors commented Mar 26, 2025

This comment has been minimized.

rust-timer commented Mar 26, 2025

oli-obk commented Mar 28, 2025

This comment has been minimized.

bors commented Mar 28, 2025

bors commented Mar 28, 2025

This comment has been minimized.

rust-timer commented Mar 28, 2025

oli-obk commented Mar 28, 2025

oli-obk commented Mar 31, 2025

bors commented Mar 31, 2025

rust-log-analyzer commented Mar 31, 2025

bors commented Mar 31, 2025

oli-obk commented Apr 1, 2025

This comment has been minimized.

rust-timer commented Apr 1, 2025

[perf experiment] Split the resolver tables into per-owner tables #138995

Are you sure you want to change the base?

[perf experiment] Split the resolver tables into per-owner tables #138995

Conversation

oli-obk commented Mar 26, 2025

oli-obk commented Mar 26, 2025

This comment has been minimized.

bors commented Mar 26, 2025

bors commented Mar 26, 2025

This comment has been minimized.

rust-timer commented Mar 26, 2025

Overall result: ❌ regressions - please read the text below

oli-obk commented Mar 28, 2025

This comment has been minimized.

bors commented Mar 28, 2025

bors commented Mar 28, 2025

This comment has been minimized.

rust-timer commented Mar 28, 2025

Overall result: ❌ regressions - please read the text below

oli-obk commented Mar 28, 2025

oli-obk commented Mar 31, 2025

bors commented Mar 31, 2025

rust-log-analyzer commented Mar 31, 2025

bors commented Mar 31, 2025

oli-obk commented Apr 1, 2025

This comment has been minimized.

rust-timer commented Apr 1, 2025

Overall result: ❌ regressions - please read the text below