Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TAIT & ATPIT feature gating in the presence of anon consts #139063

Merged
merged 1 commit into from
Mar 29, 2025

Conversation

fmease
Copy link
Member

@fmease fmease commented Mar 28, 2025

Fixes #139055 (#119924 (comment)).

r? oli-obk or anybody else

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 28, 2025
@fmease fmease changed the title Fix feature TAIT & ATPIT gating in the presence of anon consts Fix TAIT & ATPIT feature gating in the presence of anon consts Mar 28, 2025
Comment on lines -1 to -2
//@ check-pass
#![feature(type_alias_impl_trait)]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoops

@oli-obk
Copy link
Contributor

oli-obk commented Mar 28, 2025

@bors r+ rollup

@fmease fmease force-pushed the fix-tait-atpit-gating branch from ef5be66 to 9b3cc63 Compare March 28, 2025 14:23
@bors
Copy link
Collaborator

bors commented Mar 28, 2025

📌 Commit 9b3cc63 has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 28, 2025
@fmease
Copy link
Member Author

fmease commented Mar 28, 2025

(Fixed commit message >.<)

@bors r=oli-obk

@bors
Copy link
Collaborator

bors commented Mar 28, 2025

💡 This pull request was already approved, no need to approve it again.

@bors
Copy link
Collaborator

bors commented Mar 28, 2025

📌 Commit 9b3cc63 has been approved by oli-obk

It is now in the queue for this repository.

@oli-obk
Copy link
Contributor

oli-obk commented Mar 28, 2025

(Fixed commit message >.<)

just came here because I saw the cross-link from the other PR and was confused 😆

@fmease fmease force-pushed the fix-tait-atpit-gating branch from 9b3cc63 to 7a295d1 Compare March 28, 2025 17:15
@fmease
Copy link
Member Author

fmease commented Mar 28, 2025

Smol tweak. Can't help myself @bors r=oli-obk

@bors
Copy link
Collaborator

bors commented Mar 28, 2025

📌 Commit 7a295d1 has been approved by oli-obk

It is now in the queue for this repository.

bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 28, 2025
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#138976 (Explain one-past-the-end pointer in std library)
 - rust-lang#139052 (Put pin!() tests in the right file.)
 - rust-lang#139058 (Fix formatting nit in process.rs)
 - rust-lang#139063 (Fix TAIT & ATPIT feature gating in the presence of anon consts)
 - rust-lang#139065 (Miri subtree update)
 - rust-lang#139069 (`io::Take`: avoid new `BorrowedBuf` creation in some case)
 - rust-lang#139075 (Do not treat lifetimes from parent items as influencing child items)
 - rust-lang#139079 (tracking autodiff files via triagebot.toml)

Failed merges:

 - rust-lang#139044 (bootstrap: Avoid cloning `change-id` list)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 52aed95 into rust-lang:master Mar 29, 2025
6 checks passed
@rustbot rustbot added this to the 1.87.0 milestone Mar 29, 2025
@fmease fmease deleted the fix-tait-atpit-gating branch March 29, 2025 00:03
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Mar 29, 2025
Rollup merge of rust-lang#139063 - fmease:fix-tait-atpit-gating, r=oli-obk

Fix TAIT & ATPIT feature gating in the presence of anon consts

Fixes rust-lang#139055 (rust-lang#119924 (comment)).

r? oli-obk or anybody else
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can not use argument impl Trait in type alias
4 participants