Rollup of 8 pull requests #139085
Merged
Rollup of 8 pull requests #139085
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Automatic Rustup
Resolve more FIXMEs
Update ui test
before_terminator: add some minor clarifying comments
Automatic Rustup
Add an anchor to directly link to the -Zmiri-tree-borrows docs
It was added to all preludes in Rust 1.80.
Use `size_of` from the prelude instead of imported
Automatic Rustup
Fix tier 2 sysroots job
Update documentation about nextest
Automatic Rustup
Show interpreter backtrace error on Ctrl+C
Signed-off-by: xizheyin <xizheyin@smail.nju.edu.cn>
Explain one-past-the-end pointer in std library Closing rust-lang#138969 r? libs
Put pin!() tests in the right file. In rust-lang#138717, these tests were put in `tests/pin.rs`, but they should go in `tests/pin_macro.rs`. r? `@jdonszelmann`
Fix formatting nit in process.rs Minor formatting issue in `process.rs`.
…i-obk Fix TAIT & ATPIT feature gating in the presence of anon consts Fixes rust-lang#139055 (rust-lang#119924 (comment)). r? oli-obk or anybody else
Miri subtree update r? `@ghost`
`io::Take`: avoid new `BorrowedBuf` creation in some case If `self.limit == buf.capacity()`, doing the whole `BorrowedBuf` dance is not necessary.
…compiler-errors
Do not treat lifetimes from parent items as influencing child items
```rust
struct A;
impl Bar<'static> for A {
const STATIC: &str = "";
// ^ no future incompat warning
}
```
has no future incompat warning, because there is no ambiguity. But
```rust
struct C;
impl Bar<'_> for C {
// ^^ this lifeimte
const STATIC: &'static str = {
struct B;
impl Bar<'static> for B {
const STATIC: &str = "";
// causes ^ to emit a future incompat warning
}
""
};
}
```
had one before this PR, because the impl for `B` (which is just a copy of `A`) thought it was influenced by a lifetime on the impl for `C`.
I double checked all other `lifetime_ribs` iterations and all of them do check for `Item` boundaries. This feels very fragile tho, and ~~I think we should do not even be able to see ribs from parent items, but that's a different refactoring that I'd rather not do at the same time as a bugfix~~. EDIT: ah nevermind, this is needed for improving diagnostics like "use of undeclared lifetime" being "can't use generic parameters from outer item" instead.
r? `@compiler-errors`
…atrieb tracking autodiff files via triagebot.toml r? `@oli-obk` Tracking: - rust-lang#124509
rustbot
added
A-meta
|
@bors r+ rollup=never p=5 |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 19f42cb (parent) -> 920d95e (this PR) Test differencesShow 90 test diffsStage 0
Stage 1
Stage 2
Additionally, 84 doctest diffs were found. These are ignored, as they are noisy. Job group index
Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
|
📌 Perf builds for each rolled up PR:
previous master: 19f42cb9bb In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
|
Finished benchmarking commit (920d95e): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (primary -2.3%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResults (secondary -3.0%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeResults (primary 0.0%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Bootstrap: 778.47s -> 777.624s (-0.11%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
io::Take: avoid newBorrowedBufcreation in some case #139069 (io::Take: avoid newBorrowedBufcreation in some case)Failed merges:
change-idlist #139044 (bootstrap: Avoid cloningchange-idlist)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup