rustdoc: Fix search links to enums/typedefs #14101
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the values in html::item_type were updated, the JS definitions were accidentally not updated as well. Closes rust-lang#14095
| "fn", | ||
| "typedef", | ||
| "type", |
There was a problem hiding this comment.
I don't actually know what this JS is for, but should it really have two entries called "type"?
There was a problem hiding this comment.
Ok I looked at it and I think the answer is "yes". The index here matches a discriminant, so you're mapping both Enum and Typedef to the same name "type".
There was a problem hiding this comment.
Unfortunately, the Def enum in the ast uses DefTy for both enums and typedefs. Instead of refactoring the whole compiler, I figured I'd just use the same pattern (for better or for worse).
We're guaranteed that they'll never clash because they're in the same namespace (resolve checks that)
bors
added a commit
that referenced
this pull request
May 11, 2014
When the values in html::item_type were updated, the JS definitions were accidentally not updated as well. Closes #14095
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the values in html::item_type were updated, the JS definitions were
accidentally not updated as well.
Closes #14095