Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustdoc: Fix search links to enums/typedefs #14101

Closed
wants to merge 1 commit into from
Closed

rustdoc: Fix search links to enums/typedefs #14101

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/librustdoc/html/static/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -514,9 +514,9 @@
// `rustdoc::html::item_type::ItemType` type in Rust.
var itemTypes = ["mod",
"struct",
"enum",
"type",
"fn",
"typedef",
"type",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't actually know what this JS is for, but should it really have two entries called "type"?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I looked at it and I think the answer is "yes". The index here matches a discriminant, so you're mapping both Enum and Typedef to the same name "type".

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, the Def enum in the ast uses DefTy for both enums and typedefs. Instead of refactoring the whole compiler, I figured I'd just use the same pattern (for better or for worse).

We're guaranteed that they'll never clash because they're in the same namespace (resolve checks that)

"static",
"trait",
"impl",
Expand Down