Pretty printer improvements #14106
Pretty printer improvements #14106
Commits on May 13, 2014
-
rustc: Make std_inject valid for pretty-printer
Inject `extern crate {std, native}` before `use` statements. Add `#![feature(glob)]` since `use std::prelude::*` is used. (Unfortunately `rustc --pretty expanded` does not converge, since `extern crate` and `use std::prelude::*` is injected at every iteration.) -
pprust: Add parentheses to some Expr
Some `Expr` needs parentheses when printed. For example, without parentheses, `ExprUnary(UnNeg, ExprBinary(BiAdd, ..))` becomes `-lhs + rhs` which is wrong. Those cases don't appear in ordinary code (since parentheses are explicitly added) but they can appear in manually crafted ast by extensions.
-
-
-
-
-
test: Add missing
#![feature(managed_boxes)]The tests use managed boxes, but are not perfectly feature-gated because they use `@` inside macros. (It causes issue after `--pretty expanded`.)
-
-
compiletest: Test
--pretty expandedAfter testing `--pretty normal`, it tries to run `--pretty expanded` and typecheck output. Here we don't check convergence since it really diverges: for every iteration, some extra lines (e.g.`extern crate std`) are inserted. Some tests are `ignore-pretty`-ed since they cause various issues with `--pretty expanded`.
-
Touch up and rebase previous commits
* Added `// no-pretty-expanded` to pretty-print a test, but not run it through the `expanded` variant. * Removed #[deriving] and other expanded attributes after they are expanded * Removed hacks around &str and &&str and friends (from both the parser and the pretty printer). * Un-ignored a bunch of tests
-
syntax: Fix printing INT64_MIN
Integers are always parsed as a u64 in libsyntax, but they're stored as i64. The parser and pretty printer both printed an i64 instead of u64, sometimes introducing an extra negative sign.
-
syntax: Fix parsing << with closure types
This uses the trick of replacing the << token with a < token to parse closure types correctly. Closes rust-lang#13324
-
test: Fix a pretty printing test
The pretty printer handles inlines comments quite badly
-
test: Ignore a pretty expanded failing test
When expanding, an extra unsafe block is generated which is currently not handled well.
-
syntax: Print suffixed token literals correctly
Previously, literals "1i" were printed as "1". This fixes the numeric-method-autoexport test for pretty printing.
-
-
syntax: Preserve attributes in #[deriving]
Now that the #[deriving] attribute is removed, the raw_pointers_deriving lint was broken. This commit restores the lint by preserving lint attributes across #[deriving] to the implementations and using #[automatically_derived] as the trigger for activating the lint.
-
syntax: Improve --pretty normal slightly
When printing doc comments, always put a newline after them in a macro invocation to ensure that a line-doc-comment doesn't consume remaining tokens on the line.
