Skip to content

tests/ui: A New Order [8/N] #142200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 26, 2025
Merged

tests/ui: A New Order [8/N] #142200

merged 1 commit into from
Jun 26, 2025

Conversation

Kivooeo
Copy link
Member

@Kivooeo Kivooeo commented Jun 8, 2025 •
edited by jieyouxu
Loading

Some tests/ui/ housekeeping, to trim down number of tests directly under tests/ui/. Part of #133895.

@rustbot
Copy link
Collaborator

rustbot commented Jun 8, 2025

r? @davidtwco

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 8, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Kivooeo Kivooeo mentioned this pull request Jun 11, 2025
Merged
@jieyouxu
Copy link
Member

r? jieyouxu

@rustbot rustbot assigned jieyouxu and unassigned davidtwco Jun 11, 2025
jieyouxu
jieyouxu requested changes Jun 23, 2025
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this and sorry for the delay. I have some feedback.

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 23, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jun 23, 2025

⚠️ Warning ⚠️

@Kivooeo
Copy link
Member Author

Kivooeo commented Jun 23, 2025

@jieyouxu should i care about this warning above if there is no conflicts and im not touching anything compiler related?

@jieyouxu
Copy link
Member

Nah, it's just advisory

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Kivooeo
Copy link
Member Author

Kivooeo commented Jun 23, 2025

wow, really? but how it works without explicit type

@Kivooeo
Copy link
Member Author

Kivooeo commented Jun 23, 2025

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 23, 2025
jieyouxu
jieyouxu approved these changes Jun 25, 2025
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@jieyouxu
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jun 25, 2025

📌 Commit 7936070 has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 25, 2025
SciMind2460 added a commit to SciMind2460/rust that referenced this pull request Jun 25, 2025
@SciMind2460
Rollup merge of rust-lang#142200 - Kivooeo:tf8, r=jieyouxu
837c35c 
`tests/ui`: A New Order [8/N]

Some `tests/ui/` housekeeping, to trim down number of tests directly under `tests/ui/`. Part of rust-lang#133895.
@SciMind2460 SciMind2460 mentioned this pull request Jun 25, 2025
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jun 25, 2025
@matthiaskrgr
Rollup merge of rust-lang#142200 - Kivooeo:tf8, r=jieyouxu
e43dc11 
`tests/ui`: A New Order [8/N]

Some `tests/ui/` housekeeping, to trim down number of tests directly under `tests/ui/`. Part of rust-lang#133895.
@matthiaskrgr matthiaskrgr mentioned this pull request Jun 25, 2025
Closed
@jdonszelmann jdonszelmann mentioned this pull request Jun 25, 2025
Merged
bors added a commit that referenced this pull request Jun 25, 2025
@bors
Auto merge of #143026 - jdonszelmann:rollup-z7mkuyt, r=jdonszelmann
bc4376f 
Rollup of 7 pull requests

Successful merges:

 - #142146 (Withdraw the claim `extern "C-cmse-nonsecure-*"` always matches `extern "C"`)
 - #142200 (`tests/ui`: A New Order [8/N])
 - #142724 (Add runtime check to avoid overwrite arg in `Diag`)
 - #142809 (Add PrintTAFn flag for targeted type analysis printing)
 - #142976 (Check CoerceUnsized impl validity before coercing)
 - #142992 (Convert some ABI tests to use `extern "rust-invalid"`)
 - #143000 (Make `Sub`, `Mul`, `Div` and `Rem`  `const_traits`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 131a2e4 into rust-lang:master Jun 26, 2025
10 checks passed
@rustbot rustbot added this to the 1.90.0 milestone Jun 26, 2025
rust-timer added a commit that referenced this pull request Jun 26, 2025
@rust-timer
Unrolled build for #142200
237096c 
Rollup merge of #142200 - Kivooeo:tf8, r=jieyouxu

`tests/ui`: A New Order [8/N]

Some `tests/ui/` housekeeping, to trim down number of tests directly under `tests/ui/`. Part of #133895.
github-actions bot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request Jun 26, 2025
@bors
Auto merge of #143026 - jdonszelmann:rollup-z7mkuyt, r=jdonszelmann
c6ba365 
Rollup of 7 pull requests

Successful merges:

 - rust-lang/rust#142146 (Withdraw the claim `extern "C-cmse-nonsecure-*"` always matches `extern "C"`)
 - rust-lang/rust#142200 (`tests/ui`: A New Order [8/N])
 - rust-lang/rust#142724 (Add runtime check to avoid overwrite arg in `Diag`)
 - rust-lang/rust#142809 (Add PrintTAFn flag for targeted type analysis printing)
 - rust-lang/rust#142976 (Check CoerceUnsized impl validity before coercing)
 - rust-lang/rust#142992 (Convert some ABI tests to use `extern "rust-invalid"`)
 - rust-lang/rust#143000 (Make `Sub`, `Mul`, `Div` and `Rem`  `const_traits`)

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Enselic Enselic Enselic left review comments

@jieyouxu jieyouxu jieyouxu approved these changes

Assignees

@jieyouxu jieyouxu

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.90.0
Development

Successfully merging this pull request may close these issues.
7 participants
@Kivooeo @rustbot @rust-log-analyzer @jieyouxu @bors @Enselic @davidtwco