Skip to content

tests/ui: A New Order [11/N] #142219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

tests/ui: A New Order [11/N] #142219

wants to merge 1 commit into from

Conversation

Kivooeo
Copy link
Contributor

@Kivooeo Kivooeo commented Jun 8, 2025 •
edited by jieyouxu
Loading

Some tests/ui/ housekeeping, to trim down number of tests directly under tests/ui/. Part of #133895.

r? @jieyouxu

@rustbot
Copy link
Collaborator

rustbot commented Jun 8, 2025

jieyouxu is not on the review rotation at the moment.
They may take a while to respond.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 8, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Kivooeo Kivooeo force-pushed the tf11 branch 2 times, most recently from 11f2e20 to cd77403 Compare June 8, 2025 23:09
@jieyouxu
Copy link
Member

Looking at compiletest atm.
r? compiler

@rustbot rustbot assigned wesleywiser and unassigned jieyouxu Jun 10, 2025
@wesleywiser
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jun 11, 2025

📌 Commit cd77403 has been approved by wesleywiser

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 11, 2025
@Kivooeo
Copy link
Contributor Author

Kivooeo commented Jun 11, 2025

@wesleywiser could i also ask you to review this two, when you will have free time for it

#142200

#142214

it feels like davidtwco is busy irl (based on his last activity) or working on something different and will have no time to check this out

@jieyouxu
Copy link
Member

Can you please squash the commits?
@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 11, 2025
@Kivooeo
Copy link
Contributor Author

Kivooeo commented Jun 11, 2025

sure, give me a second

@jieyouxu
Copy link
Member

I'll look at the other two PRs

@Kivooeo
Copy link
Contributor Author

Kivooeo commented Jun 11, 2025

ready

@jieyouxu
Copy link
Member

Thanks
@bors r=wesleywiser

@bors
Copy link
Collaborator

bors commented Jun 11, 2025

📌 Commit c6c55cc has been approved by wesleywiser

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wesleywiser wesleywiser wesleywiser approved these changes

Assignees

@wesleywiser wesleywiser

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Kivooeo @rustbot @rust-log-analyzer @jieyouxu @wesleywiser @bors