Skip to content

Move error code explanation removal check into tidy #142827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

GuillaumeGomez
Copy link
Member

Follow-up of #142677.

This PR replaces a shell script with rust code.

r? ghost

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc A-tidy Area: The tidy tool S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Jun 21, 2025
@rust-log-analyzer

This comment has been minimized.

@GuillaumeGomez GuillaumeGomez force-pushed the tidy-error-code-removal branch from 52951ee to cd10ec8 Compare June 21, 2025 14:33
@GuillaumeGomez
Copy link
Member Author

Working, perfect. :)

r? @Kobzol

@Kobzol
Copy link
Contributor

Kobzol commented Jun 23, 2025

Thanks! tidy is slowly becoming a dumpster of all random CI checks, I wonder if these should just be in bootstrap. Anyway, great to see another bash script getting removed.

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jun 23, 2025

📌 Commit cd10ec8 has been approved by Kobzol

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 23, 2025
@bors
Copy link
Collaborator

bors commented Jun 23, 2025

☔ The latest upstream changes (presumably #142901) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 23, 2025
@jieyouxu
Copy link
Member

jieyouxu commented Jun 23, 2025

Thanks! tidy is slowly becoming a dumpster of all random CI checks, I wonder if these should just be in bootstrap. Anyway, great to see another bash script getting removed.

I think it's more healthy to split something out from tidy, like ci-checks or sth, because we probably want to make sure ./x test tidy remains fairly fast primary locally).

(Of course, way beyond the scope of this PR)

@GuillaumeGomez GuillaumeGomez force-pushed the tidy-error-code-removal branch from cd10ec8 to 02f73ba Compare June 23, 2025 11:12
@rustbot
Copy link
Collaborator

rustbot commented Jun 23, 2025

Some changes occurred in src/tools/cargo

cc @ehuss

There are changes to the tidy tool.

cc @jieyouxu

@rustbot

This comment has been minimized.

@GuillaumeGomez
Copy link
Member Author

Arf, failed the rebase. Fixing it.

@GuillaumeGomez GuillaumeGomez force-pushed the tidy-error-code-removal branch from 02f73ba to 4780f21 Compare June 23, 2025 11:16
@Kobzol
Copy link
Contributor

Kobzol commented Jun 23, 2025

tidy is green, so:

@bors r+

@bors
Copy link
Collaborator

bors commented Jun 23, 2025

📌 Commit 4780f21 has been approved by Kobzol

It is now in the queue for this repository.

@bors bors removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jun 23, 2025
@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jun 23, 2025
bors added a commit that referenced this pull request Jun 23, 2025
Rollup of 5 pull requests

Successful merges:

 - #142493 (rework `#[naked]` attribute parser)
 - #142636 (bootstrap.example.toml: use less contextual format)
 - #142822 (Make `PartialEq` a `const_trait`)
 - #142892 (Fix ICE on debug builds where lints are delayed on the crate root)
 - #142904 (notify me when rdg is touched)

Failed merges:

 - #142827 (Move error code explanation removal check into tidy)

r? `@ghost`
`@rustbot` modify labels: rollup
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Jun 23, 2025
…oval, r=Kobzol

Move error code explanation removal check into tidy

Follow-up of rust-lang#142677.

This PR replaces a shell script with rust code.

r? ghost
bors added a commit that referenced this pull request Jun 24, 2025
Rollup of 9 pull requests

Successful merges:

 - #140985 (Change `core::iter::Fuse`'s `Default` impl to do what its docs say it does)
 - #141324 (std: sys: random: uefi: Provide rdrand based fallback)
 - #142134 (Reject unsupported `extern "{abi}"`s consistently in all positions)
 - #142784 (Add codegen timing section)
 - #142827 (Move error code explanation removal check into tidy)
 - #142873 (Don't suggest changing a  method inside a expansion)
 - #142908 (Fix install-template.sh for Solaris tr)
 - #142922 (Fix comment on NoMangle)
 - #142923 (fix `-Zmin-function-alignment` on functions without attributes)

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc A-tidy Area: The tidy tool S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants