Skip to content

Conversation

Urgau
Copy link
Member

@Urgau Urgau commented Jun 22, 2025

Fixes #139830
r? compiler

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 22, 2025
@rust-log-analyzer

This comment has been minimized.

@BoxyUwU
Copy link
Member

BoxyUwU commented Jun 23, 2025

@bors r+

@bors
Copy link
Collaborator

bors commented Jun 23, 2025

📌 Commit 188023a has been approved by BoxyUwU

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 23, 2025
bors added a commit that referenced this pull request Jun 24, 2025
Rollup of 9 pull requests

Successful merges:

 - #140985 (Change `core::iter::Fuse`'s `Default` impl to do what its docs say it does)
 - #141324 (std: sys: random: uefi: Provide rdrand based fallback)
 - #142134 (Reject unsupported `extern "{abi}"`s consistently in all positions)
 - #142784 (Add codegen timing section)
 - #142827 (Move error code explanation removal check into tidy)
 - #142873 (Don't suggest changing a  method inside a expansion)
 - #142908 (Fix install-template.sh for Solaris tr)
 - #142922 (Fix comment on NoMangle)
 - #142923 (fix `-Zmin-function-alignment` on functions without attributes)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 8ba8f1e into rust-lang:master Jun 24, 2025
10 checks passed
@rustbot rustbot added this to the 1.90.0 milestone Jun 24, 2025
rust-timer added a commit that referenced this pull request Jun 24, 2025
Rollup merge of #142873 - Urgau:issue-139830, r=BoxyUwU

Don't suggest changing a  method inside a expansion

Fixes #139830
r? compiler
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing use std::fmt::Write; with write!: rustc suggests editing the sysroot
6 participants