Skip to content

Add uX::strict_sub_signed #143282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 20, 2025
Merged

Add uX::strict_sub_signed #143282

merged 2 commits into from
Jul 20, 2025

Conversation

nxsaken
Copy link
Contributor

@nxsaken nxsaken commented Jul 1, 2025 •
edited by rustbot
Loading

#116090 missed strict_sub_signed, adding it here.
Part of #118260.

r? @m-ou-se

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jul 1, 2025
zachs18
zachs18 reviewed Jul 1, 2025
View reviewed changes
@nxsaken @zachs18
Test upper overflow in strict_sub_signed
79ed7c1 
Co-authored-by: zachs18 <8355914+zachs18@users.noreply.github.com>
@nxsaken
Copy link
Contributor Author

nxsaken commented Jul 19, 2025

r? libs

@rustbot rustbot assigned jhpratt and unassigned m-ou-se Jul 19, 2025
@jhpratt
Copy link
Member

jhpratt commented Jul 20, 2025

Seems reasonable to me.

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jul 20, 2025

📌 Commit 79ed7c1 has been approved by jhpratt

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 20, 2025
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jul 20, 2025
@GuillaumeGomez
Rollup merge of rust-lang#143282 - nxsaken:strict_sub_signed, r=jhpratt
9d530b9 
Add `uX::strict_sub_signed`

rust-lang#116090 missed `strict_sub_signed`, adding it here.
Part of rust-lang#118260.

r? `@m-ou-se`
This was referenced Jul 20, 2025
Closed
Merged
bors added a commit that referenced this pull request Jul 20, 2025
@bors
Auto merge of #144219 - GuillaumeGomez:rollup-ha29sql, r=GuillaumeGomez
0864097 
Rollup of 9 pull requests

Successful merges:

 - #143282 (Add `uX::strict_sub_signed`)
 - #143423 (address clippy formatting nits)
 - #143720 (Allow `Rvalue::Repeat` to return true in `rvalue_creates_operand` too)
 - #144011 (bootstrap: Don't trigger an unnecessary LLVM build from check builds)
 - #144112 (bootstrap: Ignore `rust.debuginfo-level-tests` for codegen tests)
 - #144125 (Add new `ignore-backends` and `needs-backends` tests annotations)
 - #144143 (Fix `-Ctarget-feature`s getting ignored after `crt-static`)
 - #144150 (tests: assembly: cstring-merging: Disable GlobalMerge pass)
 - #144190 (Give a message with a span on MIR validation error)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 0162cc5 into rust-lang:master Jul 20, 2025
10 checks passed
@rustbot rustbot added this to the 1.90.0 milestone Jul 20, 2025
rust-timer added a commit that referenced this pull request Jul 20, 2025
@rust-timer
Unrolled build for #143282
8de864e 
Rollup merge of #143282 - nxsaken:strict_sub_signed, r=jhpratt

Add `uX::strict_sub_signed`

#116090 missed `strict_sub_signed`, adding it here.
Part of #118260.

r? ``@m-ou-se``
github-actions bot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request Jul 21, 2025
@bors
Auto merge of #144219 - GuillaumeGomez:rollup-ha29sql, r=GuillaumeGomez
9dda25f 
Rollup of 9 pull requests

Successful merges:

 - rust-lang/rust#143282 (Add `uX::strict_sub_signed`)
 - rust-lang/rust#143423 (address clippy formatting nits)
 - rust-lang/rust#143720 (Allow `Rvalue::Repeat` to return true in `rvalue_creates_operand` too)
 - rust-lang/rust#144011 (bootstrap: Don't trigger an unnecessary LLVM build from check builds)
 - rust-lang/rust#144112 (bootstrap: Ignore `rust.debuginfo-level-tests` for codegen tests)
 - rust-lang/rust#144125 (Add new `ignore-backends` and `needs-backends` tests annotations)
 - rust-lang/rust#144143 (Fix `-Ctarget-feature`s getting ignored after `crt-static`)
 - rust-lang/rust#144150 (tests: assembly: cstring-merging: Disable GlobalMerge pass)
 - rust-lang/rust#144190 (Give a message with a span on MIR validation error)

r? `@ghost`
`@rustbot` modify labels: rollup
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Jul 21, 2025
@bors
Auto merge of #144219 - GuillaumeGomez:rollup-ha29sql, r=GuillaumeGomez
f288c40 
Rollup of 9 pull requests

Successful merges:

 - rust-lang/rust#143282 (Add `uX::strict_sub_signed`)
 - rust-lang/rust#143423 (address clippy formatting nits)
 - rust-lang/rust#143720 (Allow `Rvalue::Repeat` to return true in `rvalue_creates_operand` too)
 - rust-lang/rust#144011 (bootstrap: Don't trigger an unnecessary LLVM build from check builds)
 - rust-lang/rust#144112 (bootstrap: Ignore `rust.debuginfo-level-tests` for codegen tests)
 - rust-lang/rust#144125 (Add new `ignore-backends` and `needs-backends` tests annotations)
 - rust-lang/rust#144143 (Fix `-Ctarget-feature`s getting ignored after `crt-static`)
 - rust-lang/rust#144150 (tests: assembly: cstring-merging: Disable GlobalMerge pass)
 - rust-lang/rust#144190 (Give a message with a span on MIR validation error)

r? `@ghost`
`@rustbot` modify labels: rollup
Muscraft pushed a commit to Muscraft/rust that referenced this pull request Jul 21, 2025
@GuillaumeGomez @Muscraft
Rollup merge of rust-lang#143282 - nxsaken:strict_sub_signed, r=jhpratt
4a8b448 
Add `uX::strict_sub_signed`

rust-lang#116090 missed `strict_sub_signed`, adding it here.
Part of rust-lang#118260.

r? ``@m-ou-se``
Muscraft pushed a commit to Muscraft/rust that referenced this pull request Jul 21, 2025
@bors @Muscraft
Auto merge of rust-lang#144219 - GuillaumeGomez:rollup-ha29sql, r=Gui…
eba8e10 
…llaumeGomez

Rollup of 9 pull requests

Successful merges:

 - rust-lang#143282 (Add `uX::strict_sub_signed`)
 - rust-lang#143423 (address clippy formatting nits)
 - rust-lang#143720 (Allow `Rvalue::Repeat` to return true in `rvalue_creates_operand` too)
 - rust-lang#144011 (bootstrap: Don't trigger an unnecessary LLVM build from check builds)
 - rust-lang#144112 (bootstrap: Ignore `rust.debuginfo-level-tests` for codegen tests)
 - rust-lang#144125 (Add new `ignore-backends` and `needs-backends` tests annotations)
 - rust-lang#144143 (Fix `-Ctarget-feature`s getting ignored after `crt-static`)
 - rust-lang#144150 (tests: assembly: cstring-merging: Disable GlobalMerge pass)
 - rust-lang#144190 (Give a message with a span on MIR validation error)

r? `@ghost`
`@rustbot` modify labels: rollup
github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request Jul 29, 2025
@GuillaumeGomez
Rollup merge of rust-lang#143282 - nxsaken:strict_sub_signed, r=jhpratt
4070d59 
Add `uX::strict_sub_signed`

rust-lang#116090 missed `strict_sub_signed`, adding it here.
Part of rust-lang#118260.

r? ``@m-ou-se``
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachs18 zachs18 zachs18 left review comments

Assignees

@jhpratt jhpratt

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.90.0
Development

Successfully merging this pull request may close these issues.
6 participants
@nxsaken @jhpratt @bors @zachs18 @m-ou-se @rustbot