Give a message with a span on MIR validation error #144190

scottmcm · 2025-07-19T20:47:16Z

It was handy to get a source+line link for #143833, even if it's just to the function and not necessarily to the statement.

r? mir

rustbot · 2025-07-19T20:47:22Z

The Miri subtree was changed

cc @rust-lang/miri

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

RalfJung · 2025-07-19T20:53:25Z

src/tools/miri/tests/panic/mir-validation.stderr

@@ -1,11 +1,20 @@
+error: internal compiler error: compiler/rustc_mir_transform/src/validate.rs:LL:CC: broken MIR in Item(DefId) (after phase change to runtime-optimized) at bb0[1]:
+                                place (*(_2.0: *mut i32)) has deref as a later projection (it is only permitted as the first projection)


Odd that there are so many leading spaces now... 🤷

I think that's because a \n in a bug message gets padded out to align vertically.

RalfJung · 2025-07-19T20:55:05Z

compiler/rustc_mir_transform/src/validate.rs

-        );
+        if self.tcx.dcx().has_errors().is_none() {
+            span_bug!(
+                self.body.span,


You could use the location to get a better span -- might be worth it?
Specifically, body.source_info(location).span.

That's so much better, thank you. I wish I had it when I was looking through 80-line test functions :P

RalfJung · 2025-07-19T21:14:01Z

Thanks! Nice little papercut fixed. r? @RalfJung
r=me when CI is happy
(won't that Miri test need re-blessing with the more precise span?)

scottmcm · 2025-07-19T21:15:10Z

(won't that Miri test need re-blessing with the more precise span?)

Yup, 100%, just forgot it's ignore-windows so my run didn't notice.

scottmcm · 2025-07-20T03:45:10Z

Ok, CI's happy other than the spellcheck that's failing everything.

@bors r=RalfJung (WARNING for rollups: will conflict with 143833)

bors · 2025-07-20T03:45:13Z

📌 Commit 14d097f has been approved by RalfJung

It is now in the queue for this repository.

RalfJung · 2025-07-20T06:03:50Z

Now it needs to be re-borsed, no? @bors r+

bors · 2025-07-20T06:03:54Z

💡 This pull request was already approved, no need to approve it again.

There's another pull request that is currently being tested, blocking this pull request: Rollup of 12 pull requests #144204

bors · 2025-07-20T06:03:54Z

📌 Commit 14d097f has been approved by RalfJung

It is now in the queue for this repository.

RalfJung · 2025-07-20T06:09:13Z

Apparently not :)

scottmcm · 2025-07-20T07:23:53Z

Looks like doing that fixed the labels, at least :)

…idation, r=RalfJung Give a message with a span on MIR validation error It was handy to get a source+line link for rust-lang#143833, even if it's just to the function and not necessarily to the statement. r? mir

Rollup of 9 pull requests Successful merges: - #143282 (Add `uX::strict_sub_signed`) - #143423 (address clippy formatting nits) - #143720 (Allow `Rvalue::Repeat` to return true in `rvalue_creates_operand` too) - #144011 (bootstrap: Don't trigger an unnecessary LLVM build from check builds) - #144112 (bootstrap: Ignore `rust.debuginfo-level-tests` for codegen tests) - #144125 (Add new `ignore-backends` and `needs-backends` tests annotations) - #144143 (Fix `-Ctarget-feature`s getting ignored after `crt-static`) - #144150 (tests: assembly: cstring-merging: Disable GlobalMerge pass) - #144190 (Give a message with a span on MIR validation error) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #144190 - scottmcm:spanned-errors-in-mir-validation, r=RalfJung Give a message with a span on MIR validation error It was handy to get a source+line link for #143833, even if it's just to the function and not necessarily to the statement. r? mir

Rollup of 9 pull requests Successful merges: - rust-lang/rust#143282 (Add `uX::strict_sub_signed`) - rust-lang/rust#143423 (address clippy formatting nits) - rust-lang/rust#143720 (Allow `Rvalue::Repeat` to return true in `rvalue_creates_operand` too) - rust-lang/rust#144011 (bootstrap: Don't trigger an unnecessary LLVM build from check builds) - rust-lang/rust#144112 (bootstrap: Ignore `rust.debuginfo-level-tests` for codegen tests) - rust-lang/rust#144125 (Add new `ignore-backends` and `needs-backends` tests annotations) - rust-lang/rust#144143 (Fix `-Ctarget-feature`s getting ignored after `crt-static`) - rust-lang/rust#144150 (tests: assembly: cstring-merging: Disable GlobalMerge pass) - rust-lang/rust#144190 (Give a message with a span on MIR validation error) r? `@ghost` `@rustbot` modify labels: rollup

…idation, r=RalfJung Give a message with a span on MIR validation error It was handy to get a source+line link for rust-lang#143833, even if it's just to the function and not necessarily to the statement. r? mir

…llaumeGomez Rollup of 9 pull requests Successful merges: - rust-lang#143282 (Add `uX::strict_sub_signed`) - rust-lang#143423 (address clippy formatting nits) - rust-lang#143720 (Allow `Rvalue::Repeat` to return true in `rvalue_creates_operand` too) - rust-lang#144011 (bootstrap: Don't trigger an unnecessary LLVM build from check builds) - rust-lang#144112 (bootstrap: Ignore `rust.debuginfo-level-tests` for codegen tests) - rust-lang#144125 (Add new `ignore-backends` and `needs-backends` tests annotations) - rust-lang#144143 (Fix `-Ctarget-feature`s getting ignored after `crt-static`) - rust-lang#144150 (tests: assembly: cstring-merging: Disable GlobalMerge pass) - rust-lang#144190 (Give a message with a span on MIR validation error) r? `@ghost` `@rustbot` modify labels: rollup

rustbot assigned matthewjasper Jul 19, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 19, 2025

RalfJung reviewed Jul 19, 2025

View reviewed changes

scottmcm force-pushed the spanned-errors-in-mir-validation branch from 12f12de to 15fe203 Compare July 19, 2025 21:09

rustbot assigned RalfJung and unassigned matthewjasper Jul 19, 2025

Give a message with a span on validation error

14d097f

scottmcm force-pushed the spanned-errors-in-mir-validation branch from 15fe203 to 14d097f Compare July 19, 2025 21:14

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 20, 2025

workingjubilee closed this Jul 20, 2025

workingjubilee reopened this Jul 20, 2025

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 20, 2025

bors removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 20, 2025

This was referenced Jul 20, 2025

Rollup of 8 pull requests #144217

Closed

Rollup of 9 pull requests #144219

Merged

bors merged commit ae3708e into rust-lang:master Jul 20, 2025
21 of 22 checks passed

rustbot added this to the 1.90.0 milestone Jul 20, 2025

scottmcm mentioned this pull request Jul 20, 2025

Ban projecting into SIMD types [MCP838] #143833

Merged

scottmcm deleted the spanned-errors-in-mir-validation branch July 20, 2025 17:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Give a message with a span on MIR validation error #144190

Give a message with a span on MIR validation error #144190

Uh oh!

scottmcm commented Jul 19, 2025 •

edited by rustbot

Loading

Uh oh!

rustbot commented Jul 19, 2025

Uh oh!

RalfJung Jul 19, 2025

Uh oh!

scottmcm Jul 19, 2025

Uh oh!

RalfJung Jul 19, 2025

Uh oh!

scottmcm Jul 19, 2025

Uh oh!

RalfJung commented Jul 19, 2025

Uh oh!

scottmcm commented Jul 19, 2025

Uh oh!

scottmcm commented Jul 20, 2025

Uh oh!

bors commented Jul 20, 2025

Uh oh!

RalfJung commented Jul 20, 2025 via email

Uh oh!

bors commented Jul 20, 2025

Uh oh!

bors commented Jul 20, 2025

Uh oh!

RalfJung commented Jul 20, 2025

Uh oh!

scottmcm commented Jul 20, 2025

Uh oh!

Uh oh!

Uh oh!

		@@ -1,11 +1,20 @@
		error: internal compiler error: compiler/rustc_mir_transform/src/validate.rs:LL:CC: broken MIR in Item(DefId) (after phase change to runtime-optimized) at bb0[1]:
		place ((_2.0: mut i32)) has deref as a later projection (it is only permitted as the first projection)

Give a message with a span on MIR validation error #144190

Give a message with a span on MIR validation error #144190

Uh oh!

Conversation

scottmcm commented Jul 19, 2025 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Jul 19, 2025

Uh oh!

RalfJung Jul 19, 2025

Choose a reason for hiding this comment

Uh oh!

scottmcm Jul 19, 2025

Choose a reason for hiding this comment

Uh oh!

RalfJung Jul 19, 2025

Choose a reason for hiding this comment

Uh oh!

scottmcm Jul 19, 2025

Choose a reason for hiding this comment

Uh oh!

RalfJung commented Jul 19, 2025

Uh oh!

scottmcm commented Jul 19, 2025

Uh oh!

scottmcm commented Jul 20, 2025

Uh oh!

bors commented Jul 20, 2025

Uh oh!

RalfJung commented Jul 20, 2025 via email

Uh oh!

bors commented Jul 20, 2025

Uh oh!

bors commented Jul 20, 2025

Uh oh!

RalfJung commented Jul 20, 2025

Uh oh!

scottmcm commented Jul 20, 2025

Uh oh!

Uh oh!

Uh oh!

scottmcm commented Jul 19, 2025 •

edited by rustbot

Loading