fix(lib-std-fs): handle usize overflow in read*
#143462
Merged
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
|
Shouldn't this fail with Also modifications to |
Rudxain
force-pushed
the
read_to_string_usize
branch
2 times, most recently
from
c72c762 to
c03b767
Compare
Rudxain
changed the title
usize overflow in read_to_stringusize overflow in read*
Rudxain
force-pushed
the
read_to_string_usize
branch
from
c03b767 to
a320810
Compare
|
Hi, is there any particular reason you have not added regression tests for this fix? Regression tests are useful for many reasons, for example:
|
|
Thanks for the reminder! I do agree that tests would be a good idea. I'll have to re-read the contrib-docs, because IDK how to do it properly |
|
I don't think a test here is necessary. The previous behaviour wasn't a bug, just a suboptimal implementation. And you'd probably have to track the amount of read syscalls in order to test this, which is way to overkill for such a simple fix. @bors r+ |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Aug 30, 2025
Rollup of 5 pull requests Successful merges: - #143462 (fix(lib-std-fs): handle `usize` overflow in `read*`) - #144651 (Implementation: `#[feature(nonpoison_condvar)]`) - #145465 (Stabilize `array_repeat` feature) - #145776 (Optimize `.ilog({2,10})` to `.ilog{2,10}()`) - #145969 (Add Duration::from_nanos_u128) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Aug 30, 2025
Rollup merge of #143462 - Rudxain:read_to_string_usize, r=joboet fix(lib-std-fs): handle `usize` overflow in `read*` I assume this is a non-breaking change, as there would be an OOM `panic` anyways. This patch ensures a fast-fail when there's not enough memory to load the file. This only changes behavior on platforms where `usize` is smaller than 64bits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I assume this is a non-breaking change, as there would be an OOM
panicanyways. This patch ensures a fast-fail when there's not enough memory to load the file. This only changes behavior on platforms whereusizeis smaller than 64bits