Skip to content

Conversation

actuallylost
Copy link
Contributor

@actuallylost actuallylost commented Aug 28, 2025

Feature Gate: #![feature(duration_from_nanos_u128)]
ACP: rust-lang/libs-team#567
Tracking issue: #139201
Recreated from #139243

@rustbot
Copy link
Collaborator

rustbot commented Aug 28, 2025

r? @tgross35

rustbot has assigned @tgross35.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Aug 28, 2025
@rustbot

This comment has been minimized.

Copy link
Contributor

@tgross35 tgross35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking this up! Just a few requests.

Also, could you squash to one commit? You should make yourself the commit author, but leave a Co-authored-by for the original author (let me know if you need help doing this)

View changes since this review

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 28, 2025
@actuallylost
Copy link
Contributor Author

Also, could you squash to one commit? You should make yourself the commit author, but leave a Co-authored-by for the original author (let me know if you need help doing this)

Sure, would you like me to keep, or remove the commit messages from the squashed commit?

@tgross35
Copy link
Contributor

Usually the message should describe what the commit does, not really its development history (unless that's relevant for some reason). So just the first message is fine 👍

@actuallylost actuallylost force-pushed the duration-from-nanos-128 branch from 469d6a8 to 1ca6794 Compare August 29, 2025 21:41
@rustbot
Copy link
Collaborator

rustbot commented Aug 29, 2025

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@actuallylost
Copy link
Contributor Author

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 29, 2025
Tracking issue: RUST-139201

Co-authored-by: omanirudh <omanirudh2014@gmail.com>
@actuallylost actuallylost force-pushed the duration-from-nanos-128 branch from 1ca6794 to 8134a10 Compare August 29, 2025 22:39
Copy link
Contributor

@tgross35 tgross35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you for getting this over the line! I'll add it to the queue once CI completes

View changes since this review

@tgross35
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Aug 30, 2025

📌 Commit 8134a10 has been approved by tgross35

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 30, 2025
bors added a commit that referenced this pull request Aug 30, 2025
Rollup of 5 pull requests

Successful merges:

 - #143462 (fix(lib-std-fs): handle `usize` overflow in `read*`)
 - #144651 (Implementation: `#[feature(nonpoison_condvar)]`)
 - #145465 (Stabilize `array_repeat` feature)
 - #145776 (Optimize `.ilog({2,10})` to `.ilog{2,10}()`)
 - #145969 (Add Duration::from_nanos_u128)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit f655e6a into rust-lang:master Aug 30, 2025
10 checks passed
rust-timer added a commit that referenced this pull request Aug 30, 2025
Rollup merge of #145969 - actuallylost:duration-from-nanos-128, r=tgross35

Add Duration::from_nanos_u128

Feature Gate: `#![feature(duration_from_nanos_u128)]`
ACP: rust-lang/libs-team#567
Tracking issue: #139201
Recreated from #139243
@rustbot rustbot added this to the 1.91.0 milestone Aug 30, 2025
@actuallylost actuallylost deleted the duration-from-nanos-128 branch August 30, 2025 17:22
github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request Sep 9, 2025
…28, r=tgross35

Add Duration::from_nanos_u128

Feature Gate: `#![feature(duration_from_nanos_u128)]`
ACP: rust-lang/libs-team#567
Tracking issue: rust-lang#139201
Recreated from rust-lang#139243
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants