-
Notifications
You must be signed in to change notification settings - Fork 13.7k
Add Duration::from_nanos_u128 #145969
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Duration::from_nanos_u128 #145969
Conversation
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for picking this up! Just a few requests.
Also, could you squash to one commit? You should make yourself the commit author, but leave a Co-authored-by for the original author (let me know if you need help doing this)
Sure, would you like me to keep, or remove the commit messages from the squashed commit? |
Usually the message should describe what the commit does, not really its development history (unless that's relevant for some reason). So just the first message is fine 👍 |
469d6a8
to
1ca6794
Compare
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
@rustbot ready |
Tracking issue: RUST-139201 Co-authored-by: omanirudh <omanirudh2014@gmail.com>
1ca6794
to
8134a10
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thank you for getting this over the line! I'll add it to the queue once CI completes
@bors r+ rollup |
Rollup of 5 pull requests Successful merges: - #143462 (fix(lib-std-fs): handle `usize` overflow in `read*`) - #144651 (Implementation: `#[feature(nonpoison_condvar)]`) - #145465 (Stabilize `array_repeat` feature) - #145776 (Optimize `.ilog({2,10})` to `.ilog{2,10}()`) - #145969 (Add Duration::from_nanos_u128) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of #145969 - actuallylost:duration-from-nanos-128, r=tgross35 Add Duration::from_nanos_u128 Feature Gate: `#![feature(duration_from_nanos_u128)]` ACP: rust-lang/libs-team#567 Tracking issue: #139201 Recreated from #139243
…28, r=tgross35 Add Duration::from_nanos_u128 Feature Gate: `#![feature(duration_from_nanos_u128)]` ACP: rust-lang/libs-team#567 Tracking issue: rust-lang#139201 Recreated from rust-lang#139243
Feature Gate:
#![feature(duration_from_nanos_u128)]
ACP: rust-lang/libs-team#567
Tracking issue: #139201
Recreated from #139243