Added error for invalid char cast #143678

Kivooeo · 2025-07-09T10:28:38Z

not really sure if I did it right, but according to cast-char test -- it is right, also this code gave me false positive result

for _ in 0..(256 as u8) {}

so this is why I added this check if lit_val <= 0xFF

Also I believe that error message could be improved, but I'm not sure how exactly

cc @hkBst

r? compiler

tests/ui/cast/cast-char.stderr

compiler/rustc_lint/src/types/literal.rs

tests/ui/cast/cast-char.rs

compiler/rustc_lint/src/types/literal.rs

hkBst · 2025-07-09T12:51:03Z

I had a few more suggestions, but this is nearing completion: good work!

compiler/rustc_lint/messages.ftl

compiler/rustc_lint/src/types/literal.rs

hkBst

A few nits left, but fundamentally done.

hkBst · 2025-07-10T12:30:02Z

@fmease your turn ;P

SparrowLii

This looks fine and only affects diagnostics.

SparrowLii · 2025-07-16T02:09:42Z

@bors r+

bors · 2025-07-16T02:09:44Z

📌 Commit 81a6f18 has been approved by SparrowLii

It is now in the queue for this repository.

bors · 2025-07-16T02:09:45Z

🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened.

Added error for invalid char cast fixes rust-lang#143597 not really sure if I did it right, but according to cast-char test -- it is right, also this code gave me false positive result ``` for _ in 0..(256 as u8) {} ``` so this is why I added this check `if lit_val <= 0xFF` Also I believe that error message could be improved, but I'm not sure how exactly cc `@hkBst` r? compiler

Added error for invalid char cast fixes rust-lang#143597 not really sure if I did it right, but according to cast-char test -- it is right, also this code gave me false positive result ``` for _ in 0..(256 as u8) {} ``` so this is why I added this check `if lit_val <= 0xFF` Also I believe that error message could be improved, but I'm not sure how exactly cc ``@hkBst`` r? compiler

Added error for invalid char cast fixes rust-lang#143597 not really sure if I did it right, but according to cast-char test -- it is right, also this code gave me false positive result ``` for _ in 0..(256 as u8) {} ``` so this is why I added this check `if lit_val <= 0xFF` Also I believe that error message could be improved, but I'm not sure how exactly cc ```@hkBst``` r? compiler

Rollup of 11 pull requests Successful merges: - #143595 (add `const_make_global`; err for `const_allocate` ptrs if didn't call) - #143678 (Added error for invalid char cast) - #143793 (Opaque type collection: Guard against endlessly recursing free alias types) - #143820 (Fixed a core crate compilation failure when enabling the `optimize_for_size` feature on some targets) - #143829 (Trim `BorrowedCursor` API) - #143856 (Linting public reexport of private dependencies) - #143891 (Port `#[coverage]` to the new attribute system) - #143914 (Reword mismatched-lifetime-syntaxes text based on feedback) - #143922 (Improve path segment joining) - #143926 (Remove deprecated fields in bootstrap) - #143975 (type_id_eq: check that the hash fully matches the type) r? `@ghost` `@rustbot` modify labels: rollup

Added error for invalid char cast fixes rust-lang#143597 not really sure if I did it right, but according to cast-char test -- it is right, also this code gave me false positive result ``` for _ in 0..(256 as u8) {} ``` so this is why I added this check `if lit_val <= 0xFF` Also I believe that error message could be improved, but I'm not sure how exactly cc ``@hkBst`` r? compiler

Rollup of 15 pull requests Successful merges: - #142304 (tests: Add `RUST_BACKTRACE` and `-Cpanic` revisions to `panic-main.rs` test) - #143388 (Various refactors to the LTO handling code) - #143409 (Enable xgot feature for mips64 musl targets) - #143592 (UWP: link ntdll functions using raw-dylib) - #143595 (add `const_make_global`; err for `const_allocate` ptrs if didn't call) - #143678 (Added error for invalid char cast) - #143820 (Fixed a core crate compilation failure when enabling the `optimize_for_size` feature on some targets) - #143829 (Trim `BorrowedCursor` API) - #143846 (pass --gc-sections if -Zexport-executable-symbols is enabled and improve tests) - #143851 (ci cleanup: rustdoc-gui-test now installs browser-ui-test) - #143856 (Linting public reexport of private dependencies) - #143895 (Dont collect assoc ty item bounds from trait where clause for host effect predicates) - #143922 (Improve path segment joining) - #143964 (Fix handling of SCRIPT_ARG in docker images) - #144016 (trait_sel: `MetaSized` always holds temporarily) r? `@ghost` `@rustbot` modify labels: rollup

Rollup of 15 pull requests Successful merges: - #142304 (tests: Add `RUST_BACKTRACE` and `-Cpanic` revisions to `panic-main.rs` test) - #143388 (Various refactors to the LTO handling code) - #143409 (Enable xgot feature for mips64 musl targets) - #143592 (UWP: link ntdll functions using raw-dylib) - #143595 (add `const_make_global`; err for `const_allocate` ptrs if didn't call) - #143678 (Added error for invalid char cast) - #143820 (Fixed a core crate compilation failure when enabling the `optimize_for_size` feature on some targets) - #143829 (Trim `BorrowedCursor` API) - #143851 (ci cleanup: rustdoc-gui-test now installs browser-ui-test) - #143856 (Linting public reexport of private dependencies) - #143895 (Dont collect assoc ty item bounds from trait where clause for host effect predicates) - #143922 (Improve path segment joining) - #143964 (Fix handling of SCRIPT_ARG in docker images) - #144002 (Update poison.rs) - #144016 (trait_sel: `MetaSized` always holds temporarily) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #143678 - Kivooeo:char-overflow, r=SparrowLii Added error for invalid char cast fixes #143597 not really sure if I did it right, but according to cast-char test -- it is right, also this code gave me false positive result ``` for _ in 0..(256 as u8) {} ``` so this is why I added this check `if lit_val <= 0xFF` Also I believe that error message could be improved, but I'm not sure how exactly cc ```@hkBst``` r? compiler

hkBst · 2025-07-17T08:47:30Z

@Kivooeo great work!

Added error for invalid char cast fixes rust-lang#143597 not really sure if I did it right, but according to cast-char test -- it is right, also this code gave me false positive result ``` for _ in 0..(256 as u8) {} ``` so this is why I added this check `if lit_val <= 0xFF` Also I believe that error message could be improved, but I'm not sure how exactly cc ```@hkBst``` r? compiler

Rollup of 15 pull requests Successful merges: - rust-lang#142304 (tests: Add `RUST_BACKTRACE` and `-Cpanic` revisions to `panic-main.rs` test) - rust-lang#143388 (Various refactors to the LTO handling code) - rust-lang#143409 (Enable xgot feature for mips64 musl targets) - rust-lang#143592 (UWP: link ntdll functions using raw-dylib) - rust-lang#143595 (add `const_make_global`; err for `const_allocate` ptrs if didn't call) - rust-lang#143678 (Added error for invalid char cast) - rust-lang#143820 (Fixed a core crate compilation failure when enabling the `optimize_for_size` feature on some targets) - rust-lang#143829 (Trim `BorrowedCursor` API) - rust-lang#143851 (ci cleanup: rustdoc-gui-test now installs browser-ui-test) - rust-lang#143856 (Linting public reexport of private dependencies) - rust-lang#143895 (Dont collect assoc ty item bounds from trait where clause for host effect predicates) - rust-lang#143922 (Improve path segment joining) - rust-lang#143964 (Fix handling of SCRIPT_ARG in docker images) - rust-lang#144002 (Update poison.rs) - rust-lang#144016 (trait_sel: `MetaSized` always holds temporarily) r? `@ghost` `@rustbot` modify labels: rollup

Rollup of 15 pull requests Successful merges: - rust-lang/rust#142304 (tests: Add `RUST_BACKTRACE` and `-Cpanic` revisions to `panic-main.rs` test) - rust-lang/rust#143388 (Various refactors to the LTO handling code) - rust-lang/rust#143409 (Enable xgot feature for mips64 musl targets) - rust-lang/rust#143592 (UWP: link ntdll functions using raw-dylib) - rust-lang/rust#143595 (add `const_make_global`; err for `const_allocate` ptrs if didn't call) - rust-lang/rust#143678 (Added error for invalid char cast) - rust-lang/rust#143820 (Fixed a core crate compilation failure when enabling the `optimize_for_size` feature on some targets) - rust-lang/rust#143829 (Trim `BorrowedCursor` API) - rust-lang/rust#143851 (ci cleanup: rustdoc-gui-test now installs browser-ui-test) - rust-lang/rust#143856 (Linting public reexport of private dependencies) - rust-lang/rust#143895 (Dont collect assoc ty item bounds from trait where clause for host effect predicates) - rust-lang/rust#143922 (Improve path segment joining) - rust-lang/rust#143964 (Fix handling of SCRIPT_ARG in docker images) - rust-lang/rust#144002 (Update poison.rs) - rust-lang/rust#144016 (trait_sel: `MetaSized` always holds temporarily) r? `@ghost` `@rustbot` modify labels: rollup

rustbot assigned SparrowLii Jul 9, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 9, 2025

This comment has been minimized.

Sign in to view

Kivooeo force-pushed the char-overflow branch from 71d04a7 to 2e62a9e Compare July 9, 2025 10:38

hkBst suggested changes Jul 9, 2025

View reviewed changes

tests/ui/cast/cast-char.stderr Outdated Show resolved Hide resolved

compiler/rustc_lint/src/types/literal.rs Outdated Show resolved Hide resolved

compiler/rustc_lint/src/types/literal.rs Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

Kivooeo force-pushed the char-overflow branch from 2e62a9e to 261e71f Compare July 9, 2025 11:38

This comment has been minimized.

Sign in to view

Kivooeo force-pushed the char-overflow branch 2 times, most recently from 84cd0b4 to 1260317 Compare July 9, 2025 12:36

hkBst suggested changes Jul 9, 2025

View reviewed changes

tests/ui/cast/cast-char.rs Outdated Show resolved Hide resolved

tests/ui/cast/cast-char.rs Outdated Show resolved Hide resolved

compiler/rustc_lint/src/types/literal.rs Outdated Show resolved Hide resolved

fmease reviewed Jul 9, 2025

View reviewed changes

compiler/rustc_lint/messages.ftl Outdated Show resolved Hide resolved

Kivooeo force-pushed the char-overflow branch 2 times, most recently from 9cc1707 to 7b17511 Compare July 9, 2025 17:57

hkBst reviewed Jul 10, 2025

View reviewed changes

compiler/rustc_lint/messages.ftl Outdated Show resolved Hide resolved

hkBst reviewed Jul 10, 2025

View reviewed changes

compiler/rustc_lint/messages.ftl Outdated Show resolved Hide resolved

hkBst reviewed Jul 10, 2025

View reviewed changes

compiler/rustc_lint/src/types/literal.rs Outdated Show resolved Hide resolved

hkBst approved these changes Jul 10, 2025

View reviewed changes

added error for invalid char cast

81a6f18

Kivooeo force-pushed the char-overflow branch from 7b17511 to 81a6f18 Compare July 10, 2025 10:44

SparrowLii approved these changes Jul 16, 2025

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 16, 2025

matthiaskrgr mentioned this pull request Jul 16, 2025

Rollup of 12 pull requests #144035

Closed

matthiaskrgr mentioned this pull request Jul 16, 2025

Rollup of 12 pull requests #144036

Closed

matthiaskrgr mentioned this pull request Jul 16, 2025

Rollup of 11 pull requests #144038

Closed

fmease mentioned this pull request Jul 16, 2025

Rollup of 15 pull requests #144041

Closed

fmease mentioned this pull request Jul 17, 2025

Rollup of 15 pull requests #144044

Merged

bors merged commit fe420b0 into rust-lang:master Jul 17, 2025
11 checks passed

rustbot added this to the 1.90.0 milestone Jul 17, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Added error for invalid char cast #143678

Added error for invalid char cast #143678

Uh oh!

Kivooeo commented Jul 9, 2025 •

edited by rustbot

Loading

Uh oh!

This comment has been minimized.

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

Uh oh!

Uh oh!

Uh oh!

hkBst commented Jul 9, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hkBst left a comment

Uh oh!

hkBst commented Jul 10, 2025

Uh oh!

SparrowLii left a comment •

edited

Loading

Uh oh!

SparrowLii commented Jul 16, 2025

Uh oh!

bors commented Jul 16, 2025

Uh oh!

bors commented Jul 16, 2025

Uh oh!

Uh oh!

hkBst commented Jul 17, 2025

Uh oh!

Uh oh!

Added error for invalid char cast #143678

Added error for invalid char cast #143678

Uh oh!

Conversation

Kivooeo commented Jul 9, 2025 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

Uh oh!

Uh oh!

Uh oh!

hkBst commented Jul 9, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hkBst left a comment

Choose a reason for hiding this comment

Uh oh!

hkBst commented Jul 10, 2025

Uh oh!

SparrowLii left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

SparrowLii commented Jul 16, 2025

Uh oh!

bors commented Jul 16, 2025

Uh oh!

bors commented Jul 16, 2025

Uh oh!

Uh oh!

hkBst commented Jul 17, 2025

Uh oh!

Uh oh!

Kivooeo commented Jul 9, 2025 •

edited by rustbot

Loading

SparrowLii left a comment •

edited

Loading