ci cleanup: rustdoc-gui-test now installs browser-ui-test #143851

lolbinarycat · 2025-07-12T18:23:52Z

this removes the need for --unsafe-perm in the Dockerfile.

rustbot · 2025-07-12T18:23:56Z

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Kobzol

Thanks, I think it's much nicer to make sure that we have a known and exact environment, than trying to guess and compare what comes from the outside world.

src/ci/docker/host-x86_64/x86_64-gnu-tools/Dockerfile

Kobzol · 2025-07-12T20:28:44Z

r? @Kobzol

GuillaumeGomez · 2025-07-14T13:02:34Z

src/tools/rustdoc-gui-test/src/main.rs

-        Err(e) => eprintln!("Couldn't find the CI browser-ui-test version: {:?}", e),
-    }
+fn get_desired_browser_ui_test_version(src: &Path) -> Result<String, io::Error> {
+    Ok("0.21.1")


Don't we have a package.json already? If not, please add a FIXME comment to update/remove this function once we make use of package.json.

no, that's being added in a future PR that I want to make this CI change before.

once we have a package.json we could update this function to use npm update, no? would that install a specific package according to the version in the package.json ..?

I suppose probably we'll just use npm install, though.

src/build_helper/src/npm.rs

Kobzol · 2025-07-15T18:10:56Z

Looks good! You can r=me once CI is green.

@bors delegate+

bors · 2025-07-15T18:10:59Z

✌️ @lolbinarycat, you can now approve this pull request!

If @Kobzol told you to "r=me" after making some further change, please make that change, then do @bors r=@Kobzol

this removes the need for --unsafe-perm in the Dockerfile.

lolbinarycat · 2025-07-15T21:01:33Z

@bors r=@Kobzol

bors · 2025-07-15T21:01:38Z

📌 Commit bbb114e has been approved by Kobzol

It is now in the queue for this repository.

bors · 2025-07-15T21:01:38Z

🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened.

…s, r=Kobzol ci cleanup: rustdoc-gui-test now installs browser-ui-test this removes the need for --unsafe-perm in the Dockerfile. cc ``@GuillaumeGomez`` ``@Kobzol``

Rollup of 15 pull requests Successful merges: - #142304 (tests: Add `RUST_BACKTRACE` and `-Cpanic` revisions to `panic-main.rs` test) - #143388 (Various refactors to the LTO handling code) - #143409 (Enable xgot feature for mips64 musl targets) - #143592 (UWP: link ntdll functions using raw-dylib) - #143595 (add `const_make_global`; err for `const_allocate` ptrs if didn't call) - #143678 (Added error for invalid char cast) - #143820 (Fixed a core crate compilation failure when enabling the `optimize_for_size` feature on some targets) - #143829 (Trim `BorrowedCursor` API) - #143846 (pass --gc-sections if -Zexport-executable-symbols is enabled and improve tests) - #143851 (ci cleanup: rustdoc-gui-test now installs browser-ui-test) - #143856 (Linting public reexport of private dependencies) - #143895 (Dont collect assoc ty item bounds from trait where clause for host effect predicates) - #143922 (Improve path segment joining) - #143964 (Fix handling of SCRIPT_ARG in docker images) - #144016 (trait_sel: `MetaSized` always holds temporarily) r? `@ghost` `@rustbot` modify labels: rollup

Rollup of 15 pull requests Successful merges: - #142304 (tests: Add `RUST_BACKTRACE` and `-Cpanic` revisions to `panic-main.rs` test) - #143388 (Various refactors to the LTO handling code) - #143409 (Enable xgot feature for mips64 musl targets) - #143592 (UWP: link ntdll functions using raw-dylib) - #143595 (add `const_make_global`; err for `const_allocate` ptrs if didn't call) - #143678 (Added error for invalid char cast) - #143820 (Fixed a core crate compilation failure when enabling the `optimize_for_size` feature on some targets) - #143829 (Trim `BorrowedCursor` API) - #143851 (ci cleanup: rustdoc-gui-test now installs browser-ui-test) - #143856 (Linting public reexport of private dependencies) - #143895 (Dont collect assoc ty item bounds from trait where clause for host effect predicates) - #143922 (Improve path segment joining) - #143964 (Fix handling of SCRIPT_ARG in docker images) - #144002 (Update poison.rs) - #144016 (trait_sel: `MetaSized` always holds temporarily) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #143851 - lolbinarycat:bootstrap-node_modules, r=Kobzol ci cleanup: rustdoc-gui-test now installs browser-ui-test this removes the need for --unsafe-perm in the Dockerfile. cc ```@GuillaumeGomez``` ```@Kobzol```

…s, r=Kobzol ci cleanup: rustdoc-gui-test now installs browser-ui-test this removes the need for --unsafe-perm in the Dockerfile. cc ```@GuillaumeGomez``` ```@Kobzol```

Rollup of 15 pull requests Successful merges: - rust-lang#142304 (tests: Add `RUST_BACKTRACE` and `-Cpanic` revisions to `panic-main.rs` test) - rust-lang#143388 (Various refactors to the LTO handling code) - rust-lang#143409 (Enable xgot feature for mips64 musl targets) - rust-lang#143592 (UWP: link ntdll functions using raw-dylib) - rust-lang#143595 (add `const_make_global`; err for `const_allocate` ptrs if didn't call) - rust-lang#143678 (Added error for invalid char cast) - rust-lang#143820 (Fixed a core crate compilation failure when enabling the `optimize_for_size` feature on some targets) - rust-lang#143829 (Trim `BorrowedCursor` API) - rust-lang#143851 (ci cleanup: rustdoc-gui-test now installs browser-ui-test) - rust-lang#143856 (Linting public reexport of private dependencies) - rust-lang#143895 (Dont collect assoc ty item bounds from trait where clause for host effect predicates) - rust-lang#143922 (Improve path segment joining) - rust-lang#143964 (Fix handling of SCRIPT_ARG in docker images) - rust-lang#144002 (Update poison.rs) - rust-lang#144016 (trait_sel: `MetaSized` always holds temporarily) r? `@ghost` `@rustbot` modify labels: rollup

Rollup of 15 pull requests Successful merges: - rust-lang/rust#142304 (tests: Add `RUST_BACKTRACE` and `-Cpanic` revisions to `panic-main.rs` test) - rust-lang/rust#143388 (Various refactors to the LTO handling code) - rust-lang/rust#143409 (Enable xgot feature for mips64 musl targets) - rust-lang/rust#143592 (UWP: link ntdll functions using raw-dylib) - rust-lang/rust#143595 (add `const_make_global`; err for `const_allocate` ptrs if didn't call) - rust-lang/rust#143678 (Added error for invalid char cast) - rust-lang/rust#143820 (Fixed a core crate compilation failure when enabling the `optimize_for_size` feature on some targets) - rust-lang/rust#143829 (Trim `BorrowedCursor` API) - rust-lang/rust#143851 (ci cleanup: rustdoc-gui-test now installs browser-ui-test) - rust-lang/rust#143856 (Linting public reexport of private dependencies) - rust-lang/rust#143895 (Dont collect assoc ty item bounds from trait where clause for host effect predicates) - rust-lang/rust#143922 (Improve path segment joining) - rust-lang/rust#143964 (Fix handling of SCRIPT_ARG in docker images) - rust-lang/rust#144002 (Update poison.rs) - rust-lang/rust#144016 (trait_sel: `MetaSized` always holds temporarily) r? `@ghost` `@rustbot` modify labels: rollup

rustbot assigned Mark-Simulacrum Jul 12, 2025

This comment has been minimized.

Sign in to view

lolbinarycat force-pushed the bootstrap-node_modules branch from c070840 to 5bc18df Compare July 12, 2025 18:50

This comment has been minimized.

Sign in to view

lolbinarycat force-pushed the bootstrap-node_modules branch from 5bc18df to 4254f64 Compare July 12, 2025 20:10

Kobzol reviewed Jul 12, 2025

View reviewed changes

src/ci/docker/host-x86_64/x86_64-gnu-tools/Dockerfile Show resolved Hide resolved

rustbot assigned Kobzol and unassigned Mark-Simulacrum Jul 12, 2025

lolbinarycat force-pushed the bootstrap-node_modules branch 2 times, most recently from 8a1869c to 4028b6d Compare July 12, 2025 21:04

This comment has been minimized.

Sign in to view

lolbinarycat force-pushed the bootstrap-node_modules branch from 4028b6d to 2f62ee4 Compare July 12, 2025 21:19

This comment has been minimized.

Sign in to view

GuillaumeGomez reviewed Jul 14, 2025

View reviewed changes

lolbinarycat commented Jul 14, 2025

View reviewed changes

src/build_helper/src/npm.rs Outdated Show resolved Hide resolved

lolbinarycat force-pushed the bootstrap-node_modules branch from 2f62ee4 to 4d4da0e Compare July 15, 2025 18:04

lolbinarycat force-pushed the bootstrap-node_modules branch from 4d4da0e to 4deb8eb Compare July 15, 2025 19:08

ci cleanup: rustdoc-gui-test now installs browser-ui-test

bbb114e

this removes the need for --unsafe-perm in the Dockerfile.

lolbinarycat force-pushed the bootstrap-node_modules branch from 4deb8eb to bbb114e Compare July 15, 2025 19:39

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 15, 2025

fmease mentioned this pull request Jul 16, 2025

Rollup of 15 pull requests #144041

Closed

fmease mentioned this pull request Jul 17, 2025

Rollup of 15 pull requests #144044

Merged

bors merged commit a07ae62 into rust-lang:master Jul 17, 2025
11 checks passed

rustbot added this to the 1.90.0 milestone Jul 17, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

ci cleanup: rustdoc-gui-test now installs browser-ui-test #143851

ci cleanup: rustdoc-gui-test now installs browser-ui-test #143851

Uh oh!

lolbinarycat commented Jul 12, 2025

Uh oh!

rustbot commented Jul 12, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

Kobzol left a comment

Uh oh!

Uh oh!

Kobzol commented Jul 12, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

GuillaumeGomez Jul 14, 2025

Uh oh!

lolbinarycat Jul 14, 2025

Uh oh!

Uh oh!

Kobzol commented Jul 15, 2025

Uh oh!

bors commented Jul 15, 2025

Uh oh!

lolbinarycat commented Jul 15, 2025

Uh oh!

bors commented Jul 15, 2025

Uh oh!

bors commented Jul 15, 2025

Uh oh!

Uh oh!

Uh oh!

ci cleanup: rustdoc-gui-test now installs browser-ui-test #143851

ci cleanup: rustdoc-gui-test now installs browser-ui-test #143851

Uh oh!

Conversation

lolbinarycat commented Jul 12, 2025

Uh oh!

rustbot commented Jul 12, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

Kobzol left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Kobzol commented Jul 12, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

GuillaumeGomez Jul 14, 2025

Choose a reason for hiding this comment

Uh oh!

lolbinarycat Jul 14, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Kobzol commented Jul 15, 2025

Uh oh!

bors commented Jul 15, 2025

Uh oh!

lolbinarycat commented Jul 15, 2025

Uh oh!

bors commented Jul 15, 2025

Uh oh!

bors commented Jul 15, 2025

Uh oh!

Uh oh!

Uh oh!