Skip to content

Conversation

samueltardieu
Copy link
Member

@samueltardieu samueltardieu commented Jul 14, 2025

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

joshtriplett and others added 20 commits July 9, 2025 13:42
This allows efficient implementations for random sources that generate a
word at a time.
This will let people make calls like random(1..=6), and allows for
future expansion to non-uniform distributions, as well as
floating-point.

For now, this is only implemented for `RangeFull`, to get the interface
in place. Subsequent commits will implement it for other range types.
…g infrastructure

Signed-off-by: Jonathan Brouwer <jonathantbrouwer@gmail.com>
Update README.md
Don't call WSACleanup on process exit

This isn't necessary as cleanup will happen when the process exits regardless.

fixes rust-lang#141799
…htriplett

Updates to random number generation APIs

Updates based on discussions about random number generation.

- Add comment on `RandomSource::fill_bytes` about multiple calls, to allow
  efficient implementations for random sources that generate a word at a time.

- Drop the `Random` trait in favor of `Distribution<T>`, which will let people
  make calls like random(1..=6), and which allows for future expansion to
  non-uniform distributions, as well as floating-point. (For now, this is only
  implemented for `RangeFull`, to get the interface in place. Subsequent PRs
  will implement it for other range types.)
Rename `stable_mir` and `rustc_smir`

This PR only renames the two crate names.

There is no doubt that we want to rename `stable_mir` to `rustc_public`, while it hasn't been discussed yet that what the new name for `rustc_smir` should be.

This PR proposes a new name for `rustc_smir`, that is `rustc_public_shim`, since `rustc_smir` now is mostly a proxy to do calls to rustc queries and the public API of rustc that is invoked by the `rustc_public` crate.

However, I don't think that name is good enough. I hope there would be a way better name.

r? `@oli-obk`
…inter_section, r=jdonszelmann

Port `#[omit_gdb_pretty_printer_section]` to the new attribute parsing

Ports `#[omit_gdb_pretty_printer_section]` to the new attribute parsing infrastructure for rust-lang#131229 (comment)

r? ```@jdonszelmann```
…r=workingjubilee

warn on align on fields to avoid breaking changes

r? `@workingjubilee`
…, r=Kobzol

[COMPILETEST-UNTANGLE 6/N] Use `TestSuite` enum instead of stringly-typed test suites

This is part of a patch series to untangle `compiletest` to hopefully nudge it towards being more maintainable.

This PR should contain no functional changes.
…nits, r=lcnr

Region constraint nits

Couple miscellaneous region constraints that have a bit to do with rust-lang#143545 but stand on their own.
Fix typos in documentation files

## Summary
Fix minor typos in documentation files to improve readability.

## Changes
- **tests/mir-opt/pre-codegen/README.md**: Fix typo `condiguration` → `configuration`
- **tests/ui/SUMMARY.md**: Fix typo in RFC link URL (`namepsace ` → `namespace`)

## Type of Change
- [x] Documentation update
- [x] Bug fix (typo correction)
@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) A-compiletest Area: The compiletest test runner A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-meta Area: Issues & PRs about the rust-lang/rust repository itself A-testsuite Area: The testsuite used to check the correctness of rustc O-SGX Target: SGX S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jul 14, 2025
@rustbot rustbot added WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) rollup A PR which is a rollup labels Jul 14, 2025
@samueltardieu
Copy link
Member Author

@bors r+ rollup=never p=5

@bors
Copy link
Collaborator

bors commented Jul 14, 2025

📌 Commit 9b260f6 has been approved by samueltardieu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 14, 2025
@bors
Copy link
Collaborator

bors commented Jul 14, 2025

⌛ Testing commit 9b260f6 with merge aa51a9b...

@bors
Copy link
Collaborator

bors commented Jul 14, 2025

☀️ Test successful - checks-actions
Approved by: samueltardieu
Pushing aa51a9b to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 14, 2025
@bors bors merged commit aa51a9b into rust-lang:master Jul 14, 2025
12 checks passed
@rustbot rustbot added this to the 1.90.0 milestone Jul 14, 2025
@rust-timer
Copy link
Collaborator

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#141809 Don't call WSACleanup on process exit 77b99e189c994b4b3f9f23eaf1975cccc3beee34 (link)
#143710 Updates to random number generation APIs 852a19e637ef1403029f41a043f36076a106f74d (link)
#143848 Rename stable_mir and rustc_smir e9dc69a32afdc7af056f20f8de8e3269255a65a1 (link)
#143855 Port #[omit_gdb_pretty_printer_section] to the new attrib… 4df0234f4bfb2ae1e8a7277b363b01e946079315 (link)
#143868 warn on align on fields to avoid breaking changes 12a58fc042c365ec99be1db9c18194a43feea768 (link)
#143870 [COMPILETEST-UNTANGLE 6/N] Use TestSuite enum instead of … 1dc33a6bf387da5e512ce396251cef7571eb5f6e (link)
#143901 Region constraint nits 8bdc70c0f9dd8ada04b86fa37fb4220e766f3a26 (link)
#143903 Fix typos in documentation files f6881c4b389c24ecdebebe387af89b1b7650bc03 (link)

previous master: cccf075eba

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

Copy link
Contributor

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing cccf075 (parent) -> aa51a9b (this PR)

Test differences

Show 265 test diffs

Stage 1

  • errors::verify_passes_abi_invalid_attribute_124: pass -> [missing] (J0)
  • errors::verify_passes_abi_ne_123: pass -> [missing] (J0)
  • errors::verify_passes_abi_ne_124: [missing] -> pass (J0)
  • errors::verify_passes_abi_of_122: pass -> [missing] (J0)
  • errors::verify_passes_abi_of_123: [missing] -> pass (J0)
  • errors::verify_passes_allow_internal_unstable_79: pass -> [missing] (J0)
  • errors::verify_passes_attr_application_struct_enum_union_140: pass -> [missing] (J0)
  • errors::verify_passes_attr_application_struct_enum_union_141: [missing] -> pass (J0)
  • errors::verify_passes_attr_application_struct_union_140: [missing] -> pass (J0)
  • errors::verify_passes_collapse_debuginfo_106: [missing] -> pass (J0)
  • errors::verify_passes_confusables_89: pass -> [missing] (J0)
  • errors::verify_passes_const_stable_not_stable_154: pass -> [missing] (J0)
  • errors::verify_passes_coroutine_on_non_closure_91: [missing] -> pass (J0)
  • errors::verify_passes_debug_visualizer_invalid_81: pass -> [missing] (J0)
  • errors::verify_passes_debug_visualizer_invalid_82: [missing] -> pass (J0)
  • errors::verify_passes_debug_visualizer_placement_81: [missing] -> pass (J0)
  • errors::verify_passes_deprecated_93: pass -> [missing] (J0)
  • errors::verify_passes_deprecated_94: [missing] -> pass (J0)
  • errors::verify_passes_deprecated_annotation_has_no_effect_107: [missing] -> pass (J0)
  • errors::verify_passes_duplicate_feature_err_152: pass -> [missing] (J0)
  • errors::verify_passes_duplicate_feature_err_153: [missing] -> pass (J0)
  • errors::verify_passes_extern_main_131: [missing] -> pass (J0)
  • errors::verify_passes_feature_previously_declared_128: [missing] -> pass (J0)
  • errors::verify_passes_feature_stable_twice_126: pass -> [missing] (J0)
  • errors::verify_passes_feature_stable_twice_127: [missing] -> pass (J0)
  • errors::verify_passes_implied_feature_not_exist_151: pass -> [missing] (J0)
  • errors::verify_passes_implied_feature_not_exist_152: [missing] -> pass (J0)
  • errors::verify_passes_incorrect_target_131: pass -> [missing] (J0)
  • errors::verify_passes_ineffective_unstable_impl_163: [missing] -> pass (J0)
  • errors::verify_passes_invalid_macro_export_arguments_97: pass -> [missing] (J0)
  • errors::verify_passes_lang_item_fn_with_target_feature_113: [missing] -> pass (J0)
  • errors::verify_passes_lang_item_fn_with_track_caller_112: [missing] -> pass (J0)
  • errors::verify_passes_lang_item_on_incorrect_target_113: pass -> [missing] (J0)
  • errors::verify_passes_layout_abi_117: [missing] -> pass (J0)
  • errors::verify_passes_layout_align_118: [missing] -> pass (J0)
  • errors::verify_passes_layout_invalid_attribute_122: [missing] -> pass (J0)
  • errors::verify_passes_layout_of_121: [missing] -> pass (J0)
  • errors::verify_passes_layout_size_118: pass -> [missing] (J0)
  • errors::verify_passes_link_ordinal_88: pass -> [missing] (J0)
  • errors::verify_passes_link_ordinal_89: [missing] -> pass (J0)
  • errors::verify_passes_macro_export_95: pass -> [missing] (J0)
  • errors::verify_passes_macro_export_on_decl_macro_96: pass -> [missing] (J0)
  • errors::verify_passes_macro_export_on_decl_macro_97: [missing] -> pass (J0)
  • errors::verify_passes_may_dangle_100: pass -> [missing] (J0)
  • errors::verify_passes_may_dangle_101: [missing] -> pass (J0)
  • errors::verify_passes_missing_const_stab_attr_147: pass -> [missing] (J0)
  • errors::verify_passes_missing_lang_item_110: pass -> [missing] (J0)
  • errors::verify_passes_missing_lang_item_111: [missing] -> pass (J0)
  • errors::verify_passes_multiple_rustc_main_129: pass -> [missing] (J0)
  • errors::verify_passes_multiple_rustc_main_130: [missing] -> pass (J0)
  • errors::verify_passes_no_sanitize_164: pass -> [missing] (J0)
  • errors::verify_passes_no_sanitize_165: [missing] -> pass (J0)
  • errors::verify_passes_non_exported_macro_invalid_attrs_100: [missing] -> pass (J0)
  • errors::verify_passes_object_lifetime_err_137: [missing] -> pass (J0)
  • errors::verify_passes_only_has_effect_on_135: [missing] -> pass (J0)
  • errors::verify_passes_panic_unwind_without_std_109: pass -> [missing] (J0)
  • errors::verify_passes_panic_unwind_without_std_110: [missing] -> pass (J0)
  • errors::verify_passes_proc_macro_bad_sig_155: pass -> [missing] (J0)
  • errors::verify_passes_proc_macro_bad_sig_156: [missing] -> pass (J0)
  • errors::verify_passes_repr_align_greater_than_target_max_77: [missing] -> pass (J0)
  • errors::verify_passes_repr_align_should_be_align_175: [missing] -> pass (J0)
  • errors::verify_passes_repr_conflicting_76: [missing] -> pass (J0)
  • errors::verify_passes_rustc_allow_const_fn_unstable_84: [missing] -> pass (J0)
  • errors::verify_passes_rustc_force_inline_coro_87: pass -> [missing] (J0)
  • errors::verify_passes_rustc_lint_opt_deny_field_access_105: [missing] -> pass (J0)
  • errors::verify_passes_rustc_lint_opt_ty_103: pass -> [missing] (J0)
  • errors::verify_passes_rustc_lint_opt_ty_104: [missing] -> pass (J0)
  • errors::verify_passes_rustc_std_internal_symbol_84: pass -> [missing] (J0)
  • errors::verify_passes_rustc_std_internal_symbol_85: [missing] -> pass (J0)
  • errors::verify_passes_stability_promotable_92: pass -> [missing] (J0)
  • errors::verify_passes_stability_promotable_93: [missing] -> pass (J0)
  • errors::verify_passes_trait_impl_const_stable_148: pass -> [missing] (J0)
  • errors::verify_passes_transparent_incompatible_142: [missing] -> pass (J0)
  • errors::verify_passes_unexportable_adt_with_private_fields_174: [missing] -> pass (J0)
  • errors::verify_passes_unexportable_fn_abi_170: [missing] -> pass (J0)
  • errors::verify_passes_unexportable_generic_fn_168: pass -> [missing] (J0)
  • errors::verify_passes_unexportable_generic_fn_169: [missing] -> pass (J0)
  • errors::verify_passes_unexportable_item_167: pass -> [missing] (J0)
  • errors::verify_passes_unexportable_item_168: [missing] -> pass (J0)
  • errors::verify_passes_unexportable_priv_item_173: [missing] -> pass (J0)
  • errors::verify_passes_unexportable_type_in_interface_171: pass -> [missing] (J0)
  • errors::verify_passes_unexportable_type_repr_171: [missing] -> pass (J0)
  • errors::verify_passes_unknown_external_lang_item_107: pass -> [missing] (J0)
  • errors::verify_passes_unknown_external_lang_item_108: [missing] -> pass (J0)
  • errors::verify_passes_unknown_feature_149: pass -> [missing] (J0)
  • errors::verify_passes_unknown_feature_alias_151: [missing] -> pass (J0)
  • errors::verify_passes_unknown_lang_item_115: [missing] -> pass (J0)
  • errors::verify_passes_unnecessary_partial_stable_feature_162: [missing] -> pass (J0)
  • errors::verify_passes_unnecessary_stable_feature_160: pass -> [missing] (J0)
  • errors::verify_passes_unnecessary_stable_feature_161: [missing] -> pass (J0)
  • errors::verify_passes_unrecognized_argument_125: pass -> [missing] (J0)
  • errors::verify_passes_unrecognized_argument_126: [missing] -> pass (J0)
  • errors::verify_passes_unsupported_attributes_in_where_167: [missing] -> pass (J0)
  • errors::verify_passes_unused_assign_passed_163: pass -> [missing] (J0)
  • errors::verify_passes_unused_assign_passed_164: [missing] -> pass (J0)
  • errors::verify_passes_unused_multiple_103: [missing] -> pass (J0)
  • errors::verify_passes_unused_var_assigned_only_160: [missing] -> pass (J0)
  • errors::verify_passes_used_static_78: pass -> [missing] (J0)
  • errors::verify_passes_useless_assignment_133: pass -> [missing] (J0)
  • errors::verify_passes_useless_stability_144: [missing] -> pass (J0)

(and 105 additional test diffs)

Additionally, 60 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard aa51a9b0948ff406958dca8dc74839a3009b7e5f --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-aarch64-linux: 5993.6s -> 8588.3s (43.3%)
  2. x86_64-apple-1: 7488.5s -> 5594.6s (-25.3%)
  3. dist-x86_64-apple: 6973.3s -> 8611.9s (23.5%)
  4. pr-check-2: 2700.9s -> 2186.8s (-19.0%)
  5. pr-check-1: 1862.3s -> 1509.5s (-18.9%)
  6. x86_64-rust-for-linux: 3023.7s -> 2541.7s (-15.9%)
  7. x86_64-apple-2: 5310.5s -> 4555.8s (-14.2%)
  8. arm-android: 6629.3s -> 5781.9s (-12.8%)
  9. x86_64-gnu-miri: 5312.2s -> 4659.3s (-12.3%)
  10. i686-gnu-1: 8518.4s -> 7540.2s (-11.5%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (aa51a9b): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
0.2% [0.1%, 0.3%] 3
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (primary 2.4%, secondary 3.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
2.4% [2.4%, 2.4%] 1
Regressions ❌
(secondary)
3.0% [2.8%, 3.4%] 3
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 2.4% [2.4%, 2.4%] 1

Cycles

Results (secondary 3.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
3.3% [2.9%, 3.7%] 2
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 463.324s -> 463.338s (0.00%)
Artifact size: 374.63 MiB -> 374.73 MiB (0.03%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-attributes Area: Attributes (`#[…]`, `#![…]`) A-compiletest Area: The compiletest test runner A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-meta Area: Issues & PRs about the rust-lang/rust repository itself A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. O-SGX Target: SGX rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)
Projects
None yet
Development

Successfully merging this pull request may close these issues.