implement Sum and Product for Saturating(u*) #144275

Qelxiros · 2025-07-22T01:05:08Z

@rustbot label +needs-fcp

rustbot · 2025-07-22T01:05:13Z

rustbot has assigned @tgross35.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

library/core/src/iter/traits/accum.rs

tgross35 · 2025-07-22T05:28:40Z

Could you add some tests to library/coretests/tests/iter/traits/accum.rs verifying the behavior?

@rustbot label +I-libs-api-nominated

Amanieu · 2025-07-22T16:37:03Z

FCP since this is insta-stable.

@rfcbot merge

library/core/src/iter/traits/accum.rs

rfcbot · 2025-07-22T17:17:35Z

Team member @Amanieu has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

library/core/src/iter/traits/accum.rs

rfcbot · 2025-08-05T13:11:18Z

🔔 This is now entering its final comment period, as per the review above. 🔔

rfcbot · 2025-08-15T13:21:13Z

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

This will be merged soon.

tgross35

r=me with one nit and a squash

Cc @joshtriplett, in rust-lang/libs-team#604 (comment) you said:

We can settle that question in the FCP that we'll need for the PR (which will be insta-stable). Meanwhile, please go ahead with a PR adding this for unsigned Saturating types, and mark it as needs-fcp. Thank you!

This wasn't explicitly mentioned on this thread (outside of the8472's docs request), so I'm just clarifying here that the current implementation does not short circuit (which seems reasonable).

View changes since this review

library/core/src/iter/traits/accum.rs

rustbot · 2025-08-28T22:43:05Z

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

tgross35 · 2025-08-28T22:54:36Z

Thank you!

@bors r+

bors · 2025-08-28T22:54:39Z

📌 Commit 1a33d62 has been approved by tgross35

It is now in the queue for this repository.

tgross35 · 2025-08-28T22:55:55Z

@bors rollup

Rollup of 9 pull requests Successful merges: - #143713 (Add a mailmap entry for gnzlbg) - #144275 (implement Sum and Product for Saturating(u*)) - #144354 (fix(std): Fix undefined reference to __my_thread_exit on QNX 8.0) - #145387 (Remove TmpLayout in layout_of_enum) - #145793 (std library: use execinfo library also on NetBSD.) - #145884 (Test `instrument-mcount` codegen) - #145947 (Add more to the `[workspace.dependencies]` section in the top-level `Cargo.toml`) - #145972 (fix `core::marker::Destruct` doc) - #145977 (tests: Ignore basic-stepping.rs on riscv64) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #144275 - Qelxiros:saturating-arithmetic, r=tgross35 implement Sum and Product for Saturating(u*) ACP: rust-lang/libs-team#604 `@rustbot` label +needs-fcp

jieyouxu · 2025-08-29T09:20:02Z

Already merged.
@bors r-

rustbot assigned tgross35 Jul 22, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. needs-fcp This change is insta-stable, or significant enough to need a team FCP to proceed. labels Jul 22, 2025

tgross35 reviewed Jul 22, 2025

View reviewed changes

library/core/src/iter/traits/accum.rs Outdated Show resolved Hide resolved

rustbot added the I-libs-api-nominated Nominated for discussion during a libs-api team meeting. label Jul 22, 2025

This comment was marked as outdated.

Sign in to view

rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Jul 22, 2025

Amanieu removed the I-libs-api-nominated Nominated for discussion during a libs-api team meeting. label Jul 22, 2025

the8472 reviewed Jul 22, 2025

View reviewed changes

library/core/src/iter/traits/accum.rs Show resolved Hide resolved

Amanieu added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. and removed T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jul 22, 2025

This comment was marked as outdated.

Sign in to view

rfcbot removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Jul 22, 2025

This comment was marked as outdated.

Sign in to view

rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Jul 22, 2025

m-ou-se reviewed Aug 5, 2025

View reviewed changes

library/core/src/iter/traits/accum.rs Outdated Show resolved Hide resolved

rfcbot added final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. labels Aug 5, 2025

This comment has been minimized.

Sign in to view

Qelxiros force-pushed the saturating-arithmetic branch from e37610c to d8d1462 Compare August 5, 2025 23:54

rustbot mentioned this pull request Aug 15, 2025

Tracking issue for release notes of #144275: implement Sum and Product for Saturating(u*) #145447

Open

apiraino removed the to-announce Announce this issue on triage meeting label Aug 28, 2025

tgross35 reviewed Aug 28, 2025

View reviewed changes

library/core/src/iter/traits/accum.rs Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

implement Sum and Product for Saturating(u*)

1a33d62

This comment has been minimized.

Sign in to view

Qelxiros force-pushed the saturating-arithmetic branch from 209c296 to 1a33d62 Compare August 28, 2025 22:43

tgross35 approved these changes Aug 28, 2025

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 28, 2025

Zalathar mentioned this pull request Aug 29, 2025

Rollup of 9 pull requests #145978

Merged

bors merged commit ef50370 into rust-lang:master Aug 29, 2025
10 checks passed

rustbot added this to the 1.91.0 milestone Aug 29, 2025

rust-timer added a commit that referenced this pull request Aug 29, 2025

Unrolled build for #144275

0492ebe

Rollup merge of #144275 - Qelxiros:saturating-arithmetic, r=tgross35 implement Sum and Product for Saturating(u*) ACP: rust-lang/libs-team#604 `@rustbot` label +needs-fcp

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 29, 2025

implement Sum and Product for Saturating(u*) #144275

implement Sum and Product for Saturating(u*) #144275

Conversation

Qelxiros commented Jul 22, 2025

Uh oh!

rustbot commented Jul 22, 2025

Uh oh!

Uh oh!

tgross35 commented Jul 22, 2025

Uh oh!

Amanieu commented Jul 22, 2025

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

rfcbot commented Jul 22, 2025 • edited by m-ou-se Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

rfcbot commented Aug 5, 2025

Uh oh!

This comment has been minimized.

rfcbot commented Aug 15, 2025

Uh oh!

tgross35 left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

rustbot commented Aug 28, 2025

Uh oh!

tgross35 commented Aug 28, 2025

Uh oh!

bors commented Aug 28, 2025

Uh oh!

tgross35 commented Aug 28, 2025

Uh oh!

Uh oh!

jieyouxu commented Aug 29, 2025

Uh oh!

Uh oh!

rfcbot commented Jul 22, 2025 •

edited by m-ou-se

Loading

tgross35 left a comment •

edited by rustbot

Loading