Skip to content

Conversation

he32
Copy link
Contributor

@he32 he32 commented Aug 23, 2025

The execinfo library is also available on NetBSD.

@rustbot
Copy link
Collaborator

rustbot commented Aug 23, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added O-unix Operating system: Unix-like S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Aug 23, 2025
@@ -382,6 +382,7 @@ cfg_select! {
unsafe extern "C" {}
}
target_os = "netbsd" => {
#[link(name = "execinfo")]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it a base part of the NetBSD distribution?

Copy link
Contributor Author

@he32 he32 Aug 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, execinfo has been part of NetBSD since version 7.0 as far as I can see, and 7.0 was released many moons (or years) ago. We've branched 11.0, and 9.0 is about to be de-supported when 11.0 is released in terms of support for third-party packages via pkgsrc. Trying to build rust for anything older than 9.0 is most probably not going to work (too old in-tree gcc, for starters) -- today doing so for 9.0 is even sometimes a struggle.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed part of NetBSD since 7.0 (2021).

@Mark-Simulacrum
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Aug 28, 2025

📌 Commit db4e716 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 28, 2025
bors added a commit that referenced this pull request Aug 29, 2025
Rollup of 9 pull requests

Successful merges:

 - #143713 (Add a mailmap entry for gnzlbg)
 - #144275 (implement Sum and Product for Saturating(u*))
 - #144354 (fix(std): Fix undefined reference to __my_thread_exit on QNX 8.0)
 - #145387 (Remove TmpLayout in layout_of_enum)
 - #145793 (std library: use execinfo library also on NetBSD.)
 - #145884 (Test `instrument-mcount` codegen)
 - #145947 (Add more to the `[workspace.dependencies]` section in the top-level `Cargo.toml`)
 - #145972 (fix `core::marker::Destruct` doc)
 - #145977 (tests: Ignore basic-stepping.rs on riscv64)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 4b0933a into rust-lang:master Aug 29, 2025
10 checks passed
@rustbot rustbot added this to the 1.91.0 milestone Aug 29, 2025
rust-timer added a commit that referenced this pull request Aug 29, 2025
Rollup merge of #145793 - he32:netbsd-libexecinfo-fix, r=Mark-Simulacrum

std library: use execinfo library also on NetBSD.

The execinfo library is also available on NetBSD.
@jieyouxu
Copy link
Member

Already merged.
@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-unix Operating system: Unix-like S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants