-
Notifications
You must be signed in to change notification settings - Fork 13.7k
std library: use execinfo library also on NetBSD. #145793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
rustbot has assigned @Mark-Simulacrum. Use |
@@ -382,6 +382,7 @@ cfg_select! { | |||
unsafe extern "C" {} | |||
} | |||
target_os = "netbsd" => { | |||
#[link(name = "execinfo")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it a base part of the NetBSD distribution?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, execinfo has been part of NetBSD since version 7.0 as far as I can see, and 7.0 was released many moons (or years) ago. We've branched 11.0, and 9.0 is about to be de-supported when 11.0 is released in terms of support for third-party packages via pkgsrc. Trying to build rust for anything older than 9.0 is most probably not going to work (too old in-tree gcc, for starters) -- today doing so for 9.0 is even sometimes a struggle.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed part of NetBSD since 7.0 (2021).
@bors r+ |
Rollup of 9 pull requests Successful merges: - #143713 (Add a mailmap entry for gnzlbg) - #144275 (implement Sum and Product for Saturating(u*)) - #144354 (fix(std): Fix undefined reference to __my_thread_exit on QNX 8.0) - #145387 (Remove TmpLayout in layout_of_enum) - #145793 (std library: use execinfo library also on NetBSD.) - #145884 (Test `instrument-mcount` codegen) - #145947 (Add more to the `[workspace.dependencies]` section in the top-level `Cargo.toml`) - #145972 (fix `core::marker::Destruct` doc) - #145977 (tests: Ignore basic-stepping.rs on riscv64) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of #145793 - he32:netbsd-libexecinfo-fix, r=Mark-Simulacrum std library: use execinfo library also on NetBSD. The execinfo library is also available on NetBSD.
Already merged. |
The execinfo library is also available on NetBSD.