-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove some pub use
glob usage
#14509
Conversation
This does not appear to remove support from resolve itself, so can you leave the tests that exercise the functionality of a pub use glob? As long as it's a feature of the language, it needs to continue to be tested. |
Done. ( |
Fixed previous commits, and add two more commits which completely remove |
I'm fine with this, as they were always somewhat broken. I think we should reintroduce them in a working state, if we ever do. Half-broken features don't really befit us going forward. |
I find this change not going through the RFC process to be distressing. I have many use cases of this feature which I consider valid, which I outlined in the referenced issue. @nikomatsakis suggested that he had some ideas to fix this... were they shelved? Did he run out of time for them? |
`quote_expr!` now injects two more (priv) `use` globs. This may cause extra unused_imports warning.
@SiegeLord I'm ok if pub globs are properly fixed later. I just assumed #11870 is "accepted" but maybe not? |
to be clear, this PR just removes uses of |
This patchset removes `pub use` usage except for `test/`. cc #11870
@nikomatsakis yep. |
internal: Resolve labels in body lowering Fixes rust-lang/rust-analyzer#14503 (comment)
This patchset removes
pub use
usage except fortest/
.cc #11870