Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some pub use glob usage #14509

Merged
merged 2 commits into from
Jun 2, 2014
Merged

Conversation

klutzy
Copy link
Contributor

@klutzy klutzy commented May 29, 2014

This patchset removes pub use usage except for test/.
cc #11870

@alexcrichton
Copy link
Member

This does not appear to remove support from resolve itself, so can you leave the tests that exercise the functionality of a pub use glob? As long as it's a feature of the language, it needs to continue to be tested.

@klutzy
Copy link
Contributor Author

klutzy commented May 29, 2014

Done. (due to quasiquoter, removing pub use glob from language is possible after new snapshot.)

@klutzy klutzy changed the title Remove all use of pub use globs Remove pub use globs May 30, 2014
@klutzy
Copy link
Contributor Author

klutzy commented May 30, 2014

Fixed previous commits, and add two more commits which completely remove pub use glob from syntax.

@pcwalton
Copy link
Contributor

I'm fine with this, as they were always somewhat broken. I think we should reintroduce them in a working state, if we ever do. Half-broken features don't really befit us going forward.

@SiegeLord
Copy link
Contributor

I find this change not going through the RFC process to be distressing. I have many use cases of this feature which I consider valid, which I outlined in the referenced issue. @nikomatsakis suggested that he had some ideas to fix this... were they shelved? Did he run out of time for them?

klutzy added 2 commits June 2, 2014 23:21
`quote_expr!` now injects two more (priv) `use` globs.
This may cause extra unused_imports warning.
@klutzy
Copy link
Contributor Author

klutzy commented Jun 2, 2014

@SiegeLord I'm ok if pub globs are properly fixed later. I just assumed #11870 is "accepted" but maybe not?
I dropped two extra commits (fortunately they are rather trivial).

@klutzy klutzy changed the title Remove pub use globs Remove some pub use glob usage Jun 2, 2014
@nikomatsakis
Copy link
Contributor

to be clear, this PR just removes uses of pub use globs, right?

bors added a commit that referenced this pull request Jun 2, 2014
This patchset removes `pub use` usage except for `test/`.
cc #11870
@bors bors closed this Jun 2, 2014
@bors bors merged commit 976c832 into rust-lang:master Jun 2, 2014
@klutzy
Copy link
Contributor Author

klutzy commented Jun 3, 2014

@nikomatsakis yep.

@klutzy klutzy deleted the de-pub-use-glob branch June 3, 2014 03:06
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants