Skip to content

Conversation

Kobzol
Copy link
Member

@Kobzol Kobzol commented Aug 26, 2025

It is not shipped with host tools, so it was located in the wrong group. The musl target is here - no host tools.

Noticed in rust-lang/docker-rust#247.

…ier 2

It is not shipped with host tools, so it was located in the wrong group.
@rustbot
Copy link
Collaborator

rustbot commented Aug 26, 2025

r? @nnethercote

rustbot has assigned @nnethercote.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 26, 2025
@Kobzol
Copy link
Member Author

Kobzol commented Aug 26, 2025

r? @marcoieni

@rustbot rustbot assigned marcoieni and unassigned nnethercote Aug 26, 2025
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that looks correct.

View changes since this review

@jieyouxu
Copy link
Member

FYI @Amanieu @kraj: if this target was intended to have host tools, that can be fixed and we can move the target back to Tier 2 w/ host tools. For now though, let's update the docs to reflect its actual status.

r? jieyouxu @bors r+ rollup

@bors
Copy link
Collaborator

bors commented Aug 27, 2025

📌 Commit f27e0c1 has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 27, 2025
@jieyouxu jieyouxu added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Aug 27, 2025
@kraj
Copy link
Contributor

kraj commented Aug 27, 2025

FYI @Amanieu @kraj: if this target was intended to have host tools, that can be fixed and we can move the target back to Tier 2 w/ host tools. For now though, let's update the docs to reflect its actual status.

r? jieyouxu @bors r+ rollup

yes , it would be good to have it meet tier-2 requirements.

bors added a commit that referenced this pull request Aug 27, 2025
Rollup of 6 pull requests

Successful merges:

 - #142215 (Use -Zmir-opt-level=0 in tests for MIR building)
 - #143341 (Mention that casting to *const () is a way to roundtrip with from_raw_parts)
 - #145078 (Fix wrong cache line size of riscv64)
 - #145290 (Improve std::fs::read_dir docs)
 - #145335 (Move WTF-8 code from std into core and alloc)
 - #145904 (Move `riscv64-gc-unknown-linux-musl` from Tier 2 with Host tools to Tier 2)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 5fdc840 into rust-lang:master Aug 27, 2025
10 checks passed
rust-timer added a commit that referenced this pull request Aug 27, 2025
Rollup merge of #145904 - Kobzol:riscv-musl-platform-support, r=jieyouxu

Move `riscv64-gc-unknown-linux-musl` from Tier 2 with Host tools to Tier 2

It is not shipped with host tools, so it was located in the wrong group. The musl target is [here](https://github.com/rust-lang/rust/blob/467c89cd0b1c579edc247808c35941677918d29d/src/ci/docker/host-x86_64/dist-various-2/Dockerfile#L126) - no host tools.

Noticed in rust-lang/docker-rust#247.
@rustbot rustbot added this to the 1.91.0 milestone Aug 27, 2025
@Kobzol Kobzol deleted the riscv-musl-platform-support branch August 27, 2025 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants