Skip to content

Stop calling unwrap when format foreign has trailing dollar #145905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 27, 2025
Merged

Stop calling unwrap when format foreign has trailing dollar #145905

merged 2 commits into from
Aug 27, 2025

Conversation

TaKO8Ki
Copy link
Member

@TaKO8Ki TaKO8Ki commented Aug 26, 2025 •
edited by rustbot
Loading

Fixes #137580

@rustbot
Copy link
Collaborator

rustbot commented Aug 26, 2025

r? @nnethercote

rustbot has assigned @nnethercote.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 26, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
nnethercote
nnethercote reviewed Aug 26, 2025
View reviewed changes
tests/ui/macros/format-foreign-dollar-without-spec.rs
@@ -0,0 +1,4 @@
fn main() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a comment here saying that this was issue #137580, then remove the old crashtest, and then r=me.

@rustbot
Copy link
Collaborator

rustbot commented Aug 27, 2025

This PR changes a file inside tests/crashes. If a crash was fixed, please move into the corresponding ui subdir and add 'Fixes #' to the PR description to autoclose the issue upon merge.

@TaKO8Ki
Copy link
Member Author

TaKO8Ki commented Aug 27, 2025

@bors r=nnethercote

@bors
Copy link
Collaborator

bors commented Aug 27, 2025

📌 Commit 2c361f8 has been approved by nnethercote

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 27, 2025
@matthiaskrgr matthiaskrgr mentioned this pull request Aug 27, 2025
Merged
bors added a commit that referenced this pull request Aug 27, 2025
@bors
Auto merge of #145923 - matthiaskrgr:rollup-rkejtos, r=matthiaskrgr
3c91be7 
Rollup of 6 pull requests

Successful merges:

 - #144274 (add Option::reduce)
 - #145562 (Simplify macro generating ToString implementations for `&…&str`)
 - #145625 (improve float to_degrees/to_radians rounding comments and impl)
 - #145740 (Introduce a `[workspace.dependencies`] section in the top-level `Cargo.toml`)
 - #145885 (Inherit TCC in debuginfo tests on macOS)
 - #145905 (Stop calling unwrap when format foreign has trailing dollar)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit bd90013 into rust-lang:master Aug 27, 2025
10 checks passed
rust-timer added a commit that referenced this pull request Aug 27, 2025
@rust-timer
Unrolled build for #145905
c4eb60c 
Rollup merge of #145905 - TaKO8Ki:fix-137580, r=nnethercote

Stop calling unwrap when format foreign has trailing dollar

Fixes #137580
@rustbot rustbot added this to the 1.91.0 milestone Aug 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nnethercote nnethercote nnethercote left review comments

Assignees

@nnethercote nnethercote

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.91.0
Development

Successfully merging this pull request may close these issues.

ICE: called Result::unwrap() on an Err value: ParseIntError { kind: PosOverflow } in rustc_builtin_macros/src/format_foreign.rs
5 participants
@TaKO8Ki @rustbot @rust-log-analyzer @bors @nnethercote