Rollup of 6 pull requests #145923

matthiaskrgr · 2025-08-27T09:26:53Z

Successful merges:

add Option::reduce #144274 (add Option::reduce)
Simplify macro generating ToString implementations for &…&str #145562 (Simplify macro generating ToString implementations for &…&str)
improve float to_degrees/to_radians rounding comments and impl #145625 (improve float to_degrees/to_radians rounding comments and impl)
Introduce a [workspace.dependencies] section in the top-level Cargo.toml #145740 (Introduce a [workspace.dependencies] section in the top-level Cargo.toml)
Inherit TCC in debuginfo tests on macOS #145885 (Inherit TCC in debuginfo tests on macOS)
Stop calling unwrap when format foreign has trailing dollar #145905 (Stop calling unwrap when format foreign has trailing dollar)

r? @ghost
@rustbot modify labels: rollup

Use deref coercion to let the compiler remove any amount of references.

* revise comments explaining why we are using literal or expression * add unspecified precision comments as we don't guarantee precision * use expression in `f128::to_degrees()` * make `f64::to_degrees()` impl consistent with other functions

add Option::reduce Tracking issue: rust-lang#144273

…=tgross35 Simplify macro generating ToString implementations for `&…&str` Use deref coercion to let the compiler remove any amount of references. Also use that macro for `Cow` and `String`.

…iteral, r=beetrees,tgross35 improve float to_degrees/to_radians rounding comments and impl This PR makes `to_degrees()` and `to_radians()` float functions more consistent between each other and improves comments around their precision and rounding. * revise comments explaining why we are using literal or expression * add unspecified precision comments as we don't guarantee precision * use expression in `f128::to_degrees()` * make `f64::to_degrees()` impl consistent with other functions r? `@tgross35`

…obzol Introduce a `[workspace.dependencies`] section in the top-level `Cargo.toml` It lets us avoid a lot of repetition of crate versions, etc. I've just done a few as a start. Many more can be done in follow-ups. r? `@Kobzol`

Inherit TCC in debuginfo tests on macOS macOS has a system for propagating folder permissions, which LLDB disables when spawning processes, which in turn causes debuginfo tests to spam the user with repeated pop-ups asking for permissions. See the code comment for details, as well as the following video for an example of how this looks in practice: https://github.com/user-attachments/assets/1e54f5b8-9130-4b59-8e92-1db1e58fb361 I stumbled upon the incantation to fix this (`settings set target.inherit-tcc true`) while investigating slowdowns when spawning newly created binaries due to XprotectService, see [this Zulip thread](https://rust-lang.zulipchat.com/#narrow/channel/246057-t-cargo/topic/build.20scripts.20slow.20on.20macOS.3F). This would allow me to no longer have a `build.build-dir = "/Users/madsmtm/rust-build"` workaround in my `bootstrap.toml`.

Stop calling unwrap when format foreign has trailing dollar Fixes rust-lang#137580

matthiaskrgr · 2025-08-27T09:27:05Z

@bors r+ rollup=never p=5

bors · 2025-08-27T09:27:07Z

📌 Commit bd90013 has been approved by matthiaskrgr

It is now in the queue for this repository.

bors · 2025-08-27T12:35:25Z

⌛ Testing commit bd90013 with merge 3c91be7...

bors · 2025-08-27T15:40:38Z

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing 3c91be7 to master...

github-actions · 2025-08-27T15:43:35Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing b2dd217 (parent) -> 3c91be7 (this PR)

Test differences

Show 333 test diffs

Stage 1

[crashes] tests/crashes/137580.rs: pass -> [missing] (J1)
[ui] tests/ui/macros/format-foreign-dollar-without-spec.rs: [missing] -> pass (J1)

Stage 2

[crashes] tests/crashes/137580.rs: pass -> [missing] (J0)
[ui] tests/ui/macros/format-foreign-dollar-without-spec.rs: [missing] -> pass (J2)

Additionally, 329 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 3c91be712d3d84f6345cd22eae34c47b3a22a3d3 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

aarch64-apple: 5039.7s -> 6333.6s (25.7%)
dist-aarch64-apple: 5817.1s -> 6972.0s (19.9%)
aarch64-msvc-1: 6734.2s -> 7832.7s (16.3%)
aarch64-gnu-debug: 4806.5s -> 4112.8s (-14.4%)
x86_64-rust-for-linux: 2938.2s -> 2569.4s (-12.6%)
pr-check-1: 1566.8s -> 1404.5s (-10.4%)
x86_64-gnu-llvm-19: 2770.9s -> 2504.9s (-9.6%)
i686-msvc-2: 8490.5s -> 7791.0s (-8.2%)
x86_64-gnu-llvm-19-1: 3626.4s -> 3328.4s (-8.2%)
x86_64-gnu-llvm-20-1: 3540.0s -> 3258.9s (-7.9%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2025-08-27T16:51:03Z

Finished benchmarking commit (3c91be7): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary -1.6%, secondary 4.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.6%	[2.6%, 2.6%]	1
Regressions ❌ (secondary)	4.1%	[1.6%, 5.5%]	6
Improvements ✅ (primary)	-5.8%	[-5.8%, -5.8%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-1.6%	[-5.8%, 2.6%]	2

Cycles

Results (primary -2.9%, secondary -2.7%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.1%	[2.1%, 2.1%]	1
Improvements ✅ (primary)	-2.9%	[-2.9%, -2.9%]	1
Improvements ✅ (secondary)	-3.4%	[-4.6%, -2.1%]	6
All ❌✅ (primary)	-2.9%	[-2.9%, -2.9%]	1

Binary size

Results (primary -0.1%, secondary -0.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	0.0%	[0.0%, 0.0%]	3
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.1%	[-0.2%, -0.0%]	4
Improvements ✅ (secondary)	-0.0%	[-0.0%, -0.0%]	1
All ❌✅ (primary)	-0.1%	[-0.2%, 0.0%]	7

Bootstrap: 468.683s -> 468.329s (-0.08%)
Artifact size: 391.17 MiB -> 391.15 MiB (-0.01%)

Qelxiros and others added 19 commits July 31, 2025 23:46

add Option::reduce

613080b

Simplify macro generating ToString implementations for &…&str

6a24ae9

Use deref coercion to let the compiler remove any amount of references.

Use ToString specialization macro also for Cow and String

cb5a4d1

Inherit TCC in debuginfo tests on macOS

a898f76

stop returning errors when format foreign has trailing dollar

adddae6

Add thin-vec to newly added [workspace.dependencies].

777e2d6

Add bitflags to [workspace.dependencies].

82c4b9c

Add memchr to [workspace.dependencies].

dfa748e

Add rustc-literal-escaper to [workspace.dependencies].

32b0fff

Add tracing to [workspace.dependencies].

c50d2cc

Add itertools to [workspace.dependencies].

200f56d

remove old crash test

2c361f8

Rollup merge of rust-lang#144274 - Qelxiros:option-reduce, r=tgross35

1e90922

add Option::reduce Tracking issue: rust-lang#144273

Rollup merge of rust-lang#145562 - tbu-:pr_simplify_to_string_spec, r…

f2eb47a

…=tgross35 Simplify macro generating ToString implementations for `&…&str` Use deref coercion to let the compiler remove any amount of references. Also use that macro for `Cow` and `String`.

Rollup merge of rust-lang#145905 - TaKO8Ki:fix-137580, r=nnethercote

bd90013

Stop calling unwrap when format foreign has trailing dollar Fixes rust-lang#137580

rustbot added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) rollup A PR which is a rollup labels Aug 27, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 27, 2025

bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 27, 2025

bors merged commit 3c91be7 into rust-lang:master Aug 27, 2025
11 checks passed

rustbot added this to the 1.91.0 milestone Aug 27, 2025

This was referenced Aug 27, 2025

eagerly compute sub_relations again #140375

Open

[TOY] Extend GVN to perform local value numbering. #143333

Draft

This was referenced Aug 27, 2025

Update to ar_archive_writer 0.5 #145721

Merged

GVN: stop hashing opaque values #145737

Draft

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 6 pull requests #145923

Rollup of 6 pull requests #145923

Uh oh!

matthiaskrgr commented Aug 27, 2025 •

edited by rustbot

Loading

Uh oh!

matthiaskrgr commented Aug 27, 2025

Uh oh!

bors commented Aug 27, 2025

Uh oh!

bors commented Aug 27, 2025

Uh oh!

bors commented Aug 27, 2025

Uh oh!

Uh oh!

github-actions bot commented Aug 27, 2025

Stage 1

Stage 2

Uh oh!

rust-timer commented Aug 27, 2025

Uh oh!

Uh oh!

Rollup of 6 pull requests #145923

Rollup of 6 pull requests #145923

Uh oh!

Conversation

matthiaskrgr commented Aug 27, 2025 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

matthiaskrgr commented Aug 27, 2025

Uh oh!

bors commented Aug 27, 2025

Uh oh!

bors commented Aug 27, 2025

Uh oh!

bors commented Aug 27, 2025

Uh oh!

Uh oh!

github-actions bot commented Aug 27, 2025

Test differences

Stage 1

Stage 2

Job duration changes

Uh oh!

rust-timer commented Aug 27, 2025

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Uh oh!

matthiaskrgr commented Aug 27, 2025 •

edited by rustbot

Loading