Skip to content

fixes auto-run js checks in tidy #146151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 4, 2025
Merged

fixes auto-run js checks in tidy #146151

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fee5cd1
fixes auto-run js checks in tidy
FrancescoV1985 Sep 3, 2025
858414b
improved solution for function is_non_auto_or_matches
FrancescoV1985 Sep 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 13 additions & 13 deletions src/tools/tidy/src/extra_checks/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -720,21 +720,21 @@ impl ExtraCheckArg {
if !self.auto {
return true;
}
let ext = match self.lang {
ExtraCheckLang::Py => ".py",
ExtraCheckLang::Cpp => ".cpp",
ExtraCheckLang::Shell => ".sh",
ExtraCheckLang::Js => ".js",
match self.lang {
ExtraCheckLang::Spellcheck => {
for dir in SPELLCHECK_DIRS {
if Path::new(filepath).starts_with(dir) {
return true;
}
}
return false;
SPELLCHECK_DIRS.iter().any(|dir| Path::new(filepath).starts_with(dir))
}
};
filepath.ends_with(ext)
lang => {
let exts: &[&str] = match lang {
ExtraCheckLang::Py => &[".py"],
ExtraCheckLang::Cpp => &[".cpp"],
ExtraCheckLang::Shell => &[".sh"],
ExtraCheckLang::Js => &[".js", ".ts"],
ExtraCheckLang::Spellcheck => unreachable!(),
};
exts.iter().any(|ext| filepath.ends_with(ext))
}
}
}

fn has_supported_kind(&self) -> bool {
Expand Down
Loading