Skip to content

Conversation

FrancescoV1985
Copy link
Contributor

Modified is_non_auto_or_matches function in src/tools/tidy/src/extra_checks/mod.rs so that .ts extension is considered.
Tested locally with
./x.py test tidy --extra-checks=auto:js

@rustbot
Copy link
Collaborator

rustbot commented Sep 3, 2025

r? @Kobzol

rustbot has assigned @Kobzol.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-tidy Area: The tidy tool S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Sep 3, 2025
@rustbot
Copy link
Collaborator

rustbot commented Sep 3, 2025

tidy extra checks were modified.

cc @lolbinarycat

@Kobzol
Copy link
Member

Kobzol commented Sep 3, 2025

Hi, I'm not aware of any .ts files (that do not come from subtrees/submodules) that we have in the repo, can you point me to them if you found some?

@FrancescoV1985
Copy link
Contributor Author

FrancescoV1985 commented Sep 3, 2025

Hello @Kobzol. In my case, I deliberately (temporary) modified .ts files (e.g. ./src/tools/rust-analyzer/editors/code/src/lang_client.ts) under the repo, as I do not see alternatives...

@Kobzol
Copy link
Member

Kobzol commented Sep 3, 2025

Right, but the files under rust-analyzer and rustc-perf are not managed by this repository, and we thus shouldn't make any changes to them (in fact they are ignored by tidy). So until we actually have some TypeScript files in this repo, I don't think this is needed, tbh 😅

@FrancescoV1985
Copy link
Contributor Author

FrancescoV1985 commented Sep 3, 2025

Right, but the files under rust-analyzer and rustc-perf are not managed by this repository, and we thus shouldn't make any changes to them (in fact they are ignored by tidy). So until we actually have some TypeScript files in this repo, I don't think this is needed, tbh 😅

I understand your point..

@fmease
Copy link
Member

fmease commented Sep 3, 2025

We have https://github.com/rust-lang/rust/blob/master/src/librustdoc/html/static/js/rustdoc.d.ts

@Kobzol
Copy link
Member

Kobzol commented Sep 3, 2025

Ok, fair enough!

@Kobzol
Copy link
Member

Kobzol commented Sep 4, 2025

Thanks!

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Sep 4, 2025

📌 Commit 858414b has been approved by Kobzol

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 4, 2025
bors added a commit that referenced this pull request Sep 4, 2025
Rollup of 4 pull requests

Successful merges:

 - #145976 (Add bootstrap.toml option to control debug breaking on ICEs on windows)
 - #146151 (fixes auto-run js checks in tidy)
 - #146194 (fix path str eq)
 - #146197 (triagebot: fix rustc_allow_const_fn_unstable matcher)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit bdfa97b into rust-lang:master Sep 4, 2025
10 checks passed
@rustbot rustbot added this to the 1.91.0 milestone Sep 4, 2025
rust-timer added a commit that referenced this pull request Sep 4, 2025
Rollup merge of #146151 - FrancescoV1985:issue-146047-fix, r=Kobzol

fixes auto-run js checks in tidy

Modified is_non_auto_or_matches function in src/tools/tidy/src/extra_checks/mod.rs so that .ts extension is considered.
Tested locally with
`./x.py test tidy --extra-checks=auto:js`
@FrancescoV1985
Copy link
Contributor Author

Fixes #146047

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-tidy Area: The tidy tool S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants