Skip to content

Conversation

RalfJung
Copy link
Member

@RalfJung RalfJung commented Sep 4, 2025

The attribute is used like #[rustc_allow_const_fn_unstable(const_precise_live_drops)] so we can't have the final ] here...

r? @Urgau

@rustbot rustbot added A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 4, 2025
@rustbot
Copy link
Collaborator

rustbot commented Sep 4, 2025

#[rustc_allow_const_fn_unstable] needs careful audit to avoid accidentally exposing unstable
implementation details on stable.

cc @rust-lang/wg-const-eval

triagebot.toml has been modified, there may have been changes to the review queue.

cc @davidtwco, @wesleywiser

@Urgau
Copy link
Member

Urgau commented Sep 4, 2025

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Sep 4, 2025

📌 Commit 9c6c5df has been approved by Urgau

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 4, 2025
@RalfJung
Copy link
Member Author

RalfJung commented Sep 4, 2025

#[rustc_allow_const_fn_unstable] needs careful audit to avoid accidentally exposing unstable
implementation details on stable.

Seems like the mention also kicks in when the substring is removed... that should probably not happen?

bors added a commit that referenced this pull request Sep 4, 2025
Rollup of 4 pull requests

Successful merges:

 - #145976 (Add bootstrap.toml option to control debug breaking on ICEs on windows)
 - #146151 (fixes auto-run js checks in tidy)
 - #146194 (fix path str eq)
 - #146197 (triagebot: fix rustc_allow_const_fn_unstable matcher)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit a038e28 into rust-lang:master Sep 4, 2025
10 checks passed
rust-timer added a commit that referenced this pull request Sep 4, 2025
Rollup merge of #146197 - RalfJung:triagebot-rustc_allow_const_fn_unstable, r=Urgau

triagebot: fix rustc_allow_const_fn_unstable matcher

The attribute is used like `#[rustc_allow_const_fn_unstable(const_precise_live_drops)]` so we can't have the final `]` here...

r? `@Urgau`
@rustbot rustbot added this to the 1.91.0 milestone Sep 4, 2025
@RalfJung RalfJung deleted the triagebot-rustc_allow_const_fn_unstable branch September 5, 2025 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants