Skip to content

sort array trait implementation suggestions correctly #146403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 13, 2025
Merged

sort array trait implementation suggestions correctly #146403

merged 1 commit into from
Sep 13, 2025

Conversation

@cyrgani
Copy link
Contributor

@cyrgani cyrgani commented Sep 10, 2025 •
edited by rustbot
Loading

Fixes #135098.
Previously tried in #137428.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 10, 2025
@rustbot
Copy link
Collaborator

rustbot commented Sep 10, 2025

r? @fee1-dead

rustbot has assigned @fee1-dead.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

fee1-dead
fee1-dead reviewed Sep 11, 2025
View reviewed changes
@fee1-dead
Copy link
Member

Thanks!

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Sep 12, 2025

📌 Commit 889be78 has been approved by fee1-dead

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 12, 2025
@jdonszelmann jdonszelmann mentioned this pull request Sep 13, 2025
Merged
bors added a commit that referenced this pull request Sep 13, 2025
@bors
Auto merge of #146494 - jdonszelmann:rollup-0bbwwwf, r=jdonszelmann
9642c0e 
Rollup of 5 pull requests

Successful merges:

 - #146389 (Convert `no_std` and `no_core` to the new attribute infrastructure)
 - #146403 (sort array trait implementation suggestions correctly)
 - #146452 (Improve `alloc::Layout` coverage)
 - #146477 (Improve `core::char` coverage)
 - #146481 (Improve `core::hash` coverage)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 5dd5264 into rust-lang:master Sep 13, 2025
10 checks passed
@rustbot rustbot added this to the 1.91.0 milestone Sep 13, 2025
rust-timer added a commit that referenced this pull request Sep 13, 2025
@rust-timer
Unrolled build for #146403
14df853 
Rollup merge of #146403 - cyrgani:array-sugg-sorting, r=fee1-dead

sort array trait implementation suggestions correctly

Fixes #135098.
Previously tried in #137428.
@cyrgani cyrgani deleted the array-sugg-sorting branch September 13, 2025 07:32
@github-actions github-actions bot mentioned this pull request Sep 12, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fee1-dead fee1-dead fee1-dead left review comments

Assignees

@fee1-dead fee1-dead

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.91.0

Development

Successfully merging this pull request may close these issues.

List of trait implementations should be version-sorted

4 participants

@cyrgani @rustbot @fee1-dead @bors