Skip to content

Conversation

pvdrz
Copy link
Contributor

@pvdrz pvdrz commented Sep 12, 2025

This PR improves the core::char coverage by adding new tests to coretests

r? @workingjubilee

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Sep 12, 2025
@rustbot
Copy link
Collaborator

rustbot commented Sep 12, 2025

workingjubilee is currently at their maximum review capacity.
They may take a while to respond.

@workingjubilee
Copy link
Member

🙏 I know that I reviewed a couple PRs opportunistically, but I am still working on clearing my queue and even evaluating whether a PR is simple enough to "just glance at and r+" can be a tad costly.

r? libs

@rustbot rustbot assigned tgross35 and unassigned workingjubilee Sep 12, 2025
@Noratrieb
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Sep 12, 2025

📌 Commit 51e3b62 has been approved by Noratrieb

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 12, 2025
jdonszelmann added a commit to jdonszelmann/rust that referenced this pull request Sep 12, 2025
…age, r=Noratrieb

Improve `core::char` coverage

This PR improves the `core::char` coverage by adding new tests to `coretests`

r? `@workingjubilee`
bors added a commit that referenced this pull request Sep 12, 2025
Rollup of 4 pull requests

Successful merges:

 - #146389 (Convert `no_std` and `no_core` to the new attribute infrastructure)
 - #146452 (Improve `alloc::Layout` coverage)
 - #146473 (Revert "Constify SystemTime methods")
 - #146477 (Improve `core::char` coverage)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit that referenced this pull request Sep 13, 2025
Rollup of 5 pull requests

Successful merges:

 - #146389 (Convert `no_std` and `no_core` to the new attribute infrastructure)
 - #146403 (sort array trait implementation suggestions correctly)
 - #146452 (Improve `alloc::Layout` coverage)
 - #146477 (Improve `core::char` coverage)
 - #146481 (Improve `core::hash` coverage)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 7928be0 into rust-lang:master Sep 13, 2025
10 checks passed
@rustbot rustbot added this to the 1.91.0 milestone Sep 13, 2025
rust-timer added a commit that referenced this pull request Sep 13, 2025
Rollup merge of #146477 - ferrocene:pvdrz/improve-char-coverage, r=Noratrieb

Improve `core::char` coverage

This PR improves the `core::char` coverage by adding new tests to `coretests`

r? ``@workingjubilee``
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants