Rolling up PRs in the queue #14712
Closed
Rolling up PRs in the queue #14712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that rustdoc can properly document inlined traits across crates. Closes rust-lang#14670
Division and remainder by 0 are undefined behavior, and are detected at runtime. This commit adds support for ensuring that MIN / -1 is also checked for at runtime, as this would cause signed overflow, or undefined behvaior. Closes rust-lang#8460
LLDB contains a bug that makes it crash if an archive it reads contains a file the name of which is exactly 16 bytes long. This bug recently has made it impossible to debug Rust applications with LLDB because some standard libraries triggered it indirectly: For rlibs, rustc includes the LLVM bytecode in the archive, giving it the extension ".bc.deflate". For liballoc (for example) this results in the 16 character filename "alloc.bc.deflate", which is bad. This commit replaces the ".bc.deflate" suffix with ".bytecode.deflate" which itself is already longer than 16 bytes, thus making sure that the bug won't be run into anymore. The bug could still be run into with 14 character filenames because then the .o files will trigger it. However, this is much more rare and working around it would introduce more complexity than necessary at the moment. It can always be done later on, if the need arises. Fixes rust-lang#14356.
In addition to avoiding 16-byte filenames with bytecode files, this commit also avoids 16-byte filenames with object files pulled in from native libraries.
This commit carries out the request from issue rust-lang#14678: > The method `Iterator::len()` is surprising, as all the other uses of > `len()` do not consume the value. `len()` would make more sense to be > called `count()`, but that would collide with the current > `Iterator::count(|T| -> bool) -> unit` method. That method, however, is > a bit redundant, and can be easily replaced with > `iter.filter(|x| x < 5).count()`. > After this change, we could then define the `len()` method > on `iter::ExactSize`. Closes rust-lang#14678. [breaking-change]
Also fix documentation references to PartialEq.
Previously, bytes less than 16 would be encoded as %X, rather than %XX, since the output width was left to be automatic.
There were a few examples in the macros::builtin module that weren't being run because they were being #[cfg]'d out. Closes rust-lang#14697
All rust functions are internal implementation details with respect to the ABI exposed by crates, but extern fns are public components of the ABI and shouldn't be stripped. This commit serializes reachable extern fns to metadata, so when LTO is performed all of their symbols are not stripped. Closes rust-lang#14500
These were only used for the markdown tests, and there's no reason they should be distinct from the other tests.
This grows a new option inside of rustdoc to add the ability to submit examples to an external website. If the `--markdown-playground-url` command line option or crate doc attribute `html_playground_url` is present, then examples will have a button on hover to submit the code to the playground specified. This commit enables submission of example code to play.rust-lang.org. The code submitted is that which is tested by rustdoc, not necessarily the exact code shown in the example. Closes rust-lang#14654
bors
added a commit
that referenced
this pull request
Jun 7, 2014
Closes #14675 (rustc: Encode argument names for traits) Closes #14681 (rustc: Avoid UB with signed division/remainder) Closes #14682 (librustc: Update AutoObject adjustment in writeback.) Closes #14683 (Avoid 16-byte filenames in rlibs) Closes #14687 (rustdoc: Inline static documentation across crates) Closes #14689 (Remove reference to ~str in documentation) Closes #14692 (Rename Iterator::len to count) Closes #14693 (Implement Eq for HashSet and HashMap) Closes #14699 (url: encode small bytes correctly.) Closes #14700 (rustdoc: Submit examples to play.rust-lang.org) Closes #14701 (mk: Run doc tests with --cfg dox) Closes #14710 (rustc: Preserve reachable extern fns with LTO) Closes #14711 (Removing unused wrapper to libc::close.)
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 5, 2023
fix: Only pass unstable flags to cargo metadata from extra args config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14675 (rustc: Encode argument names for traits)
Closes #14681 (rustc: Avoid UB with signed division/remainder)
Closes #14682 (librustc: Update AutoObject adjustment in writeback.)
Closes #14683 (Avoid 16-byte filenames in rlibs)
Closes #14687 (rustdoc: Inline static documentation across crates)
Closes #14689 (Remove reference to ~str in documentation)
Closes #14692 (Rename Iterator::len to count)
Closes #14693 (Implement Eq for HashSet and HashMap)
Closes #14699 (url: encode small bytes correctly.)
Closes #14700 (rustdoc: Submit examples to play.rust-lang.org)
Closes #14701 (mk: Run doc tests with --cfg dox)
Closes #14710 (rustc: Preserve reachable extern fns with LTO)
Closes #14711 (Removing unused wrapper to libc::close.)