Update t-compiler beta nomination Zulip msg #147527
Merged
+5
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apiraino
force-pushed
the
update-beta-nom-zulip-msg
branch
from
b69b451 to
c340aa0
Compare
|
|
rustbot
added
the
A-meta
rustbot
added
the
S-waiting-on-review
|
rustbot has assigned @Mark-Simulacrum. Use |
apiraino
force-pushed
the
update-beta-nom-zulip-msg
branch
2 times, most recently
from
e4c6a54 to
dcb6bce
Compare
|
maybe r? @Kobzol (as soon as GitHub starts working again) |
|
We can always change the wording later, the current wording is fine by me. |
|
r? compiler (for someone to approve and merge 🙂 ) |
rustbot
added
the
T-compiler
Kobzol
reviewed
Oct 13, 2025
There was a problem hiding this comment.
Sorry, forgot to send one comment. I was mostly waiting for other people to chime in, but if no one has a comment in a ~day, you can r=me.
@bors delegate+
triagebot.toml
Outdated
| @@ -759,6 +765,7 @@ zulip_stream = 474880 # #t-compiler/backports | |||
| topic = "#{number}: beta-nominated" | |||
| message_on_add = "PR #{number} has been **accepted** for **beta** backport." | |||
|
|
|||
| # This is disabled | |||
There was a problem hiding this comment.
I would just remove this if it doesn't do anything. We can always create it again in the future if we redesign how it works.
There was a problem hiding this comment.
Are those really disabled? I don't see anything in the triagebot changes that makes them disabled. So same as @Kobzol comment, let's actually remove them.
There was a problem hiding this comment.
Stable auto-nomination was disabled in #147263 so I thought it was confusing having these bits of configuration which do nothing.
But OK I will remove the comment.
davidtwco
approved these changes
Oct 13, 2025
wesleywiser
approved these changes
Oct 13, 2025
apiraino
force-pushed
the
update-beta-nom-zulip-msg
branch
from
dcb6bce to
de67ea3
Compare
|
@bors r=Kobzol rollup |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Oct 15, 2025
Rollup of 11 pull requests Successful merges: - #143191 (Stabilize `rwlock_downgrade` library feature) - #147444 (Allow printing a fully-qualified path in `def_path_str`) - #147527 (Update t-compiler beta nomination Zulip msg) - #147670 (some `ErrorGuaranteed` cleanups) - #147676 (Return spans out of `is_doc_comment` to reduce reliance on `.span()` on attributes) - #147708 (const `mem::drop`) - #147710 (Fix ICE when using contracts on async functions) - #147716 (Fix some comments) - #147718 (miri: use allocator_shim_contents codegen helper) - #147729 (ignore boring locals when explaining why a borrow contains a point due to drop of a live local under polonius) - #147742 (Revert unintentional whitespace changes to rustfmt-excluded file) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Oct 16, 2025
Rollup merge of #147527 - apiraino:update-beta-nom-zulip-msg, r=Kobzol Update t-compiler beta nomination Zulip msg Sister patch of [triagebot#2191](rust-lang/triagebot#2191) Follow-up to #147263 The triagebot now triggers a different message when a PR is nominated for backport, making it look like more a suggestion to evaluate for the author/reviewers than a mandatory decision for the team to take. The wording (as per [triagebot#2191](rust-lang/triagebot#2191)) is open to suggestions. Thanks
github-actions bot
pushed a commit
to rust-lang/miri
that referenced
this pull request
Oct 16, 2025
Rollup of 11 pull requests Successful merges: - rust-lang/rust#143191 (Stabilize `rwlock_downgrade` library feature) - rust-lang/rust#147444 (Allow printing a fully-qualified path in `def_path_str`) - rust-lang/rust#147527 (Update t-compiler beta nomination Zulip msg) - rust-lang/rust#147670 (some `ErrorGuaranteed` cleanups) - rust-lang/rust#147676 (Return spans out of `is_doc_comment` to reduce reliance on `.span()` on attributes) - rust-lang/rust#147708 (const `mem::drop`) - rust-lang/rust#147710 (Fix ICE when using contracts on async functions) - rust-lang/rust#147716 (Fix some comments) - rust-lang/rust#147718 (miri: use allocator_shim_contents codegen helper) - rust-lang/rust#147729 (ignore boring locals when explaining why a borrow contains a point due to drop of a live local under polonius) - rust-lang/rust#147742 (Revert unintentional whitespace changes to rustfmt-excluded file) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sister patch of triagebot#2191
Follow-up to #147263
The triagebot now triggers a different message when a PR is nominated for backport, making it look like more a suggestion to evaluate for the author/reviewers than a mandatory decision for the team to take.
The wording (as per triagebot#2191) is open to suggestions.
Thanks