Skip to content

Conversation

@camelid
Copy link
Member

@camelid camelid commented Oct 13, 2025

Fixes #129209.
Fixes #131295.
Fixes #139738.

The tcx.parent tree appears to be correct now.
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 13, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 13, 2025

r? @lcnr

rustbot has assigned @lcnr.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rust-log-analyzer

This comment has been minimized.

@lcnr
Copy link
Contributor

lcnr commented Oct 14, 2025

r? @BoxyUwU lgtm, but not totally sure about the first change and don't want to look into this

@rustbot rustbot assigned BoxyUwU and unassigned lcnr Oct 14, 2025
They need an extra branch for the newtype.
@rust-log-analyzer

This comment has been minimized.

@BoxyUwU
Copy link
Member

BoxyUwU commented Oct 21, 2025

lgtm, need to move the crashes tests over to normal test suite

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 21, 2025
@BoxyUwU BoxyUwU changed the title Miscellaneous const-related fixes Miscellaneous const-generics-related fixes Oct 21, 2025
@rustbot
Copy link
Collaborator

rustbot commented Nov 1, 2025

This PR changes a file inside tests/crashes. If a crash was fixed, please move into the corresponding ui subdir and add 'Fixes #' to the PR description to autoclose the issue upon merge.

@camelid camelid added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 1, 2025
@camelid
Copy link
Member Author

camelid commented Nov 1, 2025

@bors r=BoxyUwU rollup

@bors
Copy link
Collaborator

bors commented Nov 1, 2025

📌 Commit f39fb70 has been approved by BoxyUwU

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 1, 2025
jhpratt added a commit to jhpratt/rust that referenced this pull request Nov 2, 2025
bors added a commit that referenced this pull request Nov 2, 2025
Rollup of 12 pull requests

Successful merges:

 - #147137 (Mention crate being analyzed in query description)
 - #147642 (Miscellaneous const-generics-related fixes)
 - #147806 (Ignore test-dashboard related files)
 - #147947 (Implement `strip_circumfix` lib feature)
 - #148194 (compiletest: Remove `cleanup_debug_info_options`)
 - #148199 (compiletest: Don't modify `testpaths` when creating aux contexts)
 - #148247 (Remove two special cases from reachable_non_generics)
 - #148348 (dangling ptr lint cleanup)
 - #148357 (temporary-lifetime-extension.rs test works in all editions)
 - #148362 (docs: makes a note about possible building  `rustc 1.91.0 + host tools` for win7)
 - #148367 (Use --print host-tuple to get the host)
 - #148374 (miri subtree update)

r? `@ghost`
`@rustbot` modify labels: rollup
Zalathar added a commit to Zalathar/rust that referenced this pull request Nov 2, 2025
@Zalathar
Copy link
Member

Zalathar commented Nov 2, 2025

Investigating rollup failure in #148376 (comment):

@bors try jobs=armhf-gnu

@rust-bors
Copy link

rust-bors bot commented Nov 2, 2025

⌛ Trying commit f39fb70 with merge f7fb7a9

To cancel the try build, run the command @bors try cancel.

Workflow: https://github.com/rust-lang/rust/actions/runs/19008794305

rust-bors bot added a commit that referenced this pull request Nov 2, 2025
Miscellaneous const-generics-related fixes

try-job: armhf-gnu
@Zalathar
Copy link
Member

Zalathar commented Nov 2, 2025

Failure found at #148247 (comment).

@bors try cancel

@rust-bors
Copy link

rust-bors bot commented Nov 2, 2025

Try build cancelled. Cancelled workflows:

bors added a commit that referenced this pull request Nov 2, 2025
Rollup of 9 pull requests

Successful merges:

 - #147137 (Mention crate being analyzed in query description)
 - #147155 (arm-linux.md: various fixes/improvements)
 - #147642 (Miscellaneous const-generics-related fixes)
 - #147806 (Ignore test-dashboard related files)
 - #147947 (Implement `strip_circumfix` lib feature)
 - #148346 (Change cfg_trace, cfg_attr_trace symbol values)
 - #148348 (dangling ptr lint cleanup)
 - #148393 (Remove `tests/run-make/fmt-write-bloat/`)
 - #148400 (Better warning message for crate type unsupported by codegen backend)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit ec576bb into rust-lang:master Nov 2, 2025
11 of 12 checks passed
@rustbot rustbot added this to the 1.93.0 milestone Nov 2, 2025
rust-timer added a commit that referenced this pull request Nov 2, 2025
Rollup merge of #147642 - camelid:misc-const-fixes, r=BoxyUwU

Miscellaneous const-generics-related fixes

Fixes #129209.
Fixes #131295.
Fixes #139738.
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Nov 3, 2025
Rollup of 9 pull requests

Successful merges:

 - rust-lang/rust#147137 (Mention crate being analyzed in query description)
 - rust-lang/rust#147155 (arm-linux.md: various fixes/improvements)
 - rust-lang/rust#147642 (Miscellaneous const-generics-related fixes)
 - rust-lang/rust#147806 (Ignore test-dashboard related files)
 - rust-lang/rust#147947 (Implement `strip_circumfix` lib feature)
 - rust-lang/rust#148346 (Change cfg_trace, cfg_attr_trace symbol values)
 - rust-lang/rust#148348 (dangling ptr lint cleanup)
 - rust-lang/rust#148393 (Remove `tests/run-make/fmt-write-bloat/`)
 - rust-lang/rust#148400 (Better warning message for crate type unsupported by codegen backend)

r? `@ghost`
`@rustbot` modify labels: rollup
@camelid camelid deleted the misc-const-fixes branch November 3, 2025 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ICE: cannot convert to a region vid ICE: cannot convert "'a/#4" to a region vid ICE: None in compiler/rustc_middle/src/ty/sty.rs

7 participants