Skip to content

Remove a special case and move another one out of reachable_non_generics #148247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 3, 2025
Merged

Remove a special case and move another one out of reachable_non_generics #148247

merged 2 commits into from
Nov 3, 2025
+11 −16

Conversation

@bjorn3
Copy link
Member

@bjorn3 bjorn3 commented Oct 29, 2025 •
edited
Loading

One is no longer necessary, the other is best placed in cg_llvm as it works around a cg_llvm bug.

@rustbot
Copy link
Collaborator

rustbot commented Oct 29, 2025

Some changes occurred in compiler/rustc_codegen_ssa

cc @WaffleLapkin

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 29, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 29, 2025

r? @BoxyUwU

rustbot has assigned @BoxyUwU.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@BoxyUwU
Copy link
Member

BoxyUwU commented Oct 31, 2025

r? compiler

@rustbot rustbot assigned jackh726 and unassigned BoxyUwU Oct 31, 2025
@WaffleLapkin
Copy link
Member

WaffleLapkin commented Oct 31, 2025 •
edited
Loading

What made these special cased unnecessary?

@bjorn3
Copy link
Member Author

bjorn3 commented Oct 31, 2025

For the panic runtime we now use #[rust_std_internal_symbol] which has the same behavior. For rust_eh_personality, I'm guessing something changes in LLVM causing it to no longer be necessary. But even if it is still necessary after all, the special case should be moved to prepare_lto instead which is the function that computes the actual set of symbols to export for LTO.

@WaffleLapkin
Copy link
Member

WaffleLapkin commented Nov 1, 2025

@bors r+

@bors
Copy link
Collaborator

bors commented Nov 1, 2025

📌 Commit 1b78417 has been approved by WaffleLapkin

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 1, 2025
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 1, 2025
@matthiaskrgr
Rollup merge of rust-lang#148247 - bjorn3:minor_symbol_export_cleanup…
c09c885 
…, r=WaffleLapkin

Remove two special cases from reachable_non_generics

They are no longer necessary.
@matthiaskrgr matthiaskrgr mentioned this pull request Nov 1, 2025
Closed
bors added a commit that referenced this pull request Nov 1, 2025
@bors
Auto merge of #148368 - matthiaskrgr:rollup-kiditp5, r=matthiaskrgr
0d75160 
Rollup of 8 pull requests

Successful merges:

 - #147137 (Mention crate being analyzed in query description)
 - #148099 (Prepare to move debugger discovery from compiletest to bootstrap)
 - #148194 (compiletest: Remove `cleanup_debug_info_options`)
 - #148199 (compiletest: Don't modify `testpaths` when creating aux contexts)
 - #148240 (rustc_codegen: fix musttail returns for cast/indirect ABIs)
 - #148247 (Remove two special cases from reachable_non_generics)
 - #148290 (Do not emit solver errors that contain error types)
 - #148362 (docs: makes a note about possible building  `rustc 1.91.0 + host tools` for win7)

r? `@ghost`
`@rustbot` modify labels: rollup
jhpratt added a commit to jhpratt/rust that referenced this pull request Nov 2, 2025
@jhpratt
Rollup merge of rust-lang#148247 - bjorn3:minor_symbol_export_cleanup…
8af5081 
…, r=WaffleLapkin

Remove two special cases from reachable_non_generics

They are no longer necessary.
@jhpratt jhpratt mentioned this pull request Nov 2, 2025
Closed
bors added a commit that referenced this pull request Nov 2, 2025
@bors
Auto merge of #148376 - jhpratt:rollup-tfn2bbb, r=jhpratt
45259b5 
Rollup of 12 pull requests

Successful merges:

 - #147137 (Mention crate being analyzed in query description)
 - #147642 (Miscellaneous const-generics-related fixes)
 - #147806 (Ignore test-dashboard related files)
 - #147947 (Implement `strip_circumfix` lib feature)
 - #148194 (compiletest: Remove `cleanup_debug_info_options`)
 - #148199 (compiletest: Don't modify `testpaths` when creating aux contexts)
 - #148247 (Remove two special cases from reachable_non_generics)
 - #148348 (dangling ptr lint cleanup)
 - #148357 (temporary-lifetime-extension.rs test works in all editions)
 - #148362 (docs: makes a note about possible building  `rustc 1.91.0 + host tools` for win7)
 - #148367 (Use --print host-tuple to get the host)
 - #148374 (miri subtree update)

r? `@ghost`
`@rustbot` modify labels: rollup
Zalathar added a commit to Zalathar/rust that referenced this pull request Nov 2, 2025
@Zalathar
Rollup merge of rust-lang#148247 - bjorn3:minor_symbol_export_cleanup…
ee1a756 
…, r=WaffleLapkin

Remove two special cases from reachable_non_generics

They are no longer necessary.
@Zalathar Zalathar mentioned this pull request Nov 2, 2025
Closed
@Zalathar
Copy link
Member

Zalathar commented Nov 2, 2025

Investigating rollup failure in #148376 (comment):

@bors try jobs=armhf-gnu

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors bot added a commit that referenced this pull request Nov 2, 2025
@rust-bors
Auto merge of #148247 - bjorn3:minor_symbol_export_cleanup, r=<try>
81f654f 
Remove two special cases from reachable_non_generics

try-job: armhf-gnu
@rust-bors
Copy link

rust-bors bot commented Nov 2, 2025

💔 Test for 81f654f failed: CI. Failed jobs:

@Zalathar
Copy link
Member

Zalathar commented Nov 2, 2025

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 2, 2025
This was referenced Nov 2, 2025
Merged
Merged
Merged
@rust-log-analyzer

This comment has been minimized.

Sign in to view
bjorn3 added 2 commits November 2, 2025 10:46
@bjorn3
Move a special case for rust_eh_personality from reachable_non_generi…
964d3af 
…cs to cg_llvm

This is a workaround for an LLVM bug, so put it in cg_llvm.
@bjorn3
Remove special case for the panic runtime from reachable_non_generics
e8d88c0 
The panic runtime uses #[rustc_std_internal_symbol] which has the same
effect as this special case with respect to symbol visibility.
@bjorn3 bjorn3 force-pushed the minor_symbol_export_cleanup branch from 1b78417 to e8d88c0 Compare November 2, 2025 10:47
@rustbot rustbot added the A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. label Nov 2, 2025
@rustbot
Copy link
Collaborator

rustbot commented Nov 2, 2025

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@bjorn3
Copy link
Member Author

bjorn3 commented Nov 2, 2025

Locally LTO worked just fine with the rust_eh_personality special case removed. I've now moved the special case to cg_llvm rather than remove it entirely.

@bors try jobs=armhf-gnu

rust-bors bot added a commit that referenced this pull request Nov 2, 2025
@rust-bors
Auto merge of #148247 - bjorn3:minor_symbol_export_cleanup, r=<try>
0d7a90e 
Remove two special cases from reachable_non_generics

try-job: armhf-gnu
@rust-bors

This comment has been minimized.

Sign in to view
@rust-bors
Copy link

rust-bors bot commented Nov 2, 2025

☀️ Try build successful (CI)
Build commit: 0d7a90e (0d7a90e9a9c5a8137fdb4ace16a37bfee9c5140b, parent: bd3ac0330018c23b111bbee176f32c377be7b319)

@bjorn3
Copy link
Member Author

bjorn3 commented Nov 2, 2025

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 2, 2025
@bjorn3 bjorn3 changed the title Remove two special cases from reachable_non_generics Remove a special case and move another one out of reachable_non_generics Nov 2, 2025
@WaffleLapkin
Copy link
Member

WaffleLapkin commented Nov 2, 2025

@bors r+

@bors
Copy link
Collaborator

bors commented Nov 2, 2025

📌 Commit e8d88c0 has been approved by WaffleLapkin

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 2, 2025
@Zalathar Zalathar mentioned this pull request Nov 3, 2025
Merged
bors added a commit that referenced this pull request Nov 3, 2025
@bors
Auto merge of #148420 - Zalathar:rollup-1rrbzk7, r=Zalathar
7878a91 
Rollup of 5 pull requests

Successful merges:

 - #144194 (Provide additional context to errors involving const traits)
 - #148232 (ci: add runners for vanilla LLVM 21)
 - #148240 (rustc_codegen: fix musttail returns for cast/indirect ABIs)
 - #148247 (Remove a special case and move another one out of reachable_non_generics)
 - #148370 (Point at inner item when it uses generic type param from outer item or `Self`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 4b28573 into rust-lang:master Nov 3, 2025
12 checks passed
@rustbot rustbot added this to the 1.93.0 milestone Nov 3, 2025
rust-timer added a commit that referenced this pull request Nov 3, 2025
@rust-timer
Unrolled build for #148247
6c0c58f 
Rollup merge of #148247 - bjorn3:minor_symbol_export_cleanup, r=WaffleLapkin

Remove a special case and move another one out of reachable_non_generics

One is no longer necessary, the other is best placed in cg_llvm as it works around a cg_llvm bug.
@bjorn3 bjorn3 deleted the minor_symbol_export_cleanup branch November 3, 2025 10:39
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Nov 4, 2025
@bors
Auto merge of #148420 - Zalathar:rollup-1rrbzk7, r=Zalathar
3affe26 
Rollup of 5 pull requests

Successful merges:

 - rust-lang/rust#144194 (Provide additional context to errors involving const traits)
 - rust-lang/rust#148232 (ci: add runners for vanilla LLVM 21)
 - rust-lang/rust#148240 (rustc_codegen: fix musttail returns for cast/indirect ABIs)
 - rust-lang/rust#148247 (Remove a special case and move another one out of reachable_non_generics)
 - rust-lang/rust#148370 (Point at inner item when it uses generic type param from outer item or `Self`)

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@WaffleLapkin WaffleLapkin WaffleLapkin approved these changes

Assignees

@jackh726 jackh726

Labels

A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.93.0

Development

Successfully merging this pull request may close these issues.

8 participants

@bjorn3 @rustbot @BoxyUwU @WaffleLapkin @bors @Zalathar @rust-log-analyzer @jackh726