Skip to content

Conversation

@notriddle
Copy link
Contributor

Makes sure both stages (the scraping process itself, and the doc build) emit complete dependency lists.

CC #146220
Part of #83784

@rustbot rustbot added A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Oct 29, 2025
@notriddle notriddle marked this pull request as ready for review October 29, 2025 20:07
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 29, 2025
@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Oct 29, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 29, 2025

jieyouxu is currently at their maximum review capacity.
They may take a while to respond.

@rustbot
Copy link
Collaborator

rustbot commented Oct 29, 2025

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@notriddle notriddle force-pushed the emit-scraped-examples branch from 0f8db3b to 64349b0 Compare October 29, 2025 20:32
@rust-log-analyzer

This comment has been minimized.

@notriddle notriddle force-pushed the emit-scraped-examples branch from 64349b0 to 8611f0b Compare October 29, 2025 21:55
@jieyouxu
Copy link
Member

r? rustdoc

@rustbot rustbot assigned GuillaumeGomez and unassigned jieyouxu Oct 30, 2025
@GuillaumeGomez
Copy link
Member

Thanks!

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Oct 30, 2025

📌 Commit 8611f0b has been approved by GuillaumeGomez

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 30, 2025
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Oct 30, 2025
…=GuillaumeGomez

rustdoc: fix `--emit=dep-info` on scraped examples

Makes sure both stages (the scraping process itself, and the doc build) emit complete dependency lists.

CC rust-lang#146220
Part of rust-lang#83784
bors added a commit that referenced this pull request Oct 30, 2025
Rollup of 4 pull requests

Successful merges:

 - #139751 (Implement pin-project in pattern matching for `&pin mut|const T`)
 - #147633 (Add new `--bypass-ignore-backends` option)
 - #148262 (Fix types being marked as dead when they are inferred generic arguments)
 - #148268 (rustdoc: fix `--emit=dep-info` on scraped examples)

r? `@ghost`
`@rustbot` modify labels: rollup
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Oct 30, 2025
…=GuillaumeGomez

rustdoc: fix `--emit=dep-info` on scraped examples

Makes sure both stages (the scraping process itself, and the doc build) emit complete dependency lists.

CC rust-lang#146220
Part of rust-lang#83784
bors added a commit that referenced this pull request Oct 30, 2025
Rollup of 4 pull requests

Successful merges:

 - #144291 (Constify trait aliases)
 - #147633 (Add new `--bypass-ignore-backends` option)
 - #148262 (Fix types being marked as dead when they are inferred generic arguments)
 - #148268 (rustdoc: fix `--emit=dep-info` on scraped examples)

r? `@ghost`
`@rustbot` modify labels: rollup
@fmease
Copy link
Member

fmease commented Oct 31, 2025

Failed in rollup: #148308 (comment) (job: aarch64-msvc-1)
@bors r-

@bors bors removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Oct 31, 2025
@bors bors added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Oct 31, 2025
@notriddle
Copy link
Contributor Author

foobar.d: rustdoc\ex.calls src/lib.rs

rustdoc\ex.calls:
src/lib.rs:

Does anybody know whether it's okay to use backslashes in these dep files? Should I fix the test, or the emitter?

@notriddle
Copy link
Contributor Author

Lacking any other resource to work with, I checked Cargo's dep info parser and the GNU Make docs. Both of these seem to imply that backslashes are fine, as long as they don't immediately precede a special character (like another backslash, a newline, or an asterisk):

https://doc.rust-lang.org/1.91.0/nightly-rustc/src/cargo/core/compiler/fingerprint/dep_info.rs.html#401-418

        } else if let Some(pos) = line.find(": ") {
            if found_deps {
                continue;
            }
            found_deps = true;
            let mut deps = line[pos + 2..].split_whitespace();

            while let Some(s) = deps.next() {
                let mut file = s.to_string();
                while file.ends_with('\\') {
                    file.pop();
                    file.push(' ');
                    file.push_str(deps.next().ok_or_else(|| {
                        crate::util::internal("malformed dep-info format, trailing \\")
                    })?);
                }
                ret.files.entry(file.into()).or_default();
            }

https://www.gnu.org/software/make/manual/make.html#Wildcard-Pitfall

Microsoft operating systems (MS-DOS and MS-Windows) use backslashes to separate directories in pathnames, like so:

  c:\foo\bar\baz.c

This is equivalent to the Unix-style c:/foo/bar/baz.c (the c: part is the so-called drive letter). When make runs on these systems, it supports backslashes as well as the Unix-style forward slashes in pathnames.

@notriddle
Copy link
Contributor Author

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 31, 2025
@GuillaumeGomez
Copy link
Member

Please note that / work in windows paths as well.

@notriddle
Copy link
Contributor Author

Is there anything I need to change about this code?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants