Skip to content

Conversation

@tguichaoua
Copy link
Contributor

This PR add two new methods on OpenOptionsExt in order to not change the "last access time" and "last write time" of the file on Windows.

@rustbot rustbot added O-windows Operating system: Windows S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Dec 6, 2025
@rustbot
Copy link
Collaborator

rustbot commented Dec 6, 2025

r? @ChrisDenton

rustbot has assigned @ChrisDenton.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@ChrisDenton
Copy link
Member

Sorry for the delay, this looks great thanks!

Could you squish your commits into one? Then it should be ready to merge.

@tguichaoua tguichaoua force-pushed the windows_freeze_file_times branch from c2b6a4c to d772c3d Compare January 11, 2026 11:07
@rustbot
Copy link
Collaborator

rustbot commented Jan 11, 2026

⚠️ Warning ⚠️

@ChrisDenton
Copy link
Member

Thanks!

@bors r+

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 11, 2026
@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 11, 2026

📌 Commit d772c3d has been approved by ChrisDenton

It is now in the queue for this repository.

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 11, 2026
…Denton

Add freeze file times on Windows

This PR add two new methods on [OpenOptionsExt](https://doc.rust-lang.org/stable/std/os/windows/fs/trait.OpenOptionsExt.html) in order to not change the "last access time" and "last write time" of the file on Windows.

- Tracking Issue: rust-lang#149715
- ACP: rust-lang/libs-team#708
rust-bors bot added a commit that referenced this pull request Jan 11, 2026
Rollup of 7 pull requests

Successful merges:

 - #147938 (Add const cloning of slices and tests)
 - #149718 (Add freeze file times on Windows)
 - #150438 (Remove mentions of debootstrap and chroots from the m68k-unknown-none-elf platform support doc)
 - #150906 (Simplify `#[eii]` macro using methods on ecx)
 - #150938 (Port `#[collapse_debuginfo]` to the new attribute parsing system)
 - #150953 (std: sys: fs: uefi: Implement copy)
 - #150964 (Completely list all unparsed attributes)

Failed merges:

 - #150972 (Rename EII attributes slightly (being consistent in naming things foreign items, not extern items))

r? @ghost
rust-bors bot added a commit that referenced this pull request Jan 12, 2026
Rollup of 9 pull requests

Successful merges:

 - #147938 (Add const cloning of slices and tests)
 - #149718 (Add freeze file times on Windows)
 - #150438 (Remove mentions of debootstrap and chroots from the m68k-unknown-none-elf platform support doc)
 - #150790 (feat: invisible character help string)
 - #150906 (Simplify `#[eii]` macro using methods on ecx)
 - #150938 (Port `#[collapse_debuginfo]` to the new attribute parsing system)
 - #150953 (std: sys: fs: uefi: Implement copy)
 - #150964 (Completely list all unparsed attributes)
 - #150975 (ui: add test for normalizing const projections with assoc const equality)

Failed merges:

 - #150972 (Rename EII attributes slightly (being consistent in naming things foreign items, not extern items))

r? @ghost
@rust-bors rust-bors bot merged commit e1c13ff into rust-lang:main Jan 12, 2026
11 checks passed
@rustbot rustbot added this to the 1.94.0 milestone Jan 12, 2026
rust-timer added a commit that referenced this pull request Jan 12, 2026
Rollup merge of #149718 - windows_freeze_file_times, r=ChrisDenton

Add freeze file times on Windows

This PR add two new methods on [OpenOptionsExt](https://doc.rust-lang.org/stable/std/os/windows/fs/trait.OpenOptionsExt.html) in order to not change the "last access time" and "last write time" of the file on Windows.

- Tracking Issue: #149715
- ACP: rust-lang/libs-team#708
@tguichaoua tguichaoua deleted the windows_freeze_file_times branch January 12, 2026 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

O-windows Operating system: Windows S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants