Skip to content

Conversation

@JonathanBrouwer
Copy link
Contributor

@JonathanBrouwer JonathanBrouwer commented Jan 10, 2026

Tracking issue: #131229

Felt like doing one again, has been a while :3

r? @jdonszelmann

@rustbot
Copy link
Collaborator

rustbot commented Jan 10, 2026

Some changes occurred in compiler/rustc_passes/src/check_attr.rs

cc @jdonszelmann

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann

Some changes occurred in compiler/rustc_hir/src/attrs

cc @jdonszelmann

@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 10, 2026
@rust-log-analyzer

This comment has been minimized.

Copy link
Contributor

@jdonszelmann jdonszelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me after nits and CI

View changes since this review

@jdonszelmann
Copy link
Contributor

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 11, 2026
@rustbot
Copy link
Collaborator

rustbot commented Jan 11, 2026

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@JonathanBrouwer
Copy link
Contributor Author

@bors r=jdonszelmann rollup

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 11, 2026
@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 11, 2026

📌 Commit f0da783 has been approved by jdonszelmann

It is now in the queue for this repository.

jdonszelmann added a commit to jdonszelmann/rust that referenced this pull request Jan 11, 2026
Port `#[collapse_debuginfo]` to the new attribute parsing system

Tracking issue: rust-lang#131229

Felt like doing one again, has been a while :3

r? @jdonszelmann
rust-bors bot added a commit that referenced this pull request Jan 11, 2026
Rollup of 7 pull requests

Successful merges:

 - #147938 (Add const cloning of slices and tests)
 - #150438 (Remove mentions of debootstrap and chroots from the m68k-unknown-none-elf platform support doc)
 - #150723 (std: move `errno` and related functions into `sys::io`)
 - #150906 (Simplify `#[eii]` macro using methods on ecx)
 - #150938 (Port `#[collapse_debuginfo]` to the new attribute parsing system)
 - #150953 (std: sys: fs: uefi: Implement copy)
 - #150964 (Completely list all unparsed attributes)

Failed merges:

 - #150972 (Rename EII attributes slightly (being consistent in naming things foreign items, not extern items))

r? @ghost
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 11, 2026
Port `#[collapse_debuginfo]` to the new attribute parsing system

Tracking issue: rust-lang#131229

Felt like doing one again, has been a while :3

r? @jdonszelmann
rust-bors bot added a commit that referenced this pull request Jan 11, 2026
Rollup of 7 pull requests

Successful merges:

 - #147938 (Add const cloning of slices and tests)
 - #149718 (Add freeze file times on Windows)
 - #150438 (Remove mentions of debootstrap and chroots from the m68k-unknown-none-elf platform support doc)
 - #150906 (Simplify `#[eii]` macro using methods on ecx)
 - #150938 (Port `#[collapse_debuginfo]` to the new attribute parsing system)
 - #150953 (std: sys: fs: uefi: Implement copy)
 - #150964 (Completely list all unparsed attributes)

Failed merges:

 - #150972 (Rename EII attributes slightly (being consistent in naming things foreign items, not extern items))

r? @ghost
rust-bors bot added a commit that referenced this pull request Jan 12, 2026
Rollup of 9 pull requests

Successful merges:

 - #147938 (Add const cloning of slices and tests)
 - #149718 (Add freeze file times on Windows)
 - #150438 (Remove mentions of debootstrap and chroots from the m68k-unknown-none-elf platform support doc)
 - #150790 (feat: invisible character help string)
 - #150906 (Simplify `#[eii]` macro using methods on ecx)
 - #150938 (Port `#[collapse_debuginfo]` to the new attribute parsing system)
 - #150953 (std: sys: fs: uefi: Implement copy)
 - #150964 (Completely list all unparsed attributes)
 - #150975 (ui: add test for normalizing const projections with assoc const equality)

Failed merges:

 - #150972 (Rename EII attributes slightly (being consistent in naming things foreign items, not extern items))

r? @ghost
@rust-bors rust-bors bot merged commit d6621f0 into rust-lang:main Jan 12, 2026
11 checks passed
@rustbot rustbot added this to the 1.94.0 milestone Jan 12, 2026
rust-timer added a commit that referenced this pull request Jan 12, 2026
Rollup merge of #150938 - collapse_debuginfo, r=jdonszelmann

Port `#[collapse_debuginfo]` to the new attribute parsing system

Tracking issue: #131229

Felt like doing one again, has been a while :3

r? @jdonszelmann
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants