std: merge sys::pal::common and sys_common into sys::helpers
#150047
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
rustbot has assigned @Mark-Simulacrum. Use |
rustbot
added
A-tidy
This comment has been minimized.
This comment has been minimized.
fbstj
reviewed
Dec 16, 2025
Collaborator
|
The Miri subtree was changed cc @rust-lang/miri |
Collaborator
|
☔ The latest upstream changes (presumably #150565) made this pull request unmergeable. Please resolve the merge conflicts. |
Member
|
r=me |
Contributor
|
☔ The latest upstream changes made this pull request unmergeable. Please resolve the merge conflicts. |
joboet
force-pushed
the
remove-sys_common
branch
from
9ca2dde to
7834c43
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Member
Author
Collaborator
bors
added
S-waiting-on-bors
30 tasks
bors
added a commit
that referenced
this pull request
Jan 2, 2026
…uwer Rollup of 4 pull requests Successful merges: - #149991 (Add checks for gpu-kernel calling conv) - #150047 (std: merge `sys::pal::common` and `sys_common` into `sys::helpers`) - #150441 (do not suggest method call removal if it changes receiver type) - #150616 (Update `browser-ui-test` version to `0.23.0`) r? `@ghost` `@rustbot` modify labels: rollup
github-actions bot
pushed a commit
to rust-lang/miri
that referenced
this pull request
Jan 3, 2026
…uwer Rollup of 4 pull requests Successful merges: - rust-lang/rust#149991 (Add checks for gpu-kernel calling conv) - rust-lang/rust#150047 (std: merge `sys::pal::common` and `sys_common` into `sys::helpers`) - rust-lang/rust#150441 (do not suggest method call removal if it changes receiver type) - rust-lang/rust#150616 (Update `browser-ui-test` version to `0.23.0`) r? `@ghost` `@rustbot` modify labels: rollup
github-actions bot
pushed a commit
to rust-lang/rustc-dev-guide
that referenced
this pull request
Jan 12, 2026
…uwer Rollup of 4 pull requests Successful merges: - rust-lang/rust#149991 (Add checks for gpu-kernel calling conv) - rust-lang/rust#150047 (std: merge `sys::pal::common` and `sys_common` into `sys::helpers`) - rust-lang/rust#150441 (do not suggest method call removal if it changes receiver type) - rust-lang/rust#150616 (Update `browser-ui-test` version to `0.23.0`) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #117276, this removes
sys_commonand moves its functionality and that ofsys::pal::commoninto a newly createdsys::helpersmodule.