Skip to content

do not suggest method call removal if it changes receiver type #150441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bors merged 2 commits into from
Jan 3, 2026
Merged

do not suggest method call removal if it changes receiver type #150441

bors merged 2 commits into from
Jan 3, 2026

Conversation

@fee1-dead
Copy link
Member

@fee1-dead fee1-dead commented Dec 27, 2025 •
edited by rustbot
Loading

Fixes #149487, cc @estebank

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 27, 2025
@rustbot
Copy link
Collaborator

rustbot commented Dec 27, 2025

r? @JonathanBrouwer

rustbot has assigned @JonathanBrouwer.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@JonathanBrouwer
Copy link
Contributor

JonathanBrouwer commented Dec 28, 2025

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 28, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@JonathanBrouwer
Copy link
Contributor

JonathanBrouwer commented Dec 29, 2025

Not comfortable enough with this part of the codebase to review, rerolling
r? compiler

@rustbot rustbot assigned lcnr and unassigned JonathanBrouwer Dec 29, 2025
@fee1-dead fee1-dead added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 30, 2025
@estebank
Copy link
Contributor

estebank commented Jan 2, 2026

@bors r+

@bors
Copy link
Collaborator

bors commented Jan 2, 2026

📌 Commit 998a0df has been approved by estebank

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 2, 2026
@JonathanBrouwer JonathanBrouwer mentioned this pull request Jan 2, 2026
Merged
bors added a commit that referenced this pull request Jan 2, 2026
@bors
Auto merge of #150628 - JonathanBrouwer:rollup-zy040xr, r=JonathanBro…
e8f3cfc 
…uwer

Rollup of 4 pull requests

Successful merges:

 - #149991 (Add checks for gpu-kernel calling conv)
 - #150047 (std: merge `sys::pal::common` and `sys_common` into `sys::helpers`)
 - #150441 (do not suggest method call removal if it changes receiver type)
 - #150616 (Update `browser-ui-test` version to `0.23.0`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit ce43d6c into rust-lang:main Jan 3, 2026
11 checks passed
@rustbot rustbot added this to the 1.94.0 milestone Jan 3, 2026
rust-timer added a commit that referenced this pull request Jan 3, 2026
@rust-timer
Unrolled build for #150441
2728097 
Rollup merge of #150441 - fee1-dead-contrib:push-smqzpwrpvqll, r=estebank

do not suggest method call removal if it changes receiver type

Fixes #149487, cc `@estebank`
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Jan 3, 2026
@bors
Auto merge of #150628 - JonathanBrouwer:rollup-zy040xr, r=JonathanBro…
5837f85 
…uwer

Rollup of 4 pull requests

Successful merges:

 - rust-lang/rust#149991 (Add checks for gpu-kernel calling conv)
 - rust-lang/rust#150047 (std: merge `sys::pal::common` and `sys_common` into `sys::helpers`)
 - rust-lang/rust#150441 (do not suggest method call removal if it changes receiver type)
 - rust-lang/rust#150616 (Update `browser-ui-test` version to `0.23.0`)

r? `@ghost`
`@rustbot` modify labels: rollup
github-actions bot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request Jan 12, 2026
@bors
Auto merge of #150628 - JonathanBrouwer:rollup-zy040xr, r=JonathanBro…
1bcbac5 
…uwer

Rollup of 4 pull requests

Successful merges:

 - rust-lang/rust#149991 (Add checks for gpu-kernel calling conv)
 - rust-lang/rust#150047 (std: merge `sys::pal::common` and `sys_common` into `sys::helpers`)
 - rust-lang/rust#150441 (do not suggest method call removal if it changes receiver type)
 - rust-lang/rust#150616 (Update `browser-ui-test` version to `0.23.0`)

r? `@ghost`
`@rustbot` modify labels: rollup
@github-actions github-actions bot mentioned this pull request Jan 27, 2026
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@lcnr lcnr

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.94.0

Development

Successfully merging this pull request may close these issues.

Diagnostic for .unwrap_or_default() suggests removing unrelated code

7 participants

@fee1-dead @rustbot @rust-log-analyzer @JonathanBrouwer @estebank @bors @lcnr