mapping an error from cmd.spawn() in npm::install #150425
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the tool (yarn) does not exists, spawn() raise an error, but the error message is just like a `No such file or directory`. So it is hard to understand which application/file/directory has a problem. This commit maps the error to expose the problem is around yarn.
rustbot
added
S-waiting-on-author
rustbot
added
the
S-waiting-on-review
rustbot
removed
the
S-waiting-on-author
Collaborator
|
|
Collaborator
|
rustbot has assigned @Mark-Simulacrum. Use |
Member
|
@bors r+ |
Collaborator
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Jan 2, 2026
…uwer Rollup of 6 pull requests Successful merges: - #150425 (mapping an error from cmd.spawn() in npm::install) - #150444 (Expose kernel launch options as offload intrinsic args) - #150495 (Correct hexagon "unwinder_private_data_size") - #150578 (Fix a typo in the docs of AsMut for #149609) - #150581 (mir_build: Separate match lowering for string-equality and scalar-equality) - #150594 (Fix typo in the docs of `CString::from_vec_with_nul`) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Jan 2, 2026
Rollup merge of #150425 - Shunpoco:map-npm-install-error, r=Mark-Simulacrum mapping an error from cmd.spawn() in npm::install If the tool (yarn) has a problem, spawn in the install() raises an error, but the error message is hard to understand which/how application/file/directory has a problem. This commit enhances the error to explain why it fails. For example, when I ran `./x test tidy --extra-checks=js`: ```bash ... tidy check tidy [extra_checks]: IO error: No such file or directory (os error 2) tidy [extra_checks]: FAIL tidy: The following check failed: extra_checks ``` .. It doesn't explain yarn has a problem (in that case, my env didn't have yarn). After this PR, the same command prints: ```bash tidy check can not run yarn install tidy [extra_checks]: IO error: unable to run yarn: entity not found tidy [extra_checks]: FAIL tidy: The following check failed: extra_checks ```
github-actions bot
pushed a commit
to rust-lang/rustc-dev-guide
that referenced
this pull request
Jan 2, 2026
…uwer Rollup of 6 pull requests Successful merges: - rust-lang/rust#150425 (mapping an error from cmd.spawn() in npm::install) - rust-lang/rust#150444 (Expose kernel launch options as offload intrinsic args) - rust-lang/rust#150495 (Correct hexagon "unwinder_private_data_size") - rust-lang/rust#150578 (Fix a typo in the docs of AsMut for rust-lang/rust#149609) - rust-lang/rust#150581 (mir_build: Separate match lowering for string-equality and scalar-equality) - rust-lang/rust#150594 (Fix typo in the docs of `CString::from_vec_with_nul`) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the tool (yarn) has a problem, spawn in the install() raises an error, but the error message is hard to understand which/how application/file/directory has a problem. This commit enhances the error to explain why it fails.
For example, when I ran
./x test tidy --extra-checks=js:.. It doesn't explain yarn has a problem (in that case, my env didn't have yarn).
After this PR, the same command prints: