Skip to content

mapping an error from cmd.spawn() in npm::install #150425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bors merged 1 commit into from
Jan 2, 2026
Merged

mapping an error from cmd.spawn() in npm::install #150425

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion src/build_helper/src/npm.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,16 @@ pub fn install(src_root_path: &Path, out_dir: &Path, yarn: &Path) -> Result<Path
cmd.arg("--frozen");

cmd.current_dir(out_dir);
let exit_status = cmd.spawn()?.wait()?;
let exit_status = cmd
.spawn()
.map_err(|err| {
eprintln!("can not run yarn install");
io::Error::other(Box::<dyn Error + Send + Sync>::from(format!(
"unable to run yarn: {}",
err.kind()
)))
})?
.wait()?;
if !exit_status.success() {
eprintln!("yarn install did not exit successfully");
return Err(io::Error::other(Box::<dyn Error + Send + Sync>::from(format!(
Expand Down
Loading