Skip to content

Conversation

@Kobzol
Copy link
Member

@Kobzol Kobzol commented Jan 7, 2026

It only dealt with the auto branch before.

@rustbot rustbot added A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc labels Jan 7, 2026
@rustbot
Copy link
Collaborator

rustbot commented Jan 7, 2026

r? @marcoieni

rustbot has assigned @marcoieni.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Jan 7, 2026
@Kobzol
Copy link
Member Author

Kobzol commented Jan 7, 2026

@bors r+ p=100

@bors
Copy link
Collaborator

bors commented Jan 7, 2026

📌 Commit b4fcfab has been approved by Kobzol

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Jan 7, 2026

🌲 The tree is currently closed for pull requests below priority 1000. This pull request will be tested once the tree is reopened.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 7, 2026
@rust-bors

This comment has been minimized.

rust-bors bot added a commit that referenced this pull request Jan 7, 2026
Make verify-channel.sh script compatible with new bors

It only dealt with the `auto` branch before.
@marcoieni
Copy link
Member

lgtm 👍

@rust-bors rust-bors bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 7, 2026
@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 7, 2026

💔 Test for d72d30e failed: CI. Failed jobs:

A workflow was considered to be a failure because it took only 452s. The minimum duration for CI workflows is configured to be 600s.

@rust-bors rust-bors bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 7, 2026
@Kobzol
Copy link
Member Author

Kobzol commented Jan 7, 2026

Tidy failure 😆 Next try.

@bors r=marcoieni

@bors
Copy link
Collaborator

bors commented Jan 7, 2026

📌 Commit 6f7313e has been approved by marcoieni

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Jan 7, 2026

🌲 The tree is currently closed for pull requests below priority 1000. This pull request will be tested once the tree is reopened.

@rust-bors rust-bors bot added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jan 7, 2026
@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 7, 2026

📌 Commit 6f7313e has been approved by marcoieni

It is now in the queue for this repository.

@rust-bors rust-bors bot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jan 7, 2026
@rust-bors

This comment has been minimized.

@rust-log-analyzer

This comment was marked as outdated.

@rust-bors rust-bors bot added the merged-by-bors This PR was explicitly merged by bors. label Jan 7, 2026
@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 7, 2026

☀️ Test successful - CI
Approved by: marcoieni
Pushing 84c8442 to main...

@rust-bors rust-bors bot merged commit 84c8442 into rust-lang:main Jan 7, 2026
12 checks passed
@rustbot rustbot added this to the 1.94.0 milestone Jan 7, 2026
@Kobzol Kobzol deleted the auto-branch branch January 7, 2026 15:24
@github-actions
Copy link
Contributor

github-actions bot commented Jan 7, 2026

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing d9617c8 (parent) -> 84c8442 (this PR)

Test differences

Show 2 test diffs

2 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 84c84421cc5cd8a416f58c77face28e79f6fac96 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-aarch64-linux: 8902.8s -> 6286.6s (-29.4%)
  2. aarch64-apple: 11268.6s -> 8758.8s (-22.3%)
  3. dist-aarch64-apple: 7708.6s -> 9222.4s (+19.6%)
  4. dist-aarch64-msvc: 6425.8s -> 5551.2s (-13.6%)
  5. dist-x86_64-apple: 9476.2s -> 8341.2s (-12.0%)
  6. aarch64-msvc-2: 6517.5s -> 5930.3s (-9.0%)
  7. aarch64-gnu-llvm-20-1: 3839.2s -> 3536.8s (-7.9%)
  8. x86_64-rust-for-linux: 2930.9s -> 3131.4s (+6.8%)
  9. x86_64-gnu-tools: 3420.8s -> 3639.5s (+6.4%)
  10. dist-aarch64-llvm-mingw: 6017.4s -> 6391.1s (+6.2%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (84c8442): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-0.6% [-0.6%, -0.5%] 3
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (primary 2.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
2.1% [2.1%, 2.1%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 2.1% [2.1%, 2.1%] 1

Cycles

Results (primary 2.4%, secondary 1.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
2.4% [2.3%, 2.6%] 2
Regressions ❌
(secondary)
2.3% [2.0%, 3.0%] 3
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-2.1% [-2.1%, -2.1%] 1
All ❌✅ (primary) 2.4% [2.3%, 2.6%] 2

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 474.542s -> 474.983s (0.09%)
Artifact size: 390.84 MiB -> 390.84 MiB (0.00%)

@jieyouxu jieyouxu added beta-nominated Nominated for backporting to the compiler in the beta channel. stable-nominated Nominated for backporting to the compiler in the stable channel. labels Jan 9, 2026
@jieyouxu
Copy link
Member

jieyouxu commented Jan 9, 2026

Note: dual-tagging with beta/stable nominations since we might need to backport new bors related changes to beta/stable branches (in the very off chance there's somehow a stable point release needed for reasons).

Context: #t-infra > Testing new bors in production @ 💬

@jieyouxu jieyouxu mentioned this pull request Jan 9, 2026
@cuviper cuviper added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Jan 9, 2026
@cuviper cuviper modified the milestones: 1.94.0, 1.93.0 Jan 9, 2026
@cuviper cuviper removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jan 9, 2026
rust-bors bot added a commit that referenced this pull request Jan 9, 2026
[beta] backports

- Revert "Rollup merge of #149147 - chenyukang:yukang-fix-unused_assignments-macro-gen-147648, r=JonathanBrouwer" #149657
- Don't lint on interior mutable `const` item coming from derefs #150166
- stdarch subtree update #150639 (partial)
- Update bors configuration #150308
- Update bors e-mail lookup #150783
- Make verify-channel.sh script compatible with new bors #150759

r? cuviper
@jieyouxu
Copy link
Member

jieyouxu commented Feb 5, 2026

EDIT: this was for 1.93, stable-nominated is stale.

@rustbot rustbot added the stable-accepted Accepted for backporting to the compiler in the stable channel. label Feb 5, 2026
@jieyouxu jieyouxu removed stable-nominated Nominated for backporting to the compiler in the stable channel. stable-accepted Accepted for backporting to the compiler in the stable channel. labels Feb 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc beta-accepted Accepted for backporting to the compiler in the beta channel. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants