Skip to content

Conversation

@Kobzol
Copy link
Member

@Kobzol Kobzol commented Jan 7, 2026

This should hopefully fix the post-merge CI workflow and git change detection in bootstrap.

@rustbot rustbot added A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 7, 2026
@rustbot
Copy link
Collaborator

rustbot commented Jan 7, 2026

r? @jdno

rustbot has assigned @jdno.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-release Relevant to the release subteam, which will review and decide on the PR/issue. labels Jan 7, 2026
@Kobzol
Copy link
Member Author

Kobzol commented Jan 7, 2026

@bors p=50

Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jieyouxu
Copy link
Member

jieyouxu commented Jan 8, 2026

@bors r+ rollup=never

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 8, 2026
@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 8, 2026

📌 Commit f2d0d52 has been approved by jieyouxu

It is now in the queue for this repository.

@jieyouxu jieyouxu assigned jieyouxu and unassigned jdno Jan 8, 2026
@rust-bors

This comment has been minimized.

@rust-bors rust-bors bot added the merged-by-bors This PR was explicitly merged by bors. label Jan 8, 2026
@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 8, 2026

☀️ Test successful - CI
Approved by: jieyouxu
Pushing 598c7bd to main...

@rust-bors rust-bors bot merged commit 598c7bd into rust-lang:main Jan 8, 2026
12 checks passed
@rustbot rustbot added this to the 1.94.0 milestone Jan 8, 2026
@Kobzol Kobzol deleted the bors-email-update branch January 8, 2026 06:39
@github-actions
Copy link
Contributor

github-actions bot commented Jan 8, 2026

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 548e586 (parent) -> 598c7bd (this PR)

Test differences

Show 2 test diffs

2 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 598c7bde3843ca604a9ee1df9491ee418d771edf --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. x86_64-gnu-miri: 4198.9s -> 5366.8s (+27.8%)
  2. dist-x86_64-apple: 6097.1s -> 7158.6s (+17.4%)
  3. x86_64-gnu-gcc: 3464.3s -> 3989.5s (+15.2%)
  4. pr-check-2: 2168.5s -> 2491.9s (+14.9%)
  5. aarch64-gnu-llvm-20-1: 3264.5s -> 3674.8s (+12.6%)
  6. x86_64-rust-for-linux: 2781.7s -> 3128.4s (+12.5%)
  7. pr-check-1: 1709.9s -> 1920.6s (+12.3%)
  8. x86_64-gnu-llvm-20-1: 3985.6s -> 4442.7s (+11.5%)
  9. i686-gnu-2: 5403.5s -> 6016.2s (+11.3%)
  10. test-various: 6989.5s -> 7777.3s (+11.3%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (598c7bd): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary -2.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-2.2% [-2.2%, -2.2%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -2.2% [-2.2%, -2.2%] 1

Cycles

Results (primary 2.6%, secondary -4.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
2.6% [1.9%, 3.2%] 4
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-4.9% [-4.9%, -4.9%] 1
All ❌✅ (primary) 2.6% [1.9%, 3.2%] 4

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 474.664s -> 474.717s (0.01%)
Artifact size: 390.87 MiB -> 390.81 MiB (-0.01%)

@jieyouxu jieyouxu added beta-nominated Nominated for backporting to the compiler in the beta channel. stable-nominated Nominated for backporting to the compiler in the stable channel. labels Jan 9, 2026
@jieyouxu
Copy link
Member

jieyouxu commented Jan 9, 2026

Note: dual-tagging with beta/stable nominations since we might need to backport new bors related changes to beta/stable branches (in the very off chance there's somehow a stable point release needed for reasons).

Context: #t-infra > Testing new bors in production @ 💬

@jieyouxu jieyouxu mentioned this pull request Jan 9, 2026
@cuviper cuviper added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Jan 9, 2026
@cuviper cuviper modified the milestones: 1.94.0, 1.93.0 Jan 9, 2026
@cuviper cuviper removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jan 9, 2026
rust-bors bot added a commit that referenced this pull request Jan 9, 2026
[beta] backports

- Revert "Rollup merge of #149147 - chenyukang:yukang-fix-unused_assignments-macro-gen-147648, r=JonathanBrouwer" #149657
- Don't lint on interior mutable `const` item coming from derefs #150166
- stdarch subtree update #150639 (partial)
- Update bors configuration #150308
- Update bors e-mail lookup #150783
- Make verify-channel.sh script compatible with new bors #150759

r? cuviper
@jieyouxu
Copy link
Member

jieyouxu commented Feb 5, 2026

EDIT: this was for 1.93, stable-nominated is stale.

@rustbot rustbot added the stable-accepted Accepted for backporting to the compiler in the stable channel. label Feb 5, 2026
@jieyouxu jieyouxu removed stable-nominated Nominated for backporting to the compiler in the stable channel. stable-accepted Accepted for backporting to the compiler in the stable channel. labels Feb 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc beta-accepted Accepted for backporting to the compiler in the beta channel. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-release Relevant to the release subteam, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants