Skip to content

Silence unused type param error on struct parse error #151082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rust-bors merged 1 commit into from
Jan 16, 2026
Merged

Silence unused type param error on struct parse error #151082

rust-bors merged 1 commit into from
Jan 16, 2026

Conversation

@estebank
Copy link
Contributor

@estebank estebank commented Jan 13, 2026 •
edited
Loading

Given

#[derive(Clone)]
struct B<T> {
    a: A<(T, u32)> // <- note, comma is missing here
    /// asdf
    b: u32,
}

do not emit unnecessary "unused T" error.

Fix #141403.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 13, 2026
@rustbot
Copy link
Collaborator

rustbot commented Jan 13, 2026

r? @jdonszelmann

rustbot has assigned @jdonszelmann.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Kivooeo
Copy link
Member

Kivooeo commented Jan 13, 2026

r? me

@rustbot rustbot assigned Kivooeo and unassigned jdonszelmann Jan 13, 2026
@rustbot
Copy link
Collaborator

rustbot commented Jan 13, 2026

Some changes occurred in need_type_info.rs

cc @lcnr

Kivooeo
Kivooeo approved these changes Jan 15, 2026
View reviewed changes
Copy link
Member

@Kivooeo Kivooeo left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

r=me with squash and removing link from commit name

View changes since this review

@Kivooeo
Copy link
Member

Kivooeo commented Jan 15, 2026

@bors r+ rollup

@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 15, 2026

📌 Commit 9750d22 has been approved by Kivooeo

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 15, 2026
@jhpratt jhpratt mentioned this pull request Jan 16, 2026
Merged
rust-bors bot pushed a commit that referenced this pull request Jan 16, 2026
@bors
Auto merge of #151183 - jhpratt:rollup-GxmJbns, r=jhpratt
bcf787a 
Rollup of 5 pull requests

Successful merges:

 - #150607 (Add amdgpu_dispatch_ptr intrinsic)
 - #150611 (Unify and deduplicate From<T> float tests)
 - #151082 (Silence unused type param error on struct parse error)
 - #151159 (Tidying up `tests/ui/issues` 15 tests [8/N])
 - #151164 (Stabilise `EULER_GAMMA` and `GOLDEN_RATIO` constants for `f32` and `f64`.)

r? @ghost
@rust-bors rust-bors bot merged commit 23f6cb5 into rust-lang:main Jan 16, 2026
11 checks passed
@rustbot rustbot added this to the 1.94.0 milestone Jan 16, 2026
rust-timer added a commit that referenced this pull request Jan 16, 2026
@rust-timer
Unrolled build for #151082
8c9140d 
Rollup merge of #151082 - issue-141403, r=Kivooeo

Silence unused type param error on struct parse error

Given

```
#[derive(Clone)]
struct B<T> {
    a: A<(T, u32)> // <- note, comma is missing here
    /// asdf
    b: u32,
}
```

do not emit unnecessary "unused `T`" error.

Fix #141403.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Kivooeo Kivooeo Kivooeo approved these changes

Assignees

@Kivooeo Kivooeo

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.94.0

Development

Successfully merging this pull request may close these issues.

Confusing error message from a missing comma

5 participants

@estebank @rustbot @rust-log-analyzer @Kivooeo @jdonszelmann