Tidying up tests/ui/issues 15 tests [8/N]
#151159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
reddevilmidzy
changed the title
tests/ui/issues 15 tests [8/N]
This comment has been minimized.
This comment has been minimized.
Member
Author
|
hmm, I don't know why rustbot didn't leave this comment this time. |
Member
Maybe rustbot is busy after new year holidays and overlooked that one |
This comment has been minimized.
This comment has been minimized.
Kivooeo
approved these changes
Jan 15, 2026
Member
There was a problem hiding this comment.
Honestly more like a mismatched types to me
Member
|
@bors delegate+ |
Contributor
|
✌️ @reddevilmidzy, you can now approve this pull request! If @Kivooeo told you to " |
merge privacy/privacy-sanity-2 with privacy/privacy-sanity.rs Add comment to generics/type-args-on-module-in-bound.rs Add comment to array-slice-vec/closure-in-array-eln.rs Add comment to array-slice-vec/return-in-array-len.rs Merge for-loop-while/break-outside-loop-2.rs with for-loop-while/break-outside-loop.rs Add comment to macros/column-macro-collision.rs Add comment to privacy/private-extern-fn-visibility.rs Add comment to mismatched_types/vec-hashset-type-mismatch.rs Merge std-sync-right-kind-impls-2.rs with std-sync-right-kind-impls.rs Add comment to array-slice-vec/slice-of-multi-ref.rs Add comment to mismatched_types\vec-hashset-type-mismatch.rs Add comment to derives/derive-hygiene-struct-builder.rs Add comment to label/undeclared-label-span.rs Add comment to label\undeclared-label-span.rs Add comment to mismatched_types/array-repeat-unit-struct.rs
Member
Author
|
I've applied your suggestion. thank you:) @bors r=Kivooeo |
Contributor
rust-bors
bot
added
S-waiting-on-bors
rust-bors bot
pushed a commit
that referenced
this pull request
Jan 16, 2026
Rollup of 5 pull requests Successful merges: - #150607 (Add amdgpu_dispatch_ptr intrinsic) - #150611 (Unify and deduplicate From<T> float tests) - #151082 (Silence unused type param error on struct parse error) - #151159 (Tidying up `tests/ui/issues` 15 tests [8/N]) - #151164 (Stabilise `EULER_GAMMA` and `GOLDEN_RATIO` constants for `f32` and `f64`.) r? @ghost
rust-timer
added a commit
that referenced
this pull request
Jan 16, 2026
Rollup merge of #151159 - t15, r=Kivooeo Tidying up `tests/ui/issues` 15 tests [8/N] > [!NOTE] > Intermediate commits are intended to help review, but will be squashed add comment commit prior to merge. part of #133895 There are some tests named {xxx}-2, which are meant to be merged with {xxx}. r? Kivooeo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Intermediate commits are intended to help review, but will be squashed add comment commit prior to merge.
part of #133895
There are some tests named {xxx}-2, which are meant to be merged with {xxx}.
r? Kivooeo