Skip to content

fix: thread creation failed on the wasm32-wasip1-threads target. #151309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rust-bors merged 1 commit into from
Jan 19, 2026
Merged

fix: thread creation failed on the wasm32-wasip1-threads target. #151309

rust-bors merged 1 commit into from
Jan 19, 2026
+1 −1

Conversation

@oligamiq
Copy link
Contributor

@oligamiq oligamiq commented Jan 18, 2026 •
edited
Loading

wasm32-wasip1-threads target cannot create thread since nightly-2026-01-16.
This commit (c1bcae0) broken it.
It in #151016

This pull-request fix that issue.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jan 18, 2026
@rustbot
Copy link
Collaborator

rustbot commented Jan 18, 2026

r? @joboet

rustbot has assigned @joboet.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@joboet
Copy link
Member

joboet commented Jan 18, 2026

r? @alexcrichton
Does this look right to you?

@rustbot rustbot assigned alexcrichton and unassigned joboet Jan 18, 2026
@alexcrichton
Copy link
Member

alexcrichton commented Jan 18, 2026

@bors: r+

Apologies, I should have caught this!

@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 18, 2026

Unknown command ":". Run @bors help to see available commands.

@alexcrichton
Copy link
Member

alexcrichton commented Jan 18, 2026

@bors r+

@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 18, 2026

📌 Commit b35f80f has been approved by alexcrichton

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 18, 2026
@JonathanBrouwer JonathanBrouwer mentioned this pull request Jan 18, 2026
Merged
rust-bors bot pushed a commit that referenced this pull request Jan 18, 2026
@bors
Auto merge of #151339 - JonathanBrouwer:rollup-DYrRtnq, r=JonathanBro…
9b37157 
…uwer

Rollup of 3 pull requests

Successful merges:

 - #151287 (Reorganizing `tests/ui/issues` 15 tests [2/N] )
 - #151309 (fix: thread creation failed on the wasm32-wasip1-threads target.)
 - #151335 (Port rustc allocator attributes to attribute parser)

r? @ghost
@rust-bors rust-bors bot merged commit 3222939 into rust-lang:main Jan 19, 2026
11 checks passed
@rustbot rustbot added this to the 1.95.0 milestone Jan 19, 2026
rust-timer added a commit that referenced this pull request Jan 19, 2026
@rust-timer
Unrolled build for #151309
f9c231d 
Rollup merge of #151309 - main, r=alexcrichton

fix: thread creation failed on the wasm32-wasip1-threads target.

wasm32-wasip1-threads target cannot create thread since nightly-2026-01-16.
This commit (c1bcae0) broken it.
It in #151016

This pull-request fix that issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@alexcrichton alexcrichton

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.95.0

Development

Successfully merging this pull request may close these issues.

4 participants

@oligamiq @rustbot @joboet @alexcrichton