Skip to content

Conversation

@JonathanBrouwer
Copy link
Contributor

Successful merges:

r? @ghost

Create a similar rollup

zedddie and others added 11 commits January 18, 2026 06:23
Reorganizing `tests/ui/issues` 15 tests [2/N]

part of rust-lang#133895

r? Kivooeo
fix: thread creation failed on the wasm32-wasip1-threads target.

wasm32-wasip1-threads target cannot create thread since nightly-2026-01-16.
This commit (c1bcae0) broken it.
It in rust-lang#151016

This pull-request fix that issue.
…ouwer

Port rustc allocator attributes to attribute parser

Tracking issue: rust-lang#131229

Made a new file since i saw this pattern for `rustc_dump.rs`

Very simple attributes so felt like I can do them all in one PR

r? @JonathanBrouwer
@rust-bors rust-bors bot added the rollup A PR which is a rollup label Jan 18, 2026
@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jan 18, 2026
@JonathanBrouwer
Copy link
Contributor Author

@bors r+ rollup=never p=5

@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 18, 2026

📌 Commit 47d8a87 has been approved by JonathanBrouwer

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 18, 2026
@rust-bors

This comment has been minimized.

@rust-bors rust-bors bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 19, 2026
@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 19, 2026

☀️ Test successful - CI
Approved by: JonathanBrouwer
Pushing 9b37157 to main...

@rust-bors rust-bors bot merged commit 9b37157 into rust-lang:main Jan 19, 2026
12 checks passed
@rustbot rustbot added this to the 1.95.0 milestone Jan 19, 2026
@rust-timer
Copy link
Collaborator

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#151287 Reorganizing tests/ui/issues 15 tests [2/N] 0e085707b058adbb3c94ea9ac0defda88e4c1544 (link)
#151309 fix: thread creation failed on the wasm32-wasip1-threads ta… f9c231debe4f66b1933f9f076d8292341feeee35 (link)
#151335 Port rustc allocator attributes to attribute parser 10eb0a4065361423ce593f849a58698ede1e4563 (link)

previous master: 0a3cd3b6b6

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@github-actions
Copy link
Contributor

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 0a3cd3b (parent) -> 9b37157 (this PR)

Test differences

Show 70 test diffs

Stage 1

  • [ui] tests/ui/associated-types/associated-type-as-value.rs: [missing] -> pass (J0)
  • [ui] tests/ui/cast/cast-to-unsized-type.rs: [missing] -> pass (J0)
  • [ui] tests/ui/cast/non-primitive-isize-ref-cast.rs: [missing] -> pass (J0)
  • [ui] tests/ui/enum/enum-nonexisting-field.rs: [missing] -> pass (J0)
  • [ui] tests/ui/issues/issue-11680.rs: pass -> [missing] (J0)
  • [ui] tests/ui/issues/issue-16745.rs: pass -> [missing] (J0)
  • [ui] tests/ui/issues/issue-16966.rs: pass -> [missing] (J0)
  • [ui] tests/ui/issues/issue-17351.rs: pass -> [missing] (J0)
  • [ui] tests/ui/issues/issue-17441.rs: pass -> [missing] (J0)
  • [ui] tests/ui/issues/issue-19692.rs: pass -> [missing] (J0)
  • [ui] tests/ui/issues/issue-19922.rs: pass -> [missing] (J0)
  • [ui] tests/ui/issues/issue-22599.rs: pass -> [missing] (J0)
  • [ui] tests/ui/issues/issue-24013.rs: pass -> [missing] (J0)
  • [ui] tests/ui/issues/issue-25368.rs: pass -> [missing] (J0)
  • [ui] tests/ui/issues/issue-26472.rs: pass -> [missing] (J0)
  • [ui] tests/ui/issues/issue-2995.rs: pass -> [missing] (J0)
  • [ui] tests/ui/issues/issue-34209.rs: pass -> [missing] (J0)
  • [ui] tests/ui/issues/issue-35241.rs: pass -> [missing] (J0)
  • [ui] tests/ui/issues/issue-38919.rs: pass -> [missing] (J0)
  • [ui] tests/ui/lint/unused/unused-trait-fn.rs: [missing] -> pass (J0)
  • [ui] tests/ui/lint/unused/unused-var-in-match-arm.rs: [missing] -> pass (J0)
  • [ui] tests/ui/methods/method-not-found-on-struct.rs: [missing] -> pass (J0)
  • [ui] tests/ui/pattern/enum-variant-not-found.rs: [missing] -> pass (J0)
  • [ui] tests/ui/pattern/match-constant-and-byte-literal.rs: [missing] -> pass (J0)
  • [ui] tests/ui/privacy/imported-enum-is-private.rs: [missing] -> pass (J0)
  • [ui] tests/ui/privacy/private-struct-field-in-module.rs: [missing] -> pass (J0)
  • [ui] tests/ui/type-inference/panic-with-unspecified-type.rs: [missing] -> pass (J0)
  • [ui] tests/ui/type-inference/send-with-unspecified-type.rs: [missing] -> pass (J0)
  • [ui] tests/ui/type-inference/swap-with-unspecified-type.rs: [missing] -> pass (J0)
  • [ui] tests/ui/type/struct-constructor-as-value.rs: [missing] -> pass (J0)

Stage 2

  • [ui] tests/ui/associated-types/associated-type-as-value.rs: [missing] -> pass (J1)
  • [ui] tests/ui/cast/cast-to-unsized-type.rs: [missing] -> pass (J1)
  • [ui] tests/ui/cast/non-primitive-isize-ref-cast.rs: [missing] -> pass (J1)
  • [ui] tests/ui/enum/enum-nonexisting-field.rs: [missing] -> pass (J1)
  • [ui] tests/ui/issues/issue-11680.rs: pass -> [missing] (J1)
  • [ui] tests/ui/issues/issue-16745.rs: pass -> [missing] (J1)
  • [ui] tests/ui/issues/issue-16966.rs: pass -> [missing] (J1)
  • [ui] tests/ui/issues/issue-17351.rs: pass -> [missing] (J1)
  • [ui] tests/ui/issues/issue-17441.rs: pass -> [missing] (J1)
  • [ui] tests/ui/issues/issue-19692.rs: pass -> [missing] (J1)
  • [ui] tests/ui/issues/issue-19922.rs: pass -> [missing] (J1)
  • [ui] tests/ui/issues/issue-22599.rs: pass -> [missing] (J1)
  • [ui] tests/ui/issues/issue-24013.rs: pass -> [missing] (J1)
  • [ui] tests/ui/issues/issue-25368.rs: pass -> [missing] (J1)
  • [ui] tests/ui/issues/issue-26472.rs: pass -> [missing] (J1)
  • [ui] tests/ui/issues/issue-2995.rs: pass -> [missing] (J1)
  • [ui] tests/ui/issues/issue-34209.rs: pass -> [missing] (J1)
  • [ui] tests/ui/issues/issue-35241.rs: pass -> [missing] (J1)
  • [ui] tests/ui/issues/issue-38919.rs: pass -> [missing] (J1)
  • [ui] tests/ui/lint/unused/unused-trait-fn.rs: [missing] -> pass (J1)
  • [ui] tests/ui/lint/unused/unused-var-in-match-arm.rs: [missing] -> pass (J1)
  • [ui] tests/ui/methods/method-not-found-on-struct.rs: [missing] -> pass (J1)
  • [ui] tests/ui/pattern/enum-variant-not-found.rs: [missing] -> pass (J1)
  • [ui] tests/ui/pattern/match-constant-and-byte-literal.rs: [missing] -> pass (J1)
  • [ui] tests/ui/privacy/imported-enum-is-private.rs: [missing] -> pass (J1)
  • [ui] tests/ui/privacy/private-struct-field-in-module.rs: [missing] -> pass (J1)
  • [ui] tests/ui/type-inference/panic-with-unspecified-type.rs: [missing] -> pass (J1)
  • [ui] tests/ui/type-inference/send-with-unspecified-type.rs: [missing] -> pass (J1)
  • [ui] tests/ui/type-inference/swap-with-unspecified-type.rs: [missing] -> pass (J1)
  • [ui] tests/ui/type/struct-constructor-as-value.rs: [missing] -> pass (J1)

Additionally, 10 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 9b37157eceaa7c8ba4d6759335201a7dca58c2aa --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-apple-various: 3256.2s -> 5015.2s (+54.0%)
  2. aarch64-apple: 9801.1s -> 12508.1s (+27.6%)
  3. dist-x86_64-mingw: 8826.0s -> 10063.5s (+14.0%)
  4. dist-aarch64-apple: 6700.5s -> 5766.1s (-13.9%)
  5. x86_64-gnu-llvm-20-3: 7267.6s -> 6338.7s (-12.8%)
  6. dist-aarch64-msvc: 5921.0s -> 5220.6s (-11.8%)
  7. aarch64-gnu-llvm-20-2: 3237.2s -> 2928.3s (-9.5%)
  8. test-various: 6937.9s -> 7578.7s (+9.2%)
  9. x86_64-gnu-miri: 5006.0s -> 4550.1s (-9.1%)
  10. x86_64-gnu-llvm-20-1: 4385.9s -> 3997.1s (-8.9%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-bors rust-bors bot mentioned this pull request Jan 19, 2026
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (9b37157): comparison URL.

Overall result: ❌✅ regressions and improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
0.4% [0.3%, 0.4%] 5
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-0.8% [-1.2%, -0.1%] 3
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (secondary -1.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
1.1% [1.1%, 1.1%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-2.6% [-3.0%, -2.3%] 2
All ❌✅ (primary) - - 0

Cycles

Results (secondary 3.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
3.4% [3.4%, 3.4%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 474.37s -> 474.437s (0.01%)
Artifact size: 383.25 MiB -> 383.26 MiB (0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-attributes Area: Attributes (`#[…]`, `#![…]`) A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants