add test for issue 61463 #151361
add test for issue 61463 #151361
Conversation
rustbot
added
S-waiting-on-review
|
rustbot has assigned @jdonszelmann. Use |
This comment has been minimized.
This comment has been minimized.
KaiTomotake
force-pushed
the
test-issue-61463
branch
2 times, most recently
from
cb2758f to
aab7b69
Compare
This comment has been minimized.
This comment has been minimized.
KaiTomotake
force-pushed
the
test-issue-61463
branch
from
aab7b69 to
2771070
Compare
|
Ok so, thanks for working on this, and r? me First, let's find a better name for the test, it isn't about precedence. Then let's fix the commit message and PR title to something like "add test for issue 61463". IIRC some bot will complain if you use a # or a full link so let's avoid that -- though I don't remember where it doesn't like links, maybe the PR title can have it I'm not sure. |
|
I’m doing my best, but I’m not very good at English, so it seems I used the wrong wording. |
KaiTomotake
force-pushed
the
test-issue-61463
branch
from
2771070 to
e4c38d7
Compare
|
|
|
Thanks, that makes sense. I’ll rename it to |
A test for the issue where the variable meta is mistakenly treated as a reserved keyword.
KaiTomotake
force-pushed
the
test-issue-61463
branch
from
e4c38d7 to
eeed337
Compare
Oh no need to apologize at all! No one is criticizing your English level, and most of us here are not native English speakers. I am not one. The original issue was about
That sounds fine to me as well. There's no need to iterate too much on it, just so that the test name is accurate will be enough. |
|
Thanks! @bors r+ rollup |
rust-bors
bot
added
S-waiting-on-bors
…uwer Rollup of 15 pull requests Successful merges: - #148623 (Ignore `#[doc(hidden)]` items when computing trimmed paths for printing) - #150550 (Miscellaneous cleanups to borrowck related code) - #150879 (Remove the diagnostic lints) - #150895 (rustc_errors: Add (heuristic) Syntax Highlighting for `rustc --explain`) - #150987 (remote-test-server: Fix header in batch mode) - #151004 (std: implement `sleep_until` on Apple platforms) - #151045 (Simplify some literal-value negations with `u128::wrapping_neg`) - #151119 (Support pointers in type reflection) - #151171 (Do not recover from `Trait()` if generic list is unterminated) - #151231 (HIR typeck cleanup: clarify and re-style `check_expr_unop`) - #151249 (Parse ident with allowing recovery when trying to diagnose) - #151295 (THIR patterns: Use `ty::Value` in more places throughout `const_to_pat`) - #151326 (Remove `DiagMessage::Translated` in favour of `DiagMessage::Str`) - #151361 (add test for issue 61463) - #151371 (Add `S-blocked` to `labels_blocking_approval`) r? @ghost
…uwer Rollup of 15 pull requests Successful merges: - rust-lang/rust#148623 (Ignore `#[doc(hidden)]` items when computing trimmed paths for printing) - rust-lang/rust#150550 (Miscellaneous cleanups to borrowck related code) - rust-lang/rust#150879 (Remove the diagnostic lints) - rust-lang/rust#150895 (rustc_errors: Add (heuristic) Syntax Highlighting for `rustc --explain`) - rust-lang/rust#150987 (remote-test-server: Fix header in batch mode) - rust-lang/rust#151004 (std: implement `sleep_until` on Apple platforms) - rust-lang/rust#151045 (Simplify some literal-value negations with `u128::wrapping_neg`) - rust-lang/rust#151119 (Support pointers in type reflection) - rust-lang/rust#151171 (Do not recover from `Trait()` if generic list is unterminated) - rust-lang/rust#151231 (HIR typeck cleanup: clarify and re-style `check_expr_unop`) - rust-lang/rust#151249 (Parse ident with allowing recovery when trying to diagnose) - rust-lang/rust#151295 (THIR patterns: Use `ty::Value` in more places throughout `const_to_pat`) - rust-lang/rust#151326 (Remove `DiagMessage::Translated` in favour of `DiagMessage::Str`) - rust-lang/rust#151361 (add test for issue 61463) - rust-lang/rust#151371 (Add `S-blocked` to `labels_blocking_approval`) r? @ghost
6 participants
A test for the issue where the variable meta is mistakenly treated as a reserved keyword.
close #61463