Skip to content

Move UI tests #151444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rust-bors merged 5 commits into from
Jan 21, 2026
Merged

Move UI tests #151444

rust-bors merged 5 commits into from
Jan 21, 2026

Conversation

@Delta17920
Copy link
Contributor

@Delta17920 Delta17920 commented Jan 21, 2026

Moved several regression tests from tests/ui/issues to specific folders

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 21, 2026
@rustbot
Copy link
Collaborator

rustbot commented Jan 21, 2026

r? @fee1-dead

rustbot has assigned @fee1-dead.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Kivooeo
Kivooeo reviewed Jan 21, 2026
View reviewed changes
Copy link
Member

@Kivooeo Kivooeo left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, some nits

View changes since this review

tests/ui/dyn-keyword/generic-trait-object-call.rs Outdated
Copy link
Member

@Kivooeo Kivooeo Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is more cast test

Copy link
Contributor Author

@Delta17920 Delta17920 Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

tests/ui/generics/generic-impl-method-params-2311.rs
Copy link
Member

@Kivooeo Kivooeo Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the name of the test is very generic, could you keep the issue number in the name

Copy link
Contributor Author

@Delta17920 Delta17920 Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

tests/ui/generics/generic-trait-method-params.rs Outdated
Copy link
Member

@Kivooeo Kivooeo Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above

Copy link
Contributor Author

@Delta17920 Delta17920 Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

tests/ui/generics/resolve-generic-method-param.rs Outdated
Copy link
Member

@Kivooeo Kivooeo Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above

Copy link
Contributor Author

@Delta17920 Delta17920 Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@Kivooeo Kivooeo assigned Kivooeo and unassigned fee1-dead Jan 21, 2026
@rustbot
Copy link
Collaborator

rustbot commented Jan 21, 2026

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@Kivooeo
Copy link
Member

Kivooeo commented Jan 21, 2026

cool, thanks

next time please consider editing first commit with move instead of creating few more commits on top

@bors r+ rollup

@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 21, 2026

📌 Commit 0d6d0fa has been approved by Kivooeo

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 21, 2026
@JonathanBrouwer JonathanBrouwer mentioned this pull request Jan 21, 2026
Merged
rust-bors bot pushed a commit that referenced this pull request Jan 21, 2026
@bors
Auto merge of #151459 - JonathanBrouwer:rollup-VecWQ0g, r=JonathanBro…
daa90b9 
…uwer

Rollup of 6 pull requests

Successful merges:

 - #147426 ( tests/debuginfo/basic-stepping.rs: Add revisions `default-mir-passes`, `no-SingleUseConsts-mir-pass`)
 - #150880 (Remove old error emitter)
 - #151432 (use `deny(missing_docs)` for non-mir intrinsics)
 - #151444 (Move UI tests)
 - #151445 (Derive `Default` for `QueryArenas`)
 - #151453 (make `simd_insert_dyn` and `simd_extract_dyn` const)

r? @ghost
@rust-bors rust-bors bot merged commit 6cd3cfd into rust-lang:main Jan 21, 2026
11 checks passed
@rustbot rustbot added this to the 1.95.0 milestone Jan 21, 2026
rust-timer added a commit that referenced this pull request Jan 21, 2026
@rust-timer
Unrolled build for #151444
feb31e1 
Rollup merge of #151444 - Delta17920:move-ui-tests, r=Kivooeo

Move UI tests

Moved several regression tests from `tests/ui/issues` to specific folders
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Kivooeo Kivooeo Kivooeo left review comments

Assignees

@Kivooeo Kivooeo

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.95.0

Development

Successfully merging this pull request may close these issues.

4 participants

@Delta17920 @rustbot @Kivooeo @fee1-dead